[v1] SimicsOpenBoardPkg: Always set the boot priority by default

[edk2-devel] [PATCH] SimicsOpenBoardPkg: Always set the boot priority by default

Posted by David Wei 4 years, 7 months ago

When running networks of multiple machines, Simics assigns different disk IDs to each disk created.
this change the boot priority and can't boot from SATA HDD directly.
Clear boot priority in NVRAM can fix this issue.

Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Kubacki Michael A <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

Signed-off-by: David Wei <david.y.wei@intel.com>
---
 .../Library/PlatformBootManagerLib/BdsPlatform.c           | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c
index 953a4a6c15..926ed94ca1 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c
@@ -338,10 +338,18 @@ PlatformBootManagerBeforeConsole (
   VOID
   )
 {
-//  EFI_HANDLE    Handle;
-//  EFI_STATUS    Status;
+  EFI_BOOT_MANAGER_LOAD_OPTION  *NvBootOptions;
+  UINTN                         NvBootOptionCount;
+  UINTN                         Index;
+  EFI_STATUS    Status;
+
+  DEBUG((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n"));
+
+  NvBootOptions = EfiBootManagerGetLoadOptions(&NvBootOptionCount, LoadOptionTypeBoot);
+  for (Index = 0; Index < NvBootOptionCount; Index++) {
+    Status = EfiBootManagerDeleteLoadOptionVariable(NvBootOptions[Index].OptionNumber, LoadOptionTypeBoot);
+  }
 
-  DEBUG ((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n"));
   InstallDevicePathCallback ();
 
   VisitAllInstancesOfProtocol (&gEfiPciRootBridgeIoProtocolGuid,
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47221): https://edk2.groups.io/g/devel/message/47221
Mute This Topic: https://groups.io/mt/34129361/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Always set the boot priority by default

Posted by Kubacki, Michael A 4 years, 7 months ago

* The subject should indicate [edk2-platforms] for changes in the edk2-platforms repository.
* PatchCheck.py has the following errors. Please help fix it.

    The commit message format is not valid:
     * Line 3 of commit message is too long.
    https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
    Code format is not valid:
     * EFI_D_INFO was used, but DEBUG_INFO is now recommended
       File: Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c
       Line:   DEBUG((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n"));

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of David
> Wei
> Sent: Friday, September 13, 2019 9:58 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Sinha, Ankit <ankit.sinha@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Always set the boot
> priority by default
> 
> When running networks of multiple machines, Simics assigns different disk
> IDs to each disk created.
> this change the boot priority and can't boot from SATA HDD directly.
> Clear boot priority in NVRAM can fix this issue.
> 
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Kubacki Michael A <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Signed-off-by: David Wei <david.y.wei@intel.com>
> ---
>  .../Library/PlatformBootManagerLib/BdsPlatform.c           | 14 +++++++++++-
> --
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds
> Platform.c
> b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bd
> sPlatform.c
> index 953a4a6c15..926ed94ca1 100644
> ---
> a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds
> Platform.c
> +++
> b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/B
> +++ dsPlatform.c
> @@ -338,10 +338,18 @@ PlatformBootManagerBeforeConsole (
>    VOID
>    )
>  {
> -//  EFI_HANDLE    Handle;
> -//  EFI_STATUS    Status;
> +  EFI_BOOT_MANAGER_LOAD_OPTION  *NvBootOptions;
> +  UINTN                         NvBootOptionCount;
> +  UINTN                         Index;
> +  EFI_STATUS    Status;
> +
> +  DEBUG((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n"));
> +
> +  NvBootOptions = EfiBootManagerGetLoadOptions(&NvBootOptionCount,
> + LoadOptionTypeBoot);  for (Index = 0; Index < NvBootOptionCount;
> Index++) {
> +    Status =
> +
> EfiBootManagerDeleteLoadOptionVariable(NvBootOptions[Index].OptionNu
> mb
> + er, LoadOptionTypeBoot);  }
> 
> -  DEBUG ((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n"));
>    InstallDevicePathCallback ();
> 
>    VisitAllInstancesOfProtocol (&gEfiPciRootBridgeIoProtocolGuid,
> --
> 2.16.2.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47231): https://edk2.groups.io/g/devel/message/47231
Mute This Topic: https://groups.io/mt/34129361/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-