IntelFsp2Pkg/Tools/PatchFv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Error message:
raise Exception ("'%s' is not a valid directory!" % FvDir)
NameError: name 'FvDir' is not defined
FvDir should be fvDir.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
IntelFsp2Pkg/Tools/PatchFv.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py
index edb30c816b..0c8d908063 100644
--- a/IntelFsp2Pkg/Tools/PatchFv.py
+++ b/IntelFsp2Pkg/Tools/PatchFv.py
@@ -163,7 +163,7 @@ class Symbols:
# If the fvDir is not a directory, then raise an exception
#
if not os.path.isdir(fvDir):
- raise Exception ("'%s' is not a valid directory!" % FvDir)
+ raise Exception ("'%s' is not a valid directory!" % fvDir)
#
# If the Guid.xref is not existing in fvDir, then raise an exception
--
2.27.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66175): https://edk2.groups.io/g/devel/message/66175
Mute This Topic: https://groups.io/mt/77476116/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com> > -----Original Message----- > From: fengyunhua <fengyunhua@byosoft.com.cn> > Sent: Tuesday, October 13, 2020 10:44 AM > To: devel@edk2.groups.io > Cc: Zeng, Star <star.zeng@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com> > Subject: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue > > Error message: > raise Exception ("'%s' is not a valid directory!" % FvDir) > NameError: name 'FvDir' is not defined > > FvDir should be fvDir. > > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn> > --- > IntelFsp2Pkg/Tools/PatchFv.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py > index edb30c816b..0c8d908063 100644 > --- a/IntelFsp2Pkg/Tools/PatchFv.py > +++ b/IntelFsp2Pkg/Tools/PatchFv.py > @@ -163,7 +163,7 @@ class Symbols: > # If the fvDir is not a directory, then raise an exception > # > if not os.path.isdir(fvDir): > - raise Exception ("'%s' is not a valid directory!" % FvDir) > + raise Exception ("'%s' is not a valid directory!" % fvDir) > > # > # If the Guid.xref is not existing in fvDir, then raise an exception > -- > 2.27.0.windows.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66149): https://edk2.groups.io/g/devel/message/66149 Mute This Topic: https://groups.io/mt/77476116/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> On 10/12/20, 7:44 PM, "fengyunhua" <fengyunhua@byosoft.com.cn> wrote: Error message: raise Exception ("'%s' is not a valid directory!" % FvDir) NameError: name 'FvDir' is not defined FvDir should be fvDir. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Star Zeng <star.zeng@intel.com> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn> --- IntelFsp2Pkg/Tools/PatchFv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py index edb30c816b..0c8d908063 100644 --- a/IntelFsp2Pkg/Tools/PatchFv.py +++ b/IntelFsp2Pkg/Tools/PatchFv.py @@ -163,7 +163,7 @@ class Symbols: # If the fvDir is not a directory, then raise an exception # if not os.path.isdir(fvDir): - raise Exception ("'%s' is not a valid directory!" % FvDir) + raise Exception ("'%s' is not a valid directory!" % fvDir) # # If the Guid.xref is not existing in fvDir, then raise an exception -- 2.27.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66199): https://edk2.groups.io/g/devel/message/66199 Mute This Topic: https://groups.io/mt/77476116/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks Yunhua, change pushed: 29d14d3a30fdfbe017d39b759423832054280f10 > -----Original Message----- > From: fengyunhua <fengyunhua@byosoft.com.cn> > Sent: Tuesday, October 13, 2020 10:44 AM > To: devel@edk2.groups.io > Cc: Zeng, Star <star.zeng@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com> > Subject: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue > > Error message: > raise Exception ("'%s' is not a valid directory!" % FvDir) > NameError: name 'FvDir' is not defined > > FvDir should be fvDir. > > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn> > --- > IntelFsp2Pkg/Tools/PatchFv.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py > index edb30c816b..0c8d908063 100644 > --- a/IntelFsp2Pkg/Tools/PatchFv.py > +++ b/IntelFsp2Pkg/Tools/PatchFv.py > @@ -163,7 +163,7 @@ class Symbols: > # If the fvDir is not a directory, then raise an exception > # > if not os.path.isdir(fvDir): > - raise Exception ("'%s' is not a valid directory!" % FvDir) > + raise Exception ("'%s' is not a valid directory!" % fvDir) > > # > # If the Guid.xref is not existing in fvDir, then raise an exception > -- > 2.27.0.windows.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66430): https://edk2.groups.io/g/devel/message/66430 Mute This Topic: https://groups.io/mt/77476116/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.