I submitted this a while back (April 25th) here :
https://review.coreboot.org/#/c/19443/
And I was just told that it wasn't the right place for it! So I'm
sending you an updated patch to enable NVMe.
I noticed that this was already submitted on May 10th by Kevin
O'Connor (https://mail.coreboot.org/pipermail/seabios/2017-May/011356.html)
but the patch was incomplete, so I've updated mine to mention it.
Patch is inlined below for review.

Thanks!
Youness.

----
From ff8e3f40cbf5a4cc6035635ae23462505265a74a Mon Sep 17 00:00:00 2001
From: Youness Alaoui <youness.alaoui@puri.sm>
Date: Tue, 25 Apr 2017 11:21:05 -0400
Subject: [PATCH] hw/nvme: Enable NVMe support for non-qemu hardware

NVMe support was tested on purism/librem13 laptops and SeaBIOS has
no problems in detecting and booting the drives.

This is a continuation of commit 235a8190 which was incomplete.

Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm>
---
 src/hw/nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hw/nvme.c b/src/hw/nvme.c
index 1c2bce5..11583ad 100644
--- a/src/hw/nvme.c
+++ b/src/hw/nvme.c
@@ -599,7 +599,7 @@ nvme_cmd_readwrite(struct nvme_namespace *ns,
struct disk_op_s *op, int write)
 int
 nvme_process_op(struct disk_op_s *op)
 {
-    if (!CONFIG_NVME || !runningOnQEMU())
+    if (!CONFIG_NVME)
         return DISK_RET_SUCCESS;

     struct nvme_namespace *ns = container_of(op->drive_gf, struct
nvme_namespace,
-- 
2.4.11

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

On Mon, Jun 12, 2017 at 05:53:24PM -0600, Youness Alaoui wrote:
> I submitted this a while back (April 25th) here :
> https://review.coreboot.org/#/c/19443/
> And I was just told that it wasn't the right place for it! So I'm
> sending you an updated patch to enable NVMe.
> I noticed that this was already submitted on May 10th by Kevin
> O'Connor (https://mail.coreboot.org/pipermail/seabios/2017-May/011356.html)
> but the patch was incomplete, so I've updated mine to mention it.
> Patch is inlined below for review.

Thanks.  I committed this.

-Kevin

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Thanks! And sorry, seems I registered using one email address and sent
the patch using another.

On Mon, Jun 12, 2017 at 9:12 PM, Kevin O'Connor <kevin@koconnor.net> wrote:
> On Mon, Jun 12, 2017 at 05:53:24PM -0600, Youness Alaoui wrote:
>> I submitted this a while back (April 25th) here :
>> https://review.coreboot.org/#/c/19443/
>> And I was just told that it wasn't the right place for it! So I'm
>> sending you an updated patch to enable NVMe.
>> I noticed that this was already submitted on May 10th by Kevin
>> O'Connor (https://mail.coreboot.org/pipermail/seabios/2017-May/011356.html)
>> but the patch was incomplete, so I've updated mine to mention it.
>> Patch is inlined below for review.
>
> Thanks.  I committed this.
>
> -Kevin

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios