From nobody Wed May 1 10:45:48 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) client-ip=80.81.252.135; envelope-from=seabios-bounces@seabios.org; helo=mail.coreboot.org; Authentication-Results: mx.zoho.com; dkim=fail spf=none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; Return-Path: Received: from mail.coreboot.org (mail.coreboot.org [80.81.252.135]) by mx.zohomail.com with SMTPS id 1497368501672903.3062789348612; Tue, 13 Jun 2017 08:41:41 -0700 (PDT) Received: from [127.0.0.1] (helo=ra.coresystems.de) by mail.coreboot.org with esmtp (Exim 4.86_2) (envelope-from ) id 1dKnvl-0007dm-Ri; Tue, 13 Jun 2017 17:40:33 +0200 Received: from mail-pg0-f68.google.com ([74.125.83.68]) by mail.coreboot.org with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_2) (envelope-from ) id 1dKZ8K-0002jB-8w for seabios@seabios.org; Tue, 13 Jun 2017 01:52:40 +0200 Received: by mail-pg0-f68.google.com with SMTP id v18so15682921pgb.3 for ; Mon, 12 Jun 2017 16:53:27 -0700 (PDT) Received: by 10.100.179.236 with HTTP; Mon, 12 Jun 2017 16:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to:cc; bh=3gZxdA5EBsJnoUikK0HxLcGmOxSAdd1dkbYcNeRlB4M=; b=PMBVPZezaMYCrz5DvgQRUYu1YRIjUuGo0xdsfUVQrtQCJwsxCPdrZEKep08/QOZy9F KFr1gaczyQhoeQ0U+fVhoBzVqjmANlvMykLjzLdEDFCLeZGENyR08qnN3WNhb/CHR7o4 sl/iJN8P31UccBuYLHBrpUllR1Pkz3QEiCxPOWH/1+pufLedWh/3meAchyayD2XdVUWq PXhopZI3fnxGVrpEEOyz320aXXx4e4QDx4u4SEpNXd022waPFIM+zfdhiiReGBHRolou 1eBWJfquEjNRDPxMwO2R+TvVU+WVR9fgBMROOQuiJfnh5do51v0GkWL/NnRDdnDUdKLO xbRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:cc; bh=3gZxdA5EBsJnoUikK0HxLcGmOxSAdd1dkbYcNeRlB4M=; b=VwP2YUDoRVed9RXORjG+2nyJvvtxMlnimrL36ejuDAtaWZLC1jsMYjxzrLSwZj1WbU HgP1nGV819qOW5caJOFKgoE0ts3VjMglJNO47+wiB2Gb02PBLTVEiiHZb55cVU8F91IY 5sCYiONKoPkTbssTVFkHpXbOKUDLOZxMn6YQoChUlCeZjCWgdAOSsLopiAJOZBEeblcX NPGEIG0oYZGAvDXwqI2rT0VOBB47czN2AbaNIH5bhdDb7UB4glJPEuIIcBpFMXNuNIPz zuKduzE07fikLRGhkV/Vl5e4Z9EkichDO46/A9WF91XSK3HfwFs+SdH49qc0h/aslmSQ aDSw== X-Gm-Message-State: AODbwcDIGhhA51uUa0jqPvoVBqzaWVTDbAptETMPxhU/MeBCUPv6ze8D h+eU9x+QKN14oZucuOBwI0oDDwmJyvr5gho= X-Received: by 10.99.189.18 with SMTP id a18mr50543782pgf.195.1497311604602; Mon, 12 Jun 2017 16:53:24 -0700 (PDT) MIME-Version: 1.0 From: Youness Alaoui Date: Mon, 12 Jun 2017 17:53:24 -0600 X-Google-Sender-Auth: CLqm1bZoWQyxxyNtmFacEvuAA9Q Message-ID: To: seabios@seabios.org X-Spam-Score: 3.4 (+++) X-Mailman-Approved-At: Tue, 13 Jun 2017 17:40:32 +0200 Subject: [SeaBIOS] [PATCH] hw/nvme: Enable NVMe support for non-qemu hardware X-BeenThere: seabios@seabios.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SeaBIOS mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Errors-To: seabios-bounces@seabios.org Sender: "SeaBIOS" X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" I submitted this a while back (April 25th) here : https://review.coreboot.org/#/c/19443/ And I was just told that it wasn't the right place for it! So I'm sending you an updated patch to enable NVMe. I noticed that this was already submitted on May 10th by Kevin O'Connor (https://mail.coreboot.org/pipermail/seabios/2017-May/011356.html) but the patch was incomplete, so I've updated mine to mention it. Patch is inlined below for review. Thanks! Youness. ---- From ff8e3f40cbf5a4cc6035635ae23462505265a74a Mon Sep 17 00:00:00 2001 From: Youness Alaoui Date: Tue, 25 Apr 2017 11:21:05 -0400 Subject: [PATCH] hw/nvme: Enable NVMe support for non-qemu hardware NVMe support was tested on purism/librem13 laptops and SeaBIOS has no problems in detecting and booting the drives. This is a continuation of commit 235a8190 which was incomplete. Signed-off-by: Youness Alaoui --- src/hw/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/nvme.c b/src/hw/nvme.c index 1c2bce5..11583ad 100644 --- a/src/hw/nvme.c +++ b/src/hw/nvme.c @@ -599,7 +599,7 @@ nvme_cmd_readwrite(struct nvme_namespace *ns, struct disk_op_s *op, int write) int nvme_process_op(struct disk_op_s *op) { - if (!CONFIG_NVME || !runningOnQEMU()) + if (!CONFIG_NVME) return DISK_RET_SUCCESS; struct nvme_namespace *ns =3D container_of(op->drive_gf, struct nvme_namespace, --=20 2.4.11 _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios