On 19/04/2024 09:48, Thomas Huth wrote:
> The Sparc CPU naming and the corresponding help text is somewhat
> confusing for the users. We should avoid spaces in the Names and
> provide clear information to the users what can be passed to the
> "-cpu" option.
> While we're at it, also remove the "+" from two of the CPU names
> since this character is now not allowed in device names anymore
> (and was worked around with an ugly hack in qom/object.c so far).
>
> v2:
> - Use "Sun-UltraSparc-IIIi-plus" and "Sun-UltraSparc-IV-plus"
> instead of just adding a "p" at the end
> - Drop the sentence about NetBSD and OpenBSD in the docs since
> these problems are likely fixed since a long time already
> - Added Reviewed-bys from earlier series and updated the patch
> descriptions a little bit
>
> Thomas Huth (4):
> target/sparc/cpu: Rename the CPU models with a "+" in their names
> target/sparc/cpu: Avoid spaces by default in the CPU names
> docs/system/target-sparc: Improve the Sparc documentation
> docs/about: Deprecate the old "UltraSparc" CPU names that contain a
> "+"
>
> docs/about/deprecated.rst | 9 +++++
> docs/system/target-sparc.rst | 12 ++++---
> qom/object.c | 8 -----
> target/sparc/cpu.c | 66 +++++++++++++++++++++---------------
> 4 files changed, 54 insertions(+), 41 deletions(-)
Thanks! I've applied this to my qemu-sparc branch, along with Peter's suggested tweak
to the grammar in patch 3.
ATB,
Mark.