disas/cris: Use GString instead of sprintf

[PATCH 0/6] disas/cris: Use GString instead of sprintf

Richard Henderson posted 6 patches 2 weeks, 2 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240413052333.688151-1-richard.henderson@linaro.org

Maintainers: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

disas/cris.c | 2498 +++++++++++++++++++++-----------------------------
1 file changed, 1070 insertions(+), 1428 deletions(-)

Expand all Fold all

[PATCH 0/6] disas/cris: Use GString instead of sprintf

Posted by Richard Henderson 2 weeks, 2 days ago

More sprintf cleanup encouraged by the Apple deprecation.
Probably there's a more minimal patch.  On the other hand,
there's certainly a larger cleanup possible.


r~


Richard Henderson (6):
  disas/cris: Untabify
  disas/cris: Remove TRACE_CASE and related code
  disas/cris: Drop with_reg_prefix
  disas/cris: Use GString in print_with_operands and subroutines
  disas/cris: Remove struct cris_disasm_data
  disas/cris: Improve output of register names

 disas/cris.c | 2498 +++++++++++++++++++++-----------------------------
 1 file changed, 1070 insertions(+), 1428 deletions(-)

-- 
2.34.1

Re: [PATCH 0/6] disas/cris: Use GString instead of sprintf

Posted by Edgar E. Iglesias 1 week, 6 days ago

On Sat, Apr 13, 2024 at 7:23 AM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> More sprintf cleanup encouraged by the Apple deprecation.
> Probably there's a more minimal patch.  On the other hand,
> there's certainly a larger cleanup possible.
>
>
> r~


On the series:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>


>
>
> Richard Henderson (6):
>   disas/cris: Untabify
>   disas/cris: Remove TRACE_CASE and related code
>   disas/cris: Drop with_reg_prefix
>   disas/cris: Use GString in print_with_operands and subroutines
>   disas/cris: Remove struct cris_disasm_data
>   disas/cris: Improve output of register names
>
>  disas/cris.c | 2498 +++++++++++++++++++++-----------------------------
>  1 file changed, 1070 insertions(+), 1428 deletions(-)
>
> --
> 2.34.1
>

Re: [PATCH 0/6] disas/cris: Use GString instead of sprintf

Posted by Peter Maydell 2 weeks, 2 days ago

On Sat, 13 Apr 2024 at 06:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> More sprintf cleanup encouraged by the Apple deprecation.
> Probably there's a more minimal patch.  On the other hand,
> there's certainly a larger cleanup possible.

The CRIS architecture is deprecated, so all this code will
be deleted in 9.2; that seems to me to limit the utility
of doing big cleanups on it.

thanks
-- PMM