1. Patchew
  2. QEMU
  3. View series

[PATCH v3 0/3] target/riscv: implement query-cpu-definitions

Daniel Henrique Barboza posted 3 patches 1 year ago
Failed in applying to current master (apply log)
qapi/machine-target.json      |  6 ++-
target/riscv/cpu-qom.h        | 70 +++++++++++++++++++++++++++++++++++
target/riscv/cpu.c            | 20 ++++++++--
target/riscv/cpu.h            | 46 +----------------------
target/riscv/meson.build      |  3 +-
target/riscv/riscv-qmp-cmds.c | 57 ++++++++++++++++++++++++++++
6 files changed, 150 insertions(+), 52 deletions(-)
create mode 100644 target/riscv/cpu-qom.h
create mode 100644 target/riscv/riscv-qmp-cmds.c
[PATCH v3 0/3] target/riscv: implement query-cpu-definitions
Posted by Daniel Henrique Barboza 1 year ago 
Hi,

In this v3 I removed patches 3 and 4 of v2.

Patch 3 now implements a new type that the generic CPUs (any, rv32,
rv64, x-rv128) were converted to. This type will be used by
query-cpu-definitions to determine if a given cpu is static or not based
on its type. This approach was suggested by Richard Henderson in the v2
review.

Patches are based on top of Alistair's riscv-to-apply.next.

Changes from v2:
- old patches 3 and 4: removed
- patch 3:
  - add TYPE_RISCV_DYNAMIC_CPU
  - use this type to set 'q_static' in riscv_cpu_add_definition()
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg01310.html

Daniel Henrique Barboza (3):
  target/riscv: add CPU QOM header
  target/riscv: add query-cpy-definitions support
  target/riscv: add TYPE_RISCV_DYNAMIC_CPU

 qapi/machine-target.json      |  6 ++-
 target/riscv/cpu-qom.h        | 70 +++++++++++++++++++++++++++++++++++
 target/riscv/cpu.c            | 20 ++++++++--
 target/riscv/cpu.h            | 46 +----------------------
 target/riscv/meson.build      |  3 +-
 target/riscv/riscv-qmp-cmds.c | 57 ++++++++++++++++++++++++++++
 6 files changed, 150 insertions(+), 52 deletions(-)
 create mode 100644 target/riscv/cpu-qom.h
 create mode 100644 target/riscv/riscv-qmp-cmds.c

-- 
2.39.2
Re: [PATCH v3 0/3] target/riscv: implement query-cpu-definitions
Posted by Alistair Francis 1 year ago 
On Wed, Apr 12, 2023 at 4:36 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Hi,
>
> In this v3 I removed patches 3 and 4 of v2.
>
> Patch 3 now implements a new type that the generic CPUs (any, rv32,
> rv64, x-rv128) were converted to. This type will be used by
> query-cpu-definitions to determine if a given cpu is static or not based
> on its type. This approach was suggested by Richard Henderson in the v2
> review.
>
> Patches are based on top of Alistair's riscv-to-apply.next.
>
> Changes from v2:
> - old patches 3 and 4: removed
> - patch 3:
>   - add TYPE_RISCV_DYNAMIC_CPU
>   - use this type to set 'q_static' in riscv_cpu_add_definition()
> - v2 link: https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg01310.html
>
> Daniel Henrique Barboza (3):
>   target/riscv: add CPU QOM header
>   target/riscv: add query-cpy-definitions support
>   target/riscv: add TYPE_RISCV_DYNAMIC_CPU

Thanks!

Applied to riscv-to-apply.next

Alistair

>
>  qapi/machine-target.json      |  6 ++-
>  target/riscv/cpu-qom.h        | 70 +++++++++++++++++++++++++++++++++++
>  target/riscv/cpu.c            | 20 ++++++++--
>  target/riscv/cpu.h            | 46 +----------------------
>  target/riscv/meson.build      |  3 +-
>  target/riscv/riscv-qmp-cmds.c | 57 ++++++++++++++++++++++++++++
>  6 files changed, 150 insertions(+), 52 deletions(-)
>  create mode 100644 target/riscv/cpu-qom.h
>  create mode 100644 target/riscv/riscv-qmp-cmds.c
>
> --
> 2.39.2
>
>
Re: [PATCH v3 0/3] target/riscv: implement query-cpu-definitions
Posted by Daniel Henrique Barboza 12 months ago 
Alistair,

Patch 2 has a typo right in the commit title:

"target/riscv: add query-cpy-definitions support"

it should be 'query-cpu-definitions'. Can you amend it in the tree? Or should
I re-send?



Thanks,


Daniel



On 4/16/23 23:58, Alistair Francis wrote:
> On Wed, Apr 12, 2023 at 4:36 AM Daniel Henrique Barboza
> <dbarboza@ventanamicro.com> wrote:
>>
>> Hi,
>>
>> In this v3 I removed patches 3 and 4 of v2.
>>
>> Patch 3 now implements a new type that the generic CPUs (any, rv32,
>> rv64, x-rv128) were converted to. This type will be used by
>> query-cpu-definitions to determine if a given cpu is static or not based
>> on its type. This approach was suggested by Richard Henderson in the v2
>> review.
>>
>> Patches are based on top of Alistair's riscv-to-apply.next.
>>
>> Changes from v2:
>> - old patches 3 and 4: removed
>> - patch 3:
>>    - add TYPE_RISCV_DYNAMIC_CPU
>>    - use this type to set 'q_static' in riscv_cpu_add_definition()
>> - v2 link: https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg01310.html
>>
>> Daniel Henrique Barboza (3):
>>    target/riscv: add CPU QOM header
>>    target/riscv: add query-cpy-definitions support
>>    target/riscv: add TYPE_RISCV_DYNAMIC_CPU
> 
> Thanks!
> 
> Applied to riscv-to-apply.next
> 
> Alistair
> 
>>
>>   qapi/machine-target.json      |  6 ++-
>>   target/riscv/cpu-qom.h        | 70 +++++++++++++++++++++++++++++++++++
>>   target/riscv/cpu.c            | 20 ++++++++--
>>   target/riscv/cpu.h            | 46 +----------------------
>>   target/riscv/meson.build      |  3 +-
>>   target/riscv/riscv-qmp-cmds.c | 57 ++++++++++++++++++++++++++++
>>   6 files changed, 150 insertions(+), 52 deletions(-)
>>   create mode 100644 target/riscv/cpu-qom.h
>>   create mode 100644 target/riscv/riscv-qmp-cmds.c
>>
>> --
>> 2.39.2
>>
>>
Re: [PATCH v3 0/3] target/riscv: implement query-cpu-definitions
Posted by Alistair Francis 12 months ago 
On Wed, May 3, 2023 at 7:51 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Alistair,
>
> Patch 2 has a typo right in the commit title:
>
> "target/riscv: add query-cpy-definitions support"
>
> it should be 'query-cpu-definitions'. Can you amend it in the tree? Or should
> I re-send?

I have fixed it in my tree, so no need to resend.

I did already send the PR though. I don't think it's worth re-sending
a v2 PR for the typo

Alistair

>
>
>
> Thanks,
>
>
> Daniel
>
>
>
> On 4/16/23 23:58, Alistair Francis wrote:
> > On Wed, Apr 12, 2023 at 4:36 AM Daniel Henrique Barboza
> > <dbarboza@ventanamicro.com> wrote:
> >>
> >> Hi,
> >>
> >> In this v3 I removed patches 3 and 4 of v2.
> >>
> >> Patch 3 now implements a new type that the generic CPUs (any, rv32,
> >> rv64, x-rv128) were converted to. This type will be used by
> >> query-cpu-definitions to determine if a given cpu is static or not based
> >> on its type. This approach was suggested by Richard Henderson in the v2
> >> review.
> >>
> >> Patches are based on top of Alistair's riscv-to-apply.next.
> >>
> >> Changes from v2:
> >> - old patches 3 and 4: removed
> >> - patch 3:
> >>    - add TYPE_RISCV_DYNAMIC_CPU
> >>    - use this type to set 'q_static' in riscv_cpu_add_definition()
> >> - v2 link: https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg01310.html
> >>
> >> Daniel Henrique Barboza (3):
> >>    target/riscv: add CPU QOM header
> >>    target/riscv: add query-cpy-definitions support
> >>    target/riscv: add TYPE_RISCV_DYNAMIC_CPU
> >
> > Thanks!
> >
> > Applied to riscv-to-apply.next
> >
> > Alistair
> >
> >>
> >>   qapi/machine-target.json      |  6 ++-
> >>   target/riscv/cpu-qom.h        | 70 +++++++++++++++++++++++++++++++++++
> >>   target/riscv/cpu.c            | 20 ++++++++--
> >>   target/riscv/cpu.h            | 46 +----------------------
> >>   target/riscv/meson.build      |  3 +-
> >>   target/riscv/riscv-qmp-cmds.c | 57 ++++++++++++++++++++++++++++
> >>   6 files changed, 150 insertions(+), 52 deletions(-)
> >>   create mode 100644 target/riscv/cpu-qom.h
> >>   create mode 100644 target/riscv/riscv-qmp-cmds.c
> >>
> >> --
> >> 2.39.2
> >>
> >>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.