[v2] plugin: fix clearing of plugin_mem_cbs on TB exit

[PATCH v2 0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

Richard Henderson posted 7 patches 1 year, 1 month ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Beniamino Galvani <b.galvani@gmail.com>, Strahinja Jankovic <strahinja.p.jankovic@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Tyrone Ting <kfting@nuvoton.com>, Hao Wu <wuhaotsh@google.com>, Niek Linnenbank <nieklinnenbank@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, Xiaojuan Yang <yangxiaojuan@loongson.cn>, Song Gao <gaosong@loongson.cn>, Thomas Huth <huth@tuxfamily.org>, Laurent Vivier <laurent@vivier.eu>, Stafford Horne <shorne@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>, Alistair Francis <Alistair.Francis@wdc.com>, Palmer Dabbelt <palmer@dabbelt.com>, Bin Meng <bin.meng@windriver.com>, Weiwei Li <liweiwei@iscas.ac.cn>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Vijai Kumar K <vijai@behindbytes.com>, Sunil V L <sunilvl@ventanamicro.com>, "Alex Bennée" <alex.bennee@linaro.org>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>

include/hw/core/cpu.h          |  2 +-
include/qemu/plugin-event.h    | 26 ++++++++++++++++++++++++++
include/qemu/plugin.h          | 27 ++++++---------------------
accel/accel-softmmu.c          |  2 +-
accel/tcg/cpu-exec-common.c    |  3 +++
accel/tcg/cpu-exec.c           |  5 +----
block/monitor/block-hmp-cmds.c |  1 +
cpu.c                          |  1 +
dump/dump.c                    |  1 +
dump/win_dump.c                |  1 +
hw/arm/collie.c                |  2 ++
hw/arm/cubieboard.c            |  1 +
hw/arm/musicpal.c              |  2 ++
hw/arm/npcm7xx_boards.c        |  2 ++
hw/arm/nseries.c               |  2 ++
hw/arm/omap_sx1.c              |  2 ++
hw/arm/orangepi.c              |  1 +
hw/arm/palm.c                  |  2 ++
hw/core/machine-smp.c          |  2 ++
hw/i386/sgx.c                  |  1 +
hw/loongarch/acpi-build.c      |  1 +
hw/loongarch/virt.c            |  2 ++
hw/m68k/next-cube.c            |  1 +
hw/m68k/q800.c                 |  1 +
hw/m68k/virt.c                 |  1 +
hw/openrisc/boot.c             |  1 +
hw/ppc/spapr_softmmu.c         |  2 ++
hw/riscv/opentitan.c           |  1 +
hw/riscv/shakti_c.c            |  1 +
hw/riscv/virt-acpi-build.c     |  1 +
linux-user/elfload.c           |  1 +
linux-user/exit.c              |  1 +
linux-user/syscall.c           |  1 +
plugins/core.c                 | 11 -----------
target/i386/cpu.c              |  1 +
target/i386/host-cpu.c         |  1 +
target/s390x/cpu_models.c      |  1 +
target/s390x/diag.c            |  2 ++
tcg/tcg-op.c                   |  1 -
39 files changed, 79 insertions(+), 39 deletions(-)
create mode 100644 include/qemu/plugin-event.h

Expand all Fold all

[PATCH v2 0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

Posted by Richard Henderson 1 year, 1 month ago

Changes for v2:
  * Use plugin_gen_disable_mem_helpers,
  * Remove plugin_gen_disable_mem_helpers from tcg_gen_exit_tb.
  * Break include loop with hw/core/cpu.h and qemu/plugins.h.
  * Inline plugin_gen_disable_mem_helpers.


r~


Richard Henderson (7):
  tcg: Clear plugin_mem_cbs on TB exit
  tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb
  include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT
  *: Add missing includes of qemu/error-report.h
  *: Add missing includes of qemu/plugin.h
  include/qemu: Split out plugin-event.h
  include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

 include/hw/core/cpu.h          |  2 +-
 include/qemu/plugin-event.h    | 26 ++++++++++++++++++++++++++
 include/qemu/plugin.h          | 27 ++++++---------------------
 accel/accel-softmmu.c          |  2 +-
 accel/tcg/cpu-exec-common.c    |  3 +++
 accel/tcg/cpu-exec.c           |  5 +----
 block/monitor/block-hmp-cmds.c |  1 +
 cpu.c                          |  1 +
 dump/dump.c                    |  1 +
 dump/win_dump.c                |  1 +
 hw/arm/collie.c                |  2 ++
 hw/arm/cubieboard.c            |  1 +
 hw/arm/musicpal.c              |  2 ++
 hw/arm/npcm7xx_boards.c        |  2 ++
 hw/arm/nseries.c               |  2 ++
 hw/arm/omap_sx1.c              |  2 ++
 hw/arm/orangepi.c              |  1 +
 hw/arm/palm.c                  |  2 ++
 hw/core/machine-smp.c          |  2 ++
 hw/i386/sgx.c                  |  1 +
 hw/loongarch/acpi-build.c      |  1 +
 hw/loongarch/virt.c            |  2 ++
 hw/m68k/next-cube.c            |  1 +
 hw/m68k/q800.c                 |  1 +
 hw/m68k/virt.c                 |  1 +
 hw/openrisc/boot.c             |  1 +
 hw/ppc/spapr_softmmu.c         |  2 ++
 hw/riscv/opentitan.c           |  1 +
 hw/riscv/shakti_c.c            |  1 +
 hw/riscv/virt-acpi-build.c     |  1 +
 linux-user/elfload.c           |  1 +
 linux-user/exit.c              |  1 +
 linux-user/syscall.c           |  1 +
 plugins/core.c                 | 11 -----------
 target/i386/cpu.c              |  1 +
 target/i386/host-cpu.c         |  1 +
 target/s390x/cpu_models.c      |  1 +
 target/s390x/diag.c            |  2 ++
 tcg/tcg-op.c                   |  1 -
 39 files changed, 79 insertions(+), 39 deletions(-)
 create mode 100644 include/qemu/plugin-event.h

-- 
2.34.1

Re: [PATCH v2 0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

Posted by Emilio Cota 1 year, 1 month ago

On Fri, Mar 10, 2023 at 11:52:45 -0800, Richard Henderson wrote:
> Changes for v2:
(snip)
> Richard Henderson (7):
>   tcg: Clear plugin_mem_cbs on TB exit
>   tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb
>   include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT
>   *: Add missing includes of qemu/error-report.h
>   *: Add missing includes of qemu/plugin.h
>   include/qemu: Split out plugin-event.h
>   include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

Reviewed-by: Emilio Cota <cota@braap.org>

Thanks, Richard!

Alex: is it too late to add my R-b tags to the series?

		Emilio

Re: [PATCH v2 0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

Posted by Alex Bennée 1 year, 1 month ago

Emilio Cota <cota@braap.org> writes:

> On Fri, Mar 10, 2023 at 11:52:45 -0800, Richard Henderson wrote:
>> Changes for v2:
> (snip)
>> Richard Henderson (7):
>>   tcg: Clear plugin_mem_cbs on TB exit
>>   tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb
>>   include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT
>>   *: Add missing includes of qemu/error-report.h
>>   *: Add missing includes of qemu/plugin.h
>>   include/qemu: Split out plugin-event.h
>>   include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers
>
> Reviewed-by: Emilio Cota <cota@braap.org>
>
> Thanks, Richard!
>
> Alex: is it too late to add my R-b tags to the series?

I have to re-roll so I'll do that now.

>
> 		Emilio


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

Posted by Alex Bennée 1 year, 1 month ago

Richard Henderson <richard.henderson@linaro.org> writes:

> Changes for v2:
>   * Use plugin_gen_disable_mem_helpers,
>   * Remove plugin_gen_disable_mem_helpers from tcg_gen_exit_tb.
>   * Break include loop with hw/core/cpu.h and qemu/plugins.h.
>   * Inline plugin_gen_disable_mem_helpers.

Queued to for-8.0/tweaks-and-fixes, thanks.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro