From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1678478061; cv=none; d=zohomail.com; s=zohoarc; b=kyEUl/5dL5PilijXH+RNyiFN2+rZ0m8Q5wo6zmKhdhVadbzC45KCwmmUe3R6SQgkFgHKJTsLL+w5eAjnQm7q1HJ2utcx7J/VQSrDWJrzSacvuNTr6FXYBIq0oBNqiJjbHiCv5uy+DyNj0YD+pNdCdvQXM1uYG3YiO5CEztspzbQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678478061; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VinaJbb8DVp1aqRzxC41hI4XOXtUHZDUYlixLfYKlTE=; b=b36xiuUa14B8HZY329tQAHNFjTTVHNlpC8CTs9yaow54BJIz6wMtU4XotafpR6NCj60FylLa1bYn3jB+Rg0b8SQixMll4YNV4aw0RtJk2KZEQFvzeLEBveqavhBMTllGhiymE9hx7KDIvx6hbOoJVPZkjjz2DOj/ASVM9wy1MFM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678478061909754.7432502723092; Fri, 10 Mar 2023 11:54:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1painU-0001Fc-BB; Fri, 10 Mar 2023 14:53:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1painR-0001Eh-P9 for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:52:57 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1painQ-0004eO-3k for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:52:57 -0500 Received: by mail-pj1-x1035.google.com with SMTP id me6-20020a17090b17c600b0023816b0c7ceso10997829pjb.2 for ; Fri, 10 Mar 2023 11:52:55 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:cc1c:ced1:1ec5:bd62]) by smtp.gmail.com with ESMTPSA id l1-20020a170903244100b001991d6c6c64sm351465pls.185.2023.03.10.11.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 11:52:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678477974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VinaJbb8DVp1aqRzxC41hI4XOXtUHZDUYlixLfYKlTE=; b=QVgDh/oG7rju73BZIwWWatnasdnyMMg2uy1Q0BGBudUyW8znYFapWoZ+BdGdxebsPo qrTQL4PQ2BrikqFXmpGDf+udozzflkgLBTlFs1OOac0AQbIaxt1uUhp3MS9/3/s42glQ MfnTDbTsHOBFhM409sHZkxABhu1ARjMxu2SUd6gjXHAaQ62UIep/+sP1iEOJPH8G6JYB MG3/tpNU7oqNLs6EW0zv3QlyYfUW9sQRvu7fjAXDXjVi7wZHNvDWV3I7oqTsAbo7IbU3 jd09Swhk6FIOcmcRrxGwQD9+nj1pW8MZjQg49DuPyios8hZbLFZ1fkBzr+bAqHJhkH6i 1hxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678477974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VinaJbb8DVp1aqRzxC41hI4XOXtUHZDUYlixLfYKlTE=; b=gMJccwcb8koSqmEYR/PvdJo886hxpITKxcMfhIzNv7b8Fxt2ca/rQAeMBybklBDKp1 0hnfMZ5yeCVnEVFy9mPv6O/eHgOby34waM22rzWp7NByXfRo73Ar1x3oyQU1EQKvwfqp KEtiYyeKbo5DJD8WhYulydo4vo4L9HtC3JS4HeHsCCgkHUsmUcp8ZF2u2/RzH4xHvgX5 GIAIuEfV/Y5XSqbJb/kbugXIrffz4wjLQcBDC0SuTuJx8RS4u3IiyZOzcVoldGwxGuj+ qwSNShceLSBci059podo/KGeXEd0iMFCiW6WuJ/9AawfhcJjg7BlpCZrLZbsJZ9tKhMj 1BFg== X-Gm-Message-State: AO0yUKW9gMg62ijh0XwreKlp/hErO/f4i8VhqpekDzkoIa0BTU0BfQvj 2w5z0u4rC9kJs9f31FugrD9iVYZdKf17UwEYf/0= X-Google-Smtp-Source: AK7set873ur+bw8nN1ZBjRREo9cm3PArc2QHFgY+AeqajRZFTD4GlYfoygcHViVAUHzRcAYaPUo2Tw== X-Received: by 2002:a17:903:11c8:b0:19f:1bd9:505 with SMTP id q8-20020a17090311c800b0019f1bd90505mr1139716plh.36.1678477974401; Fri, 10 Mar 2023 11:52:54 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: cota@braap.org, alex.bennee@linaro.org Subject: [PATCH v2 1/7] tcg: Clear plugin_mem_cbs on TB exit Date: Fri, 10 Mar 2023 11:52:46 -0800 Message-Id: <20230310195252.210956-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310195252.210956-1-richard.henderson@linaro.org> References: <20230310195252.210956-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1678478062410100021 Content-Type: text/plain; charset="utf-8" Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception), adjacent to where we reset can_do_io. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381 Signed-off-by: Richard Henderson Reviewed-by: Emilio Cota --- accel/tcg/cpu-exec-common.c | 2 ++ accel/tcg/cpu-exec.c | 5 +---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c index c7bc8c6efa..176ea57281 100644 --- a/accel/tcg/cpu-exec-common.c +++ b/accel/tcg/cpu-exec-common.c @@ -65,6 +65,8 @@ void cpu_loop_exit(CPUState *cpu) { /* Undo the setting in cpu_tb_exec. */ cpu->can_do_io =3D 1; + /* Undo any setting in generated code. */ + qemu_plugin_disable_mem_helpers(cpu); siglongjmp(cpu->jmp_env, 1); } =20 diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 56aaf58b9d..c815f2dbfd 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -459,6 +459,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) qemu_thread_jit_execute(); ret =3D tcg_qemu_tb_exec(env, tb_ptr); cpu->can_do_io =3D 1; + qemu_plugin_disable_mem_helpers(cpu); /* * TODO: Delay swapping back to the read-write region of the TB * until we actually need to modify the TB. The read-only copy, @@ -526,7 +527,6 @@ static void cpu_exec_exit(CPUState *cpu) if (cc->tcg_ops->cpu_exec_exit) { cc->tcg_ops->cpu_exec_exit(cpu); } - QEMU_PLUGIN_ASSERT(cpu->plugin_mem_cbs =3D=3D NULL); } =20 void cpu_exec_step_atomic(CPUState *cpu) @@ -580,7 +580,6 @@ void cpu_exec_step_atomic(CPUState *cpu) qemu_mutex_unlock_iothread(); } assert_no_pages_locked(); - qemu_plugin_disable_mem_helpers(cpu); } =20 /* @@ -1004,7 +1003,6 @@ cpu_exec_loop(CPUState *cpu, SyncClocks *sc) =20 cpu_loop_exec_tb(cpu, tb, pc, &last_tb, &tb_exit); =20 - QEMU_PLUGIN_ASSERT(cpu->plugin_mem_cbs =3D=3D NULL); /* Try to align the host and virtual clocks if the guest is in advance */ align_clocks(sc, cpu); @@ -1029,7 +1027,6 @@ static int cpu_exec_setjmp(CPUState *cpu, SyncClocks = *sc) if (qemu_mutex_iothread_locked()) { qemu_mutex_unlock_iothread(); } - qemu_plugin_disable_mem_helpers(cpu); =20 assert_no_pages_locked(); } --=20 2.34.1 From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1678478058; cv=none; d=zohomail.com; s=zohoarc; b=Qkowxemz7LFMW08iLshbBd6tTcfkKlXOQ8F2/u8K1xjJj9ds/dBlOqC7Yg+g8tvYsWgIiFDE9SUt7NsriMlWmaozWXP8ULXySMz//7nUQn/THJ+r7wlX0WcfFrqSOH2xjXFxkpJD80SIEvz45YkK4NuTZSIIXlttJ6Rj+568/Nk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678478058; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PhWkYcOhVpipdIZZNXYjZ5hy9+cyWvQ0gdF0syaRWxw=; b=O5cN7vUwU5tWOQWxrsDo5lnHaIHHv7IbzmvHrpri1eNThgYgFlZqI7dzNfLtqDJ9ZnHwSVl5R79+mB9OanjtVWNTbJoQqbRkk2zqlKwx47uEY02gk/uU0h+lNakYRF0e+wOllYLOhUswrGerVPx6WHxJn+RCHclR9Ngir0qqxXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678478058223823.248597995848; Fri, 10 Mar 2023 11:54:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1painU-0001G9-U6; Fri, 10 Mar 2023 14:53:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1painS-0001Ev-OT for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:52:58 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1painQ-0004eS-Cn for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:52:58 -0500 Received: by mail-pj1-x1032.google.com with SMTP id x20-20020a17090a8a9400b00233ba727724so8491767pjn.1 for ; Fri, 10 Mar 2023 11:52:56 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:cc1c:ced1:1ec5:bd62]) by smtp.gmail.com with ESMTPSA id l1-20020a170903244100b001991d6c6c64sm351465pls.185.2023.03.10.11.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 11:52:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678477975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PhWkYcOhVpipdIZZNXYjZ5hy9+cyWvQ0gdF0syaRWxw=; b=lnyzWyf03lzy1Mk/YnEyHnZCY58862Xp61RSY7da1niP29A8jFz+0V8TYZbu6kU/T0 5RbWFWCT1IlUIj8KnKNdJL3XyL75WzCbeyUu0eVrA/Lwz5vqFmWiQPkYLBSmmajVx4Qs NZdcFQLoW8axwhTfbEVTRgpqIKjiyw4a8/iBcTVmUI10S3zJkLR2fx0Q+sHAGgzPk5X1 kNJruhOt3MYr3d/22CMgCYGJDZ/RKs3eImtgJhjz+1ueig+Uo1QUXWEHLVeLX71wcFOX ceXWLIB081FHzVKgtXm/0BQuPl1XfmbVlkQoL4Z8gruBjp6dW2JnLzdVVgZCx1EEpUGr xk+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678477975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PhWkYcOhVpipdIZZNXYjZ5hy9+cyWvQ0gdF0syaRWxw=; b=xi/7Q33qvOqNcWL7sqOZBhFuHlsef3IQRxJKtgS7woh0htU8+VnFgcX4030meVn2+3 v/wJWedEbgaBKW4EB5XL7oUMnxwJJWp6D2WbXc6gx8g4Cbe4uLQuo8n/LP5MBAZeAHwn g1H48OLzuLTRe/CK+xA7RFYRO91fxSig9OMjexkN/PiuW1SX35gppSc/P6v0SuU7PMOg y2o/HRHAU6FqBebN0emuddToSgDwt0jgnLmfwDPSM8Hc+MsRHbgfrE8GjJXVpqh/o9uS 5Hth4oWQ4SCR9Lj9JSuc9T8CHuB4K5nuHrZARV4jtY1urVKClP5hY58+0SaRE2fxRpB8 D5+g== X-Gm-Message-State: AO0yUKWD/7UE/dlb4tEQhb7k8/Ad6Bofs7M8eL5RYjWHqblnSE2aAzV0 ojH7JApG1KNd3t4keoUhoRgu4k6S2nAJvlAWhfE= X-Google-Smtp-Source: AK7set++qPPdBhTFLAfBaSWoDhBM5h6cH8yoFoohuYKrBzUGOPC8GUixgmao/03Iuy2SdQjBFWpGUQ== X-Received: by 2002:a17:902:ce92:b0:19c:f8c5:d504 with SMTP id f18-20020a170902ce9200b0019cf8c5d504mr7814287plg.59.1678477975225; Fri, 10 Mar 2023 11:52:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: cota@braap.org, alex.bennee@linaro.org Subject: [PATCH v2 2/7] tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb Date: Fri, 10 Mar 2023 11:52:47 -0800 Message-Id: <20230310195252.210956-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310195252.210956-1-richard.henderson@linaro.org> References: <20230310195252.210956-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1678478060374100015 Content-Type: text/plain; charset="utf-8" Now that we call qemu_plugin_disable_mem_helpers in cpu_tb_exec, we don't need to do this in generated code as well. Signed-off-by: Richard Henderson Reviewed-by: Emilio Cota --- tcg/tcg-op.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 77658a88f0..cc8fdb0e46 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -2813,7 +2813,6 @@ void tcg_gen_exit_tb(const TranslationBlock *tb, unsi= gned idx) tcg_debug_assert(idx =3D=3D TB_EXIT_REQUESTED); } =20 - plugin_gen_disable_mem_helpers(); tcg_gen_op1i(INDEX_op_exit_tb, val); } =20 --=20 2.34.1 From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1678478105; cv=none; d=zohomail.com; s=zohoarc; b=IEH3lDmXG+8BPnwH76ECCCIfql2YnKdx62jz95rDtEd5vXgh3dsUvQCculw/0w1C5Y/vm2VzO0pD7zKDSbGyNa1cG8e02XCrYIiZXOU1M+/JOz0Nn904btrP/JP9Cnfm4V6uUnoul0FHcDodXBNiRpDdwKsDrT00S3C13mdrEms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678478105; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XJhvkoLDc/4Ng5JbPEdzxnJevo2RvOeeg5n87qn4/tg=; b=jVfjG69b1yfKGFumKaMTApb/CpEkQZiz1Pkzj9urnnRISN4RpF0GMo2jbL6EGpHV3GY2TLTpshsN6pMZturoAGhbogGpicw7PWqJNOHGSaQVr73WfAlpA6FiGkaUzyC+qsXjN16u2zhqlS6OpLlv6poSDrj0KL8Np/jsMFpSuJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678478105755327.9970881425023; Fri, 10 Mar 2023 11:55:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1painV-0001GI-Ik; Fri, 10 Mar 2023 14:53:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1painT-0001F2-04 for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:52:59 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1painR-0004ec-I6 for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:52:58 -0500 Received: by mail-pl1-x632.google.com with SMTP id p6so6843319plf.0 for ; Fri, 10 Mar 2023 11:52:57 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:cc1c:ced1:1ec5:bd62]) by smtp.gmail.com with ESMTPSA id l1-20020a170903244100b001991d6c6c64sm351465pls.185.2023.03.10.11.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 11:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678477976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XJhvkoLDc/4Ng5JbPEdzxnJevo2RvOeeg5n87qn4/tg=; b=KwYjaAFt0znM53McSuz0AxQHgNt5kJR27R1NhUPcRkYZ7PtRjVqRMEgUaYtb5VCtUo Vcn16SGaqaXcmsp3NwFwt6mnXv4tn/g5XHjssfxt6bNNkJarHzZFxsT/Xr8jXyRm/i8O v5U25w85BIQtOAPSBB7Bw3nmPd1bWpFW/NY8M+RPUnxMwG4fxsS1QbIryXJN+URY4n1Z 54J98Wp3kbyn3LEpwoyViqk0TaUe9sYeJJk9c7ehSrvav4Fc10PgMXy1FeUKFXEVvAq6 8FyPqCsSdlVrMSKFTQvoPKtOvaqlKkeCUaR9PX7et4If8DHyNHaDoeNEOoBDsbbQycsw O8WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678477976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XJhvkoLDc/4Ng5JbPEdzxnJevo2RvOeeg5n87qn4/tg=; b=jNKV9f7XD2cry5kcx4eb+T5y/KYULZfm5LG5R9Xq3I/D1D/3HTqXPJqHwQPm3bZ5DJ ljgO6gynsU5QQI3bETmlBIM+zvJFX3H+q4MUoUQBk1utoKqkjxor3dNgjYCLj9BbEGrV MgGA0YMjpLHT4Cx6pZbocthTU/FIborBU3rmteGLFRV9Y8tNQig1v+iOyuAIuXUyrTPp foKzHMxL3f9emgm6Ny/xtufYxnxLcZP14f0jDzDETb+ACjcJIfvHb9nBHjMWZ+gpYTy2 SuamkQ8mQsBJKVCclV6aDIuWGfC2iZQ/WnG7AuhqBxNz3wUhjDavLgwPFc1PGVTmIeMO H79g== X-Gm-Message-State: AO0yUKVEoRNi4g6ECI/y2Y8Hrvr5M3SLabqlspmy9gqlK0dAdHeqthXn OP/TYUSbQKyOYXH9pzDHpq1RC4jhxIBvgVnfDBA= X-Google-Smtp-Source: AK7set95Uk7GG7GcZpxfZWXujNECQDcg9HWArWGxujFqNAWMZML2pR1gP7Z3rpHfSWHxzBmFZSEyvA== X-Received: by 2002:a17:902:f64f:b0:19e:bc8e:6421 with SMTP id m15-20020a170902f64f00b0019ebc8e6421mr20097482plg.47.1678477976064; Fri, 10 Mar 2023 11:52:56 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: cota@braap.org, alex.bennee@linaro.org Subject: [PATCH v2 3/7] include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT Date: Fri, 10 Mar 2023 11:52:48 -0800 Message-Id: <20230310195252.210956-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310195252.210956-1-richard.henderson@linaro.org> References: <20230310195252.210956-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1678478106552100003 Content-Type: text/plain; charset="utf-8" This macro is no longer used. Signed-off-by: Richard Henderson Reviewed-by: Emilio Cota --- include/qemu/plugin.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index fb338ba576..e0ebedef84 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -59,8 +59,6 @@ get_plugin_meminfo_rw(qemu_plugin_meminfo_t i) #ifdef CONFIG_PLUGIN extern QemuOptsList qemu_plugin_opts; =20 -#define QEMU_PLUGIN_ASSERT(cond) g_assert(cond) - static inline void qemu_plugin_add_opts(void) { qemu_add_opts(&qemu_plugin_opts); @@ -252,8 +250,6 @@ void qemu_plugin_user_postfork(bool is_child); =20 #else /* !CONFIG_PLUGIN */ =20 -#define QEMU_PLUGIN_ASSERT(cond) - static inline void qemu_plugin_add_opts(void) { } =20 --=20 2.34.1 From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1678478057; cv=none; d=zohomail.com; s=zohoarc; b=CtaZvfPrpiVZ+cYaug8oi+kREP+Qtg0/AtyXJ5aGm3706BMbvFbJeftUPPuvJ2XKZNzBQIsmOOQhKcXEvLq0YWzWg6k71WYXz6pL2WPZ3JJ67leHC8ehZYsIpyiMRFD0+X31QVDBldUBaCiMrF7Tzl5+h1ajAonpEWm2WGP9WlU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678478057; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PCVfpfWkb0dy6EcTres8gN6yf4ibNKsCmhMREXR7+eQ=; b=W16fZk8GqGRQHVZ3XkIe/ULUYzscByGf2qjH9eMM43EsGdgvIb1h9Rzxqx2g4ynbKQ/z7xNl8oT/SxBg//ONzgEXWi/Z1eWZCyxP7NBaZ/785Z4FbdFXkW80Ynf/zZFbcg30GB0aw/JoL9wtxFKBW7wheJBpLwPOCdz9S0ArKzQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678478057114801.3739953644646; Fri, 10 Mar 2023 11:54:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1painX-0001H7-ST; Fri, 10 Mar 2023 14:53:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1painU-0001G1-Mx for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:00 -0500 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1painS-0004eh-7w for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:00 -0500 Received: by mail-pj1-x102a.google.com with SMTP id me6-20020a17090b17c600b0023816b0c7ceso10997931pjb.2 for ; Fri, 10 Mar 2023 11:52:57 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:cc1c:ced1:1ec5:bd62]) by smtp.gmail.com with ESMTPSA id l1-20020a170903244100b001991d6c6c64sm351465pls.185.2023.03.10.11.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 11:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678477977; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PCVfpfWkb0dy6EcTres8gN6yf4ibNKsCmhMREXR7+eQ=; b=jZ5YglmdHckafuqkOJjkWyuyK5jmu8V4T3bCYBEJgnDYzb6I6paUyfvdf15gXnP1FT 3raexHYjvUP93G18esKqaQ1JBp9K1Yqoa/hFQZcMaf9I8LtfRqKt3KqASI2TyTzfWv/n DwgQayKZrqPr9bYsjdUHUbLbsPRheFRguYpuSWEC06OGupKaqvZB984fS2GPYoFjL27a Xtp+vcbrtwnF1OkT0FPQ8wCQcbbV/hwh6PKykYuTRSsmrT9NNzxk5ixrBAMurl1+0vM5 Z9rMxjNWP8WK5oONezPiKmdczgxxhafiOrPMDZe6cLYya5elKDxkkdud0uiVQHenAk0z FuYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678477977; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PCVfpfWkb0dy6EcTres8gN6yf4ibNKsCmhMREXR7+eQ=; b=cZguSgVuft3UGdUAEEHtD9zglqhxJHSPerGw+29ZHpIsMrxP4A/xR94nJaMXQxYEM2 tcDMFxWSUDaKXLYmIjj+yrX6Rt+8xC2ImXzmi7PJdhkqX4UqwiujFDXl0gJAblcM3Cb1 ux+bBIGilqMvAiOf03EdIOsP05VSoYQPcflbi6hNzDwm+TW48LTNC5t9tPMBBeoEy3oo HCEeKzKK+ZW39tvv3ZEZJ06VHP7c2cmYPwXugxfquQSG0MaTN8NBoN0I5lIcBsnF4/Jp T1KSaACZrnct30xfx+Ohl+0e1wLghMfsl+uT24c82zA7UWqtES31NM12ZZY1B8dDOIvZ RDkw== X-Gm-Message-State: AO0yUKVpe3fn59POwdhxI5g2vbTvIL9CsAYEysUZ4X1brc0A5aCFdCf+ bcxsNMA3FqHDAHcVDWUE/PlzOVdruQtRCEUfbsA= X-Google-Smtp-Source: AK7set8Qjemi8+yV8owuEu6NjirqZ4Y4H0IU9m3ceW3JGOmennX1Jbvadd9VbTGp/BmfIB6m6ym2uw== X-Received: by 2002:a17:902:c40d:b0:19d:1ffd:1485 with SMTP id k13-20020a170902c40d00b0019d1ffd1485mr32975102plk.66.1678477976838; Fri, 10 Mar 2023 11:52:56 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: cota@braap.org, alex.bennee@linaro.org Subject: [PATCH v2 4/7] *: Add missing includes of qemu/error-report.h Date: Fri, 10 Mar 2023 11:52:49 -0800 Message-Id: <20230310195252.210956-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310195252.210956-1-richard.henderson@linaro.org> References: <20230310195252.210956-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1678478058471100009 Content-Type: text/plain; charset="utf-8" This had been pulled in via qemu/plugin.h from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson Reviewed-by: Emilio Cota Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/accel-softmmu.c | 2 +- block/monitor/block-hmp-cmds.c | 1 + dump/dump.c | 1 + dump/win_dump.c | 1 + hw/arm/collie.c | 2 ++ hw/arm/cubieboard.c | 1 + hw/arm/musicpal.c | 2 ++ hw/arm/npcm7xx_boards.c | 2 ++ hw/arm/nseries.c | 2 ++ hw/arm/omap_sx1.c | 2 ++ hw/arm/orangepi.c | 1 + hw/arm/palm.c | 2 ++ hw/core/machine-smp.c | 2 ++ hw/i386/sgx.c | 1 + hw/loongarch/acpi-build.c | 1 + hw/loongarch/virt.c | 2 ++ hw/m68k/next-cube.c | 1 + hw/m68k/q800.c | 1 + hw/m68k/virt.c | 1 + hw/openrisc/boot.c | 1 + hw/ppc/spapr_softmmu.c | 2 ++ hw/riscv/opentitan.c | 1 + hw/riscv/shakti_c.c | 1 + hw/riscv/virt-acpi-build.c | 1 + linux-user/elfload.c | 1 + target/i386/cpu.c | 1 + target/i386/host-cpu.c | 1 + target/s390x/cpu_models.c | 1 + target/s390x/diag.c | 2 ++ 29 files changed, 39 insertions(+), 1 deletion(-) diff --git a/accel/accel-softmmu.c b/accel/accel-softmmu.c index f9cdafb148..9c804ba9e3 100644 --- a/accel/accel-softmmu.c +++ b/accel/accel-softmmu.c @@ -27,7 +27,7 @@ #include "qemu/accel.h" #include "hw/boards.h" #include "sysemu/cpus.h" - +#include "qemu/error-report.h" #include "accel-softmmu.h" =20 int accel_init_machine(AccelState *accel, MachineState *ms) diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c index 6aa5f1be0c..2846083546 100644 --- a/block/monitor/block-hmp-cmds.c +++ b/block/monitor/block-hmp-cmds.c @@ -48,6 +48,7 @@ #include "qemu/option.h" #include "qemu/sockets.h" #include "qemu/cutils.h" +#include "qemu/error-report.h" #include "sysemu/sysemu.h" #include "monitor/monitor.h" #include "monitor/hmp.h" diff --git a/dump/dump.c b/dump/dump.c index 544d5bce3a..1f1a6edcab 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -24,6 +24,7 @@ #include "qapi/qapi-commands-dump.h" #include "qapi/qapi-events-dump.h" #include "qapi/qmp/qerror.h" +#include "qemu/error-report.h" #include "qemu/main-loop.h" #include "hw/misc/vmcoreinfo.h" #include "migration/blocker.h" diff --git a/dump/win_dump.c b/dump/win_dump.c index 0152f7330a..b7bfaff379 100644 --- a/dump/win_dump.c +++ b/dump/win_dump.c @@ -11,6 +11,7 @@ #include "qemu/osdep.h" #include "sysemu/dump.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "qapi/qmp/qerror.h" #include "exec/cpu-defs.h" #include "hw/core/cpu.h" diff --git a/hw/arm/collie.c b/hw/arm/collie.c index 9edff59370..a0ad1b8dc7 100644 --- a/hw/arm/collie.c +++ b/hw/arm/collie.c @@ -19,6 +19,8 @@ #include "exec/address-spaces.h" #include "cpu.h" #include "qom/object.h" +#include "qemu/error-report.h" + =20 #define RAM_SIZE (512 * MiB) #define FLASH_SIZE (32 * MiB) diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c index 71a7df1508..8c7fa91529 100644 --- a/hw/arm/cubieboard.c +++ b/hw/arm/cubieboard.c @@ -17,6 +17,7 @@ =20 #include "qemu/osdep.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "hw/boards.h" #include "hw/qdev-properties.h" #include "hw/arm/allwinner-a10.h" diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index 06d9add7c7..c9010b2ffb 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -37,6 +37,8 @@ #include "qemu/cutils.h" #include "qom/object.h" #include "hw/net/mv88w8618_eth.h" +#include "qemu/error-report.h" + =20 #define MP_MISC_BASE 0x80002000 #define MP_MISC_SIZE 0x00001000 diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 9b31207a06..2aef579aac 100644 --- a/hw/arm/npcm7xx_boards.c +++ b/hw/arm/npcm7xx_boards.c @@ -30,6 +30,8 @@ #include "sysemu/blockdev.h" #include "sysemu/sysemu.h" #include "sysemu/block-backend.h" +#include "qemu/error-report.h" + =20 #define NPCM7XX_POWER_ON_STRAPS_DEFAULT ( \ NPCM7XX_PWRON_STRAP_SPI0F18 | \ diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index c9df063a08..9e49e9e177 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -45,6 +45,8 @@ #include "hw/loader.h" #include "hw/sysbus.h" #include "qemu/log.h" +#include "qemu/error-report.h" + =20 /* Nokia N8x0 support */ struct n800_s { diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c index e721292079..4bf1579f8c 100644 --- a/hw/arm/omap_sx1.c +++ b/hw/arm/omap_sx1.c @@ -37,6 +37,8 @@ #include "exec/address-spaces.h" #include "cpu.h" #include "qemu/cutils.h" +#include "qemu/error-report.h" + =20 /*************************************************************************= ****/ /* Siemens SX1 Cellphone V1 */ diff --git a/hw/arm/orangepi.c b/hw/arm/orangepi.c index 3ace474870..10653361ed 100644 --- a/hw/arm/orangepi.c +++ b/hw/arm/orangepi.c @@ -21,6 +21,7 @@ #include "qemu/units.h" #include "exec/address-spaces.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "hw/boards.h" #include "hw/qdev-properties.h" #include "hw/arm/allwinner-h3.h" diff --git a/hw/arm/palm.c b/hw/arm/palm.c index 1457f10c83..17c11ac4ce 100644 --- a/hw/arm/palm.c +++ b/hw/arm/palm.c @@ -32,6 +32,8 @@ #include "cpu.h" #include "qemu/cutils.h" #include "qom/object.h" +#include "qemu/error-report.h" + =20 static uint64_t static_read(void *opaque, hwaddr offset, unsigned size) { diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c index c3dab007da..89fe0cda42 100644 --- a/hw/core/machine-smp.c +++ b/hw/core/machine-smp.c @@ -20,6 +20,8 @@ #include "qemu/osdep.h" #include "hw/boards.h" #include "qapi/error.h" +#include "qemu/error-report.h" + =20 /* * Report information of a machine's supported CPU topology hierarchy. diff --git a/hw/i386/sgx.c b/hw/i386/sgx.c index db004d17a6..70305547d4 100644 --- a/hw/i386/sgx.c +++ b/hw/i386/sgx.c @@ -18,6 +18,7 @@ #include "monitor/monitor.h" #include "monitor/hmp-target.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "qapi/qapi-commands-misc-target.h" #include "exec/address-spaces.h" #include "sysemu/hw_accel.h" diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c index 6cb2472d33..8e3ce07367 100644 --- a/hw/loongarch/acpi-build.c +++ b/hw/loongarch/acpi-build.c @@ -7,6 +7,7 @@ =20 #include "qemu/osdep.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "qemu/bitmap.h" #include "hw/pci/pci.h" #include "hw/core/cpu.h" diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 38ef7cc49f..b702c3f51e 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -44,6 +44,8 @@ #include "sysemu/tpm.h" #include "sysemu/block-backend.h" #include "hw/block/flash.h" +#include "qemu/error-report.h" + =20 static void virt_flash_create(LoongArchMachineState *lams) { diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index e0d4a94f9d..ce8ee50b9e 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -24,6 +24,7 @@ #include "hw/block/fdc.h" #include "hw/qdev-properties.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "ui/console.h" #include "target/m68k/cpu.h" #include "migration/vmstate.h" diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index 9d52ca6613..b35ecafbc7 100644 --- a/hw/m68k/q800.c +++ b/hw/m68k/q800.c @@ -45,6 +45,7 @@ #include "hw/block/swim.h" #include "net/net.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "sysemu/qtest.h" #include "sysemu/runstate.h" #include "sysemu/reset.h" diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c index 4cb5beef1a..754b9bdfcc 100644 --- a/hw/m68k/virt.c +++ b/hw/m68k/virt.c @@ -23,6 +23,7 @@ #include "bootinfo.h" #include "net/net.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "sysemu/qtest.h" #include "sysemu/runstate.h" #include "sysemu/reset.h" diff --git a/hw/openrisc/boot.c b/hw/openrisc/boot.c index 007e80cd5a..55475aa6d6 100644 --- a/hw/openrisc/boot.c +++ b/hw/openrisc/boot.c @@ -15,6 +15,7 @@ #include "sysemu/device_tree.h" #include "sysemu/qtest.h" #include "sysemu/reset.h" +#include "qemu/error-report.h" =20 #include =20 diff --git a/hw/ppc/spapr_softmmu.c b/hw/ppc/spapr_softmmu.c index 5170a33369..278666317e 100644 --- a/hw/ppc/spapr_softmmu.c +++ b/hw/ppc/spapr_softmmu.c @@ -1,12 +1,14 @@ #include "qemu/osdep.h" #include "qemu/cutils.h" #include "qemu/memalign.h" +#include "qemu/error-report.h" #include "cpu.h" #include "helper_regs.h" #include "hw/ppc/spapr.h" #include "mmu-hash64.h" #include "mmu-book3s-v3.h" =20 + static inline bool valid_ptex(PowerPCCPU *cpu, target_ulong ptex) { /* diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c index b06944d382..bc678766e7 100644 --- a/hw/riscv/opentitan.c +++ b/hw/riscv/opentitan.c @@ -22,6 +22,7 @@ #include "qemu/cutils.h" #include "hw/riscv/opentitan.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "hw/boards.h" #include "hw/misc/unimp.h" #include "hw/riscv/boot.h" diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c index e43cc9445c..12ea74b032 100644 --- a/hw/riscv/shakti_c.c +++ b/hw/riscv/shakti_c.c @@ -20,6 +20,7 @@ #include "hw/boards.h" #include "hw/riscv/shakti_c.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "hw/intc/sifive_plic.h" #include "hw/intc/riscv_aclint.h" #include "sysemu/sysemu.h" diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index 82da0a238c..7331248f59 100644 --- a/hw/riscv/virt-acpi-build.c +++ b/hw/riscv/virt-acpi-build.c @@ -29,6 +29,7 @@ #include "hw/acpi/aml-build.h" #include "hw/acpi/utils.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "sysemu/reset.h" #include "migration/vmstate.h" #include "hw/riscv/virt.h" diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 5928c14dfc..8c794586c8 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -18,6 +18,7 @@ #include "qemu/units.h" #include "qemu/selfmap.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "target_signal.h" #include "accel/tcg/debuginfo.h" =20 diff --git a/target/i386/cpu.c b/target/i386/cpu.c index cab1e2a957..6576287e5b 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -29,6 +29,7 @@ #include "kvm/kvm_i386.h" #include "sev.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "qapi/qapi-visit-machine.h" #include "qapi/qmp/qerror.h" #include "standard-headers/asm-x86/kvm_para.h" diff --git a/target/i386/host-cpu.c b/target/i386/host-cpu.c index 10f8aba86e..92ecb7254b 100644 --- a/target/i386/host-cpu.c +++ b/target/i386/host-cpu.c @@ -11,6 +11,7 @@ #include "cpu.h" #include "host-cpu.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "sysemu/sysemu.h" =20 /* Note: Only safe for use on x86(-64) hosts */ diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 065ec6d66c..457b5cb10c 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -17,6 +17,7 @@ #include "sysemu/kvm.h" #include "sysemu/tcg.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "qapi/visitor.h" #include "qemu/module.h" #include "qemu/hw-version.h" diff --git a/target/s390x/diag.c b/target/s390x/diag.c index 76b01dcd68..e5f0df19e7 100644 --- a/target/s390x/diag.c +++ b/target/s390x/diag.c @@ -22,6 +22,8 @@ #include "hw/s390x/pv.h" #include "sysemu/kvm.h" #include "kvm/kvm_s390x.h" +#include "qemu/error-report.h" + =20 int handle_diag_288(CPUS390XState *env, uint64_t r1, uint64_t r3) { --=20 2.34.1 From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1678478092; cv=none; d=zohomail.com; s=zohoarc; b=mOpKdeWRyAPyxodexa67S02B01unKRXjmVyDQFv6Vh9Nb8JA2hRqPZ/OZLFp8yAiMLZMd1cbPwUoQbjZ1XzZDtWgGYp2wtHrjA/XAdXp6bGbHTxcfF8pvkgMYSk7obrLHadi0EMyTFXDFTapoXmTvfI7yNzNf937h9bCLp9R0qw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678478092; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q1DnbR7KQTC+x6ysScZJbOrppJZcpcAPm9qgXNyJ5JE=; b=ZlbyuBoMK0yFJV5+tXR4BUQSbbkO86hwQDXSzAAE+UGwLd/9q1otY/rMM3abId5v2h7XA2ZRRyUXZFekaDNW+uTQ4i0qnSe/rdqOkUxRTWYTc4HWwzvoiL87ZF6EKsC/lBmq2ikplhLqyZkBVHlR36Z2FChoF6lQllYual0QqFQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678478092578776.3411664659052; Fri, 10 Mar 2023 11:54:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1painW-0001GQ-62; Fri, 10 Mar 2023 14:53:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1painU-0001G0-MY for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:00 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1painT-0004f4-2M for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:00 -0500 Received: by mail-pl1-x629.google.com with SMTP id x11so6765480pln.12 for ; Fri, 10 Mar 2023 11:52:58 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:cc1c:ced1:1ec5:bd62]) by smtp.gmail.com with ESMTPSA id l1-20020a170903244100b001991d6c6c64sm351465pls.185.2023.03.10.11.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 11:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678477978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q1DnbR7KQTC+x6ysScZJbOrppJZcpcAPm9qgXNyJ5JE=; b=lrq24zTUOGU/rLGb1ndBs526zLC3QlVYI9QU1A7r5v/zgfwabH3TtBk/uekkBGFFIA Ic9Gl+D08gk4d3UDgOXekKv81wU3X8LFyNCHDwgGSv4lnQzSURAbWqwrsik6J4F0PA/R NTvQlwF8Xc++Ql5oZJlMqqYAuf7WdM77TJrjHLrXBRemSxTlg7dnpH66bPhFZhmZfWqS 42u4ZcMN4MprN8mM/xahqh9drsMu4ON6tt1YbtIJo5R5ZFUz9M3Ujvsz0niKimSTZ5kB db00LqbESHHiunai3h+T+VhFgCwJX7cr5IIcA2ZMit4/wP6L0Adi/jItAL/HNaLDkeCD JmoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678477978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q1DnbR7KQTC+x6ysScZJbOrppJZcpcAPm9qgXNyJ5JE=; b=QMB4mZwFl8EfdH4Ut4zrgshPQQF1DPGi8ueNaYAwkOpaCKf6/Sk+B3CTBbRegZkB/e 70UPim+LawGyqZm1mQdmvm98E67A0i0PjruKcPhxWjWnTrvq0O7IkfAN42vqZnxAh/85 3esYZLZasjpouEFfWjF1WrU+6v6bWE0gf/w5hiQ8t38QQkB64QMgQsP7qaXhhvumSdbb ELi/d679L+g6BJjaqgvWAqPgVk7cVDykrhj7oIM9J9vLRJzjWdOLuPrZe4iHHZl6Bhhk Qern/ejwkiaDtfFZHdFBMRP4dhnjZmt3GGZlcA0O7mYgMQs3B9h59ErnAh72Fteus7ku kFsQ== X-Gm-Message-State: AO0yUKXrLyTJWA6D8XMFCAWdMNZPislMnxQ8FdmqSi0kAEH+29j0bldu 4E7XQthVP1f1HdRITSobhetWqZtoazhiuZDkN3s= X-Google-Smtp-Source: AK7set8745t4jvIGFRq2ztXm3dnvw9MpW0PD7bi5nAsC3DdgkYbl/MIbl7+nmbDaUYsYx1NcScV+uA== X-Received: by 2002:a17:902:cf0e:b0:19e:2495:20e0 with SMTP id i14-20020a170902cf0e00b0019e249520e0mr2645011plg.21.1678477977728; Fri, 10 Mar 2023 11:52:57 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: cota@braap.org, alex.bennee@linaro.org Subject: [PATCH v2 5/7] *: Add missing includes of qemu/plugin.h Date: Fri, 10 Mar 2023 11:52:50 -0800 Message-Id: <20230310195252.210956-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310195252.210956-1-richard.henderson@linaro.org> References: <20230310195252.210956-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1678478094547100003 Content-Type: text/plain; charset="utf-8" This had been pulled in from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson Reviewed-by: Emilio Cota Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/cpu-exec-common.c | 1 + cpu.c | 1 + linux-user/exit.c | 1 + linux-user/syscall.c | 1 + 4 files changed, 4 insertions(+) diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c index 176ea57281..e7962c9348 100644 --- a/accel/tcg/cpu-exec-common.c +++ b/accel/tcg/cpu-exec-common.c @@ -21,6 +21,7 @@ #include "sysemu/cpus.h" #include "sysemu/tcg.h" #include "exec/exec-all.h" +#include "qemu/plugin.h" =20 bool tcg_allowed; =20 diff --git a/cpu.c b/cpu.c index 567b23af46..849bac062c 100644 --- a/cpu.c +++ b/cpu.c @@ -42,6 +42,7 @@ #include "hw/core/accel-cpu.h" #include "trace/trace-root.h" #include "qemu/accel.h" +#include "qemu/plugin.h" =20 uintptr_t qemu_host_page_size; intptr_t qemu_host_page_mask; diff --git a/linux-user/exit.c b/linux-user/exit.c index fd49d76f45..3017d28a3c 100644 --- a/linux-user/exit.c +++ b/linux-user/exit.c @@ -21,6 +21,7 @@ #include "gdbstub/syscalls.h" #include "qemu.h" #include "user-internals.h" +#include "qemu/plugin.h" #ifdef CONFIG_GPROF #include #endif diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a6c426d73c..38f3f5f784 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -22,6 +22,7 @@ #include "qemu/path.h" #include "qemu/memfd.h" #include "qemu/queue.h" +#include "qemu/plugin.h" #include #include #include --=20 2.34.1 From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1678478059; cv=none; d=zohomail.com; s=zohoarc; b=KxQct1NTHzBjI/klaScrn2GegmaCMTZP3NzhxEquot81+A0DvuF5NmrUTeA5nhsNul7G56/3nurnzXOUU04b6HcslrqkL7r97LYksn5hlYl4/qAqPJjys5uXsRJwrpOEZHr4ey+5dyOzizANN6mDiqFgjN2mwQ8O7VRk+W00Vo4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678478059; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T5bbx8sg/Anm+07Z29jSPoGQLySawFafuCtWNzz/H14=; b=d85yOQV6pNCq6exnkkAXmz43Aab4h4qw/gGoWzlEDA2GybzH0jzYkf4fioxcT/vSuYTAAhopgDqmavRfPQbII46pwnOLO6UMQpi2R6t3D4fmXw6cQYz8nrAr86bbF3fpXB+V3FaNfcQsza/OqgQbTyiWHbZ7vNxdjLoCnsUCBY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678478059904980.5110982991813; Fri, 10 Mar 2023 11:54:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1painY-0001HM-59; Fri, 10 Mar 2023 14:53:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1painV-0001GJ-Rc for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:01 -0500 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1painU-0004fZ-5n for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:01 -0500 Received: by mail-pj1-x102e.google.com with SMTP id p3-20020a17090ad30300b0023a1cd5065fso6222761pju.0 for ; Fri, 10 Mar 2023 11:52:59 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:cc1c:ced1:1ec5:bd62]) by smtp.gmail.com with ESMTPSA id l1-20020a170903244100b001991d6c6c64sm351465pls.185.2023.03.10.11.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 11:52:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678477979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T5bbx8sg/Anm+07Z29jSPoGQLySawFafuCtWNzz/H14=; b=cWJQDoMyjUWqWTPZReKRO0DZCX2VzSlsrzFVF3CHUF3xks7vKk0ORhv+BUtxaKD5jm ttA0HA3hGTk6IoB7WqTFggagE+ApdE9I1MsL4yXHWfzFi5Obje8KIhZX2injtICv4Wr7 e4diO2jQmLcPR42jNcG16qm1DlWx/JKiWFYQ4NrkygBTgbPkZ/yXsZCw2WUs87xccitJ Sc4S8LkqZP4wgrbWvgjLj3YfBPG9K8mlyaajqdVGdKOfZAfnR3rnG00RHEUTX3agxkyl TIZxD1Il/pzh5rH0BSLGgdVAi0NZqXEie4UWWp85gXFaqBOZF4MtLRzduA1iEmOuEA9v UVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678477979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T5bbx8sg/Anm+07Z29jSPoGQLySawFafuCtWNzz/H14=; b=kaLJg1FVAWtYj4UgGnwPMQbYUUYyig1fxrbUIS9a+9OzHQTZ+HIqYojV0teCXctqnc avJcWSzDkXXomzMRswQVqh2wyX3poUGTKFlw62nzN1VGoMPcHjxvieSTc2I7GTFPY8jV BcukujywnkB/1WWE9Dj8vAhH1vOSekJIEpT2MLOyB+X8rj1ykruwztmRohHDYtzx40TI i/Iu63ehT1PRDbfR3cAdo0pNwJwOAVgcwVZaahmPI8/MoxcFdNybVyGPfUvUMZfkl883 m2NTgp6CfGmutgsgGpeaMFAu1BdvnJvQLcqu4lj3J/h/6CCMBlwFcoVGyf0+++LHi/K9 y8nQ== X-Gm-Message-State: AO0yUKXwInFvplppprYPllnwhn2ZSmtQGzEkw67YZ+3KBDjgglwqox+A LvpVMt0hunHCj1e7NkTWJ6WfxS7A18HTzjrGBgQ= X-Google-Smtp-Source: AK7set9lJ9YnSW3BXTt4U+0RD/uMAPac54mGIXHkdr4fTGHPaXcpQAP+CMboPCzGT4FMtP6HJSwp8A== X-Received: by 2002:a17:902:da90:b0:19c:e405:4446 with SMTP id j16-20020a170902da9000b0019ce4054446mr31551859plx.30.1678477978841; Fri, 10 Mar 2023 11:52:58 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: cota@braap.org, alex.bennee@linaro.org Subject: [PATCH v2 6/7] include/qemu: Split out plugin-event.h Date: Fri, 10 Mar 2023 11:52:51 -0800 Message-Id: <20230310195252.210956-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310195252.210956-1-richard.henderson@linaro.org> References: <20230310195252.210956-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1678478060378100016 Content-Type: text/plain; charset="utf-8" The usage in hw/core/cpu.h only requires QEMU_PLUGIN_EV_MAX. Signed-off-by: Richard Henderson Reviewed-by: Emilio Cota Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 2 +- include/qemu/plugin-event.h | 26 ++++++++++++++++++++++++++ include/qemu/plugin.h | 17 +---------------- 3 files changed, 28 insertions(+), 17 deletions(-) create mode 100644 include/qemu/plugin-event.h diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 75689bff02..821e937020 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -30,7 +30,7 @@ #include "qemu/rcu_queue.h" #include "qemu/queue.h" #include "qemu/thread.h" -#include "qemu/plugin.h" +#include "qemu/plugin-event.h" #include "qom/object.h" =20 typedef int (*WriteCoreDumpFunction)(const void *buf, size_t size, diff --git a/include/qemu/plugin-event.h b/include/qemu/plugin-event.h new file mode 100644 index 0000000000..7056d8427b --- /dev/null +++ b/include/qemu/plugin-event.h @@ -0,0 +1,26 @@ +/* + * Copyright (C) 2017, Emilio G. Cota + * + * License: GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ +#ifndef QEMU_PLUGIN_EVENT_H +#define QEMU_PLUGIN_EVENT_H + +/* + * Events that plugins can subscribe to. + */ +enum qemu_plugin_event { + QEMU_PLUGIN_EV_VCPU_INIT, + QEMU_PLUGIN_EV_VCPU_EXIT, + QEMU_PLUGIN_EV_VCPU_TB_TRANS, + QEMU_PLUGIN_EV_VCPU_IDLE, + QEMU_PLUGIN_EV_VCPU_RESUME, + QEMU_PLUGIN_EV_VCPU_SYSCALL, + QEMU_PLUGIN_EV_VCPU_SYSCALL_RET, + QEMU_PLUGIN_EV_FLUSH, + QEMU_PLUGIN_EV_ATEXIT, + QEMU_PLUGIN_EV_MAX, /* total number of plugin events we support */ +}; + +#endif /* QEMU_PLUGIN_EVENT_H */ diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index e0ebedef84..6bf4bce188 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -12,24 +12,9 @@ #include "qemu/error-report.h" #include "qemu/queue.h" #include "qemu/option.h" +#include "qemu/plugin-event.h" #include "exec/memopidx.h" =20 -/* - * Events that plugins can subscribe to. - */ -enum qemu_plugin_event { - QEMU_PLUGIN_EV_VCPU_INIT, - QEMU_PLUGIN_EV_VCPU_EXIT, - QEMU_PLUGIN_EV_VCPU_TB_TRANS, - QEMU_PLUGIN_EV_VCPU_IDLE, - QEMU_PLUGIN_EV_VCPU_RESUME, - QEMU_PLUGIN_EV_VCPU_SYSCALL, - QEMU_PLUGIN_EV_VCPU_SYSCALL_RET, - QEMU_PLUGIN_EV_FLUSH, - QEMU_PLUGIN_EV_ATEXIT, - QEMU_PLUGIN_EV_MAX, /* total number of plugin events we support */ -}; - /* * Option parsing/processing. * Note that we can load an arbitrary number of plugins. --=20 2.34.1 From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1678478056; cv=none; d=zohomail.com; s=zohoarc; b=lPqtaFjcgt/jEBzd6CTaTeVO3LxPIcPT9h0zenzhmsnT4mWpMjzupRCYF+ojjD65q43cJw4ULPmKXV+5Wz/u5gm1CkEXoPJft5GVq19q3rLiwaD2rVhQoYNAIk0x3PB/xwDna2na2k/PWxW0NKLoJ4Zi5A5V4xJQQBV2opYbi+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678478056; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZI3yEJ2Lc21he8le+fWeyTzXmLbDRb40vBMQaTo2uKo=; b=CGJX3GMY/8ffvKNztyCKYvgjDa7Gpc6eqVvqdX3y29Stxh1GXpKaRVzhuQaUFUA9Rq6ipE5v+i6FiAQ6MOI4YnZnFilOVjWqs/zvtM5LNkdtduw3pnJh4UzMKHW7SCCt52iQBT8tFxaN6ahLAjMuTDWZhTZRP2DAC1dD7h9CgBI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678478056725226.2859002643936; Fri, 10 Mar 2023 11:54:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1painZ-0001Hj-Oj; Fri, 10 Mar 2023 14:53:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1painW-0001Go-QR for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:02 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1painV-0004fr-9S for qemu-devel@nongnu.org; Fri, 10 Mar 2023 14:53:02 -0500 Received: by mail-pl1-x633.google.com with SMTP id a2so6799044plm.4 for ; Fri, 10 Mar 2023 11:53:00 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:cc1c:ced1:1ec5:bd62]) by smtp.gmail.com with ESMTPSA id l1-20020a170903244100b001991d6c6c64sm351465pls.185.2023.03.10.11.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 11:52:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678477980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZI3yEJ2Lc21he8le+fWeyTzXmLbDRb40vBMQaTo2uKo=; b=O07Hx36OIOASh009kICTNTm+IvGKtb/wdB8UCZ+Hu/5G55YMmswXKI9IiWS/GyX2LM vJp5yY56HaNDQ+v4Z0EHoYbkh6519Eq5ZJX4KxH7lpSs0f2UjgsgEBfE4pmZzdafc0VA otw+x3tspp3LTNUMhxOyHl2wb9aNXM23f7BBssEpljBQY/spjUiPpFgtfKxkvRNAmFEm yvLlzX9pQrukULz7p9w9ZyTXK7VrYTT6dE7UD8QpMM/FZx77vYP4GsnhXRh/0q9l2iOO UByQ4YWVyr5Lax4r4rX7jvacAon7D1H5ggrUMDtvws4l/JSeI0dQYOjg0ET0r+ucvqNE 523w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678477980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZI3yEJ2Lc21he8le+fWeyTzXmLbDRb40vBMQaTo2uKo=; b=lafWilVW3WeDbaxxwOhaOjDhs75Dh4/BcfF42S6cbB20OfGrZHfXSUu90Hn1hNhoQd Hr5cxAutrMb26MuHA14Wc6lsQ86SaYwNJffE95YdLg72NJyRuC1oziUYmB5EaYCR6YJK M8f1x883nDqxE1+p3RPbghZyWLo5BSYtHrU8NZN9BeIfNB3e4fZbQzqQbxZpE1gmo+7W hlmxu+SXgEOD+JNjI0a5235v5rvcI61xZOVIUKVBl5tlirb5ElczlJztkqEjZcB0mpXZ vSK+b04SfObBDVEc18HHNq1vVVadvUxvijz3CHa7ixMZeiDlsBUMKh2eTU1Xco1ZuDgX 5yfQ== X-Gm-Message-State: AO0yUKXHjrNPjZIOx80FbD2K3e9xcnDSZ90RbOy8tXBZeOmgP75auS+x FoCw3IrwUugBbaD8rvGHvy9ufb8X4aOltPOtZhk= X-Google-Smtp-Source: AK7set9kxIR3SZb7TZDDlqe1KIHierwSjXQaMIVB+su0lnS1GCAkZss2Euwmn3ICVlIP3Kbnusqnug== X-Received: by 2002:a17:902:ce90:b0:19a:9434:af30 with SMTP id f16-20020a170902ce9000b0019a9434af30mr30396630plg.18.1678477979763; Fri, 10 Mar 2023 11:52:59 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: cota@braap.org, alex.bennee@linaro.org Subject: [PATCH v2 7/7] include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers Date: Fri, 10 Mar 2023 11:52:52 -0800 Message-Id: <20230310195252.210956-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310195252.210956-1-richard.henderson@linaro.org> References: <20230310195252.210956-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1678478058398100007 Content-Type: text/plain; charset="utf-8" Now that we've broken the include loop with cpu.h, we can bring this inline. Signed-off-by: Richard Henderson Reviewed-by: Emilio Cota Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/plugin.h | 6 +++++- plugins/core.c | 11 ----------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index 6bf4bce188..bc0781cab8 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -14,6 +14,7 @@ #include "qemu/option.h" #include "qemu/plugin-event.h" #include "exec/memopidx.h" +#include "hw/core/cpu.h" =20 /* * Option parsing/processing. @@ -204,7 +205,10 @@ void qemu_plugin_atexit_cb(void); =20 void qemu_plugin_add_dyn_cb_arr(GArray *arr); =20 -void qemu_plugin_disable_mem_helpers(CPUState *cpu); +static inline void qemu_plugin_disable_mem_helpers(CPUState *cpu) +{ + cpu->plugin_mem_cbs =3D NULL; +} =20 /** * qemu_plugin_user_exit(): clean-up callbacks before calling exit callbac= ks diff --git a/plugins/core.c b/plugins/core.c index 04632886b9..9912f2cfdb 100644 --- a/plugins/core.c +++ b/plugins/core.c @@ -553,17 +553,6 @@ void qemu_plugin_user_postfork(bool is_child) } } =20 - -/* - * Call this function after longjmp'ing to the main loop. It's possible th= at the - * last instruction of a TB might have used helpers, and therefore the - * "disable" instruction will never execute because it ended up as dead co= de. - */ -void qemu_plugin_disable_mem_helpers(CPUState *cpu) -{ - cpu->plugin_mem_cbs =3D NULL; -} - static bool plugin_dyn_cb_arr_cmp(const void *ap, const void *bp) { return ap =3D=3D bp; --=20 2.34.1