1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H

Philippe Mathieu-Daudé posted 1 patch 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180614233935.26585-1-f4bug@amsat.org
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
hw/isa/smc37c669-superio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago 
On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
in the 3C0H-3CFH range, thus I/O base used by the parallel
device clashes, and since a4cb773928e the VGA is not
working:

(qemu) info mtree
address-space: memory
  0000000000000000-ffffffffffffffff (prio 0, i/o): system
    00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
      ...
      00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
      00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
      00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
                                    ^^^                ^^^^^^^^
      00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
                   ^^^
      00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
      00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
      ...

As there is no particular reason to use this base address
(introduced in 7bea0dd434e), change to 378H which is the
default on PC machines.

Reported-by: Emilio G. Cota <cota@braap.org>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html

 hw/isa/smc37c669-superio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c
index aa233c6967..64466a9373 100644
--- a/hw/isa/smc37c669-superio.c
+++ b/hw/isa/smc37c669-superio.c
@@ -37,7 +37,7 @@ static bool is_parallel_enabled(ISASuperIODevice *sio, uint8_t index)
 
 static uint16_t get_parallel_iobase(ISASuperIODevice *sio, uint8_t index)
 {
-    return 0x3bc;
+    return 0x378;
 }
 
 static unsigned int get_parallel_irq(ISASuperIODevice *sio, uint8_t index)
-- 
2.17.1
Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
Posted by Richard Henderson 5 years, 10 months ago 
On 06/14/2018 01:39 PM, Philippe Mathieu-Daudé wrote:
> On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
> in the 3C0H-3CFH range, thus I/O base used by the parallel
> device clashes, and since a4cb773928e the VGA is not
> working:
> 
> (qemu) info mtree
> address-space: memory
>   0000000000000000-ffffffffffffffff (prio 0, i/o): system
>     00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
>       ...
>       00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
>       00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
>       00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
>                                     ^^^                ^^^^^^^^
>       00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
>                    ^^^
>       00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
>       00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
>       ...
> 
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
> 
> Reported-by: Emilio G. Cota <cota@braap.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Richard Henderson <richard.henderson@linaro.org>

r~
Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
Posted by Mark Cave-Ayland 5 years, 10 months ago 
On 15/06/18 00:39, Philippe Mathieu-Daudé wrote:

> On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
> in the 3C0H-3CFH range, thus I/O base used by the parallel
> device clashes, and since a4cb773928e the VGA is not
> working:
> 
> (qemu) info mtree
> address-space: memory
>    0000000000000000-ffffffffffffffff (prio 0, i/o): system
>      00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
>        ...
>        00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
>        00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
>        00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
>                                      ^^^                ^^^^^^^^
>        00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
>                     ^^^
>        00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
>        00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
>        ...
> 
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
> 
> Reported-by: Emilio G. Cota <cota@braap.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html
> 
>   hw/isa/smc37c669-superio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c
> index aa233c6967..64466a9373 100644
> --- a/hw/isa/smc37c669-superio.c
> +++ b/hw/isa/smc37c669-superio.c
> @@ -37,7 +37,7 @@ static bool is_parallel_enabled(ISASuperIODevice *sio, uint8_t index)
>   
>   static uint16_t get_parallel_iobase(ISASuperIODevice *sio, uint8_t index)
>   {
> -    return 0x3bc;
> +    return 0x378;
>   }
>   
>   static unsigned int get_parallel_irq(ISASuperIODevice *sio, uint8_t index)

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.
Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
Posted by Emilio G. Cota 5 years, 10 months ago 
On Thu, Jun 14, 2018 at 20:39:35 -0300, Philippe Mathieu-Daudé wrote:
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.

Tested-by: Emilio G. Cota <cota@braap.org>

Thanks,

		Emilio
Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
Posted by Richard Henderson 5 years, 10 months ago 
On 06/14/2018 01:39 PM, Philippe Mathieu-Daudé wrote:
> On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
> in the 3C0H-3CFH range, thus I/O base used by the parallel
> device clashes, and since a4cb773928e the VGA is not
> working:
> 
> (qemu) info mtree
> address-space: memory
>   0000000000000000-ffffffffffffffff (prio 0, i/o): system
>     00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
>       ...
>       00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
>       00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
>       00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
>                                     ^^^                ^^^^^^^^
>       00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
>                    ^^^
>       00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
>       00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
>       ...
> 
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
> 
> Reported-by: Emilio G. Cota <cota@braap.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html
> 
>  hw/isa/smc37c669-superio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Queued to tgt-axp.


r~

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.