From nobody Sat May 4 07:11:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529019702321268.86371375272154; Thu, 14 Jun 2018 16:41:42 -0700 (PDT) Received: from localhost ([::1]:43505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTbrz-0006vD-Tz for importer@patchew.org; Thu, 14 Jun 2018 19:41:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTbqH-0005wt-5M for qemu-devel@nongnu.org; Thu, 14 Jun 2018 19:39:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTbqC-0003zd-Sv for qemu-devel@nongnu.org; Thu, 14 Jun 2018 19:39:49 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:42015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTbqC-0003zP-N4 for qemu-devel@nongnu.org; Thu, 14 Jun 2018 19:39:44 -0400 Received: by mail-qk0-x244.google.com with SMTP id j80-v6so4691831qke.9 for ; Thu, 14 Jun 2018 16:39:44 -0700 (PDT) Received: from x1.local ([190.48.98.178]) by smtp.gmail.com with ESMTPSA id n59-v6sm4825617qte.97.2018.06.14.16.39.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jun 2018 16:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9jWVx1bvOXJE8gwDkhaAcFYwfyWVRaPyaJL3QSmfuT8=; b=uvlboQct+NWd5IQwZ6tFwN6UWImogV1oFtz+v+toIYV56fgqmwrrFl0YRyEFy2EUHf j2Lfi7pA/xHfT+A3pkTG2i9v7fAxRgQOTM9eEECBo1VNRyOT/N0sjoCwuaHaK3mY51m2 qMHZvPmTW55LbV288XwucsqiociL36At9UdtGmKvAJ8EJKG8Lx600K5njcBiyufeHq8f I1AiiHnM/iDG8Tx+eLZVKcWQqdHDKcN2U6EIs6/GsT7/iKz4F+iXFwAQ9pn5xXxAWSOR n6+YdWL3GrnGbETZyM2/ilGvzkLa7sRKUSMZj5I/3s9fPZwobKwGxZyiAQFUrcN+/w9b ZJTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=9jWVx1bvOXJE8gwDkhaAcFYwfyWVRaPyaJL3QSmfuT8=; b=BSeR/cEm6+gW9HwubFt87zf7SMDKyCsMvjaQsYlRVKCuu5cdYxZ3YV/WpQrxRQoJ+4 /KbKyaUHFpYWolnIighLbOTQ1fKkIgf6IoP7uUcUZOS8Ivh1k4/YUosiKtxkEK79NaAQ YDy/WhHdVgnL1CfuP/+F6BKx4tdItaFeJYyscBXxPUA1MQYw9yucz/DhXVjKN+VaNEuw C4NUQrPJmRrEyqJ4tGYSiqQqS+uzNrYxYTDj1laZGsOLfYEZFYhqcbcHqaz7jSiYaEov Vy9yeDysghvYB94ALHKW9E9sIiXChDP5Hv9Eu4JpSOhMJwVcqHKMbb64YluGZ/EHIBQc pSOA== X-Gm-Message-State: APt69E2B7v6j3D8YpU7ryOBEy1RZQfThLJbQAb3kxvfEVVkuK4z1/uwE 5WgRqoq7oMSrtIRZh+Fs0FA= X-Google-Smtp-Source: ADUXVKKm13GygeaE1doI0ZiCfY6UAclHViOohv/7R5m14LowrRWrmZfBJU3H7ngRafD8Gpm3kdD8WA== X-Received: by 2002:a37:60c1:: with SMTP id u184-v6mr3809883qkb.143.1529019584172; Thu, 14 Jun 2018 16:39:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Emilio G . Cota" , Richard Henderson , Paolo Bonzini , Mark Cave-Ayland , =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Thu, 14 Jun 2018 20:39:35 -0300 Message-Id: <20180614233935.26585-1-f4bug@amsat.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 On the Alpha DP264 machine, the Cirrus VGA is I/O mapped in the 3C0H-3CFH range, thus I/O base used by the parallel device clashes, and since a4cb773928e the VGA is not working: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io ... 00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga 00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga 00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel ^^^ ^^^^^^^^ 00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga ^^^ 00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga 00000801fc0003da-00000801fc0003da (prio 0, i/o): vga ... As there is no particular reason to use this base address (introduced in 7bea0dd434e), change to 378H which is the default on PC machines. Reported-by: Emilio G. Cota Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Tested-by: Emilio G. Cota Tested-by: Richard Henderson --- RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html hw/isa/smc37c669-superio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c index aa233c6967..64466a9373 100644 --- a/hw/isa/smc37c669-superio.c +++ b/hw/isa/smc37c669-superio.c @@ -37,7 +37,7 @@ static bool is_parallel_enabled(ISASuperIODevice *sio, ui= nt8_t index) =20 static uint16_t get_parallel_iobase(ISASuperIODevice *sio, uint8_t index) { - return 0x3bc; + return 0x378; } =20 static unsigned int get_parallel_irq(ISASuperIODevice *sio, uint8_t index) --=20 2.17.1