[Qemu-devel] [RFC 0/3] nRF51 SoC: Add UART support

Julia Suvorova via Qemu-devel posted 3 patches 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180529220338.10879-1-jusual@mail.ru
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
hw/arm/nrf51_soc.c           |  19 ++-
hw/char/Makefile.objs        |   1 +
hw/char/nrf51_uart.c         | 232 +++++++++++++++++++++++++++++++++++
include/hw/arm/nrf51_soc.h   |   2 +
include/hw/char/nrf51_uart.h |  54 ++++++++
tests/boot-serial-test.c     |  11 ++
6 files changed, 314 insertions(+), 5 deletions(-)
create mode 100644 hw/char/nrf51_uart.c
create mode 100644 include/hw/char/nrf51_uart.h
[Qemu-devel] [RFC 0/3] nRF51 SoC: Add UART support
Posted by Julia Suvorova via Qemu-devel 5 years, 10 months ago
This series adds basic support for the nRF51 SoC UART, that used in
BBC Micro:bit board, and QTest for it.

Based-on: <20180503090532.3113-1-joel@jms.id.au>

Julia Suvorova (3):
  hw/arm/nrf51_soc: Fix compilation and memory regions
  hw/char/nrf51_uart: Implement nRF51 SoC UART
  tests/boot-serial-test: Add support for the microbit board

 hw/arm/nrf51_soc.c           |  19 ++-
 hw/char/Makefile.objs        |   1 +
 hw/char/nrf51_uart.c         | 232 +++++++++++++++++++++++++++++++++++
 include/hw/arm/nrf51_soc.h   |   2 +
 include/hw/char/nrf51_uart.h |  54 ++++++++
 tests/boot-serial-test.c     |  11 ++
 6 files changed, 314 insertions(+), 5 deletions(-)
 create mode 100644 hw/char/nrf51_uart.c
 create mode 100644 include/hw/char/nrf51_uart.h

-- 
2.17.0


Re: [Qemu-devel] [RFC 0/3] nRF51 SoC: Add UART support
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago
Hi Julia,

On 05/29/2018 07:03 PM, Julia Suvorova via Qemu-devel wrote:
> This series adds basic support for the nRF51 SoC UART, that used in
> BBC Micro:bit board, and QTest for it.
> 
> Based-on: <20180503090532.3113-1-joel@jms.id.au>
> 
> Julia Suvorova (3):
>   hw/arm/nrf51_soc: Fix compilation and memory regions

Since Joel's series isn't merged, you can simply take his patches, fix
them, and include them in your following series.  Usually you keep his
Signed-off-by line, add a comment with your changes, then add your
S-o-b, such:

    [PATCH ...] hw/arm: Add Nordic Semiconductor nRF51 SoC

    The nRF51 is a Cortex-M0 microcontroller with an on-board radio module,
    plus other common ARM SoC peripherals.

    This defines a basic model of the CPU and memory, with no peripherals
    implemented at this stage.

    Signed-off-by: Joel Stanley <joel@jms.id.au>
    [Julia: Fixed BBC Micro:bit board ROM/RAM size, added FICR defines]
    Signed-off-by: Julia Suvorova <jusual@mail.ru>

>   hw/char/nrf51_uart: Implement nRF51 SoC UART
>   tests/boot-serial-test: Add support for the microbit board
> 
>  hw/arm/nrf51_soc.c           |  19 ++-
>  hw/char/Makefile.objs        |   1 +
>  hw/char/nrf51_uart.c         | 232 +++++++++++++++++++++++++++++++++++
>  include/hw/arm/nrf51_soc.h   |   2 +
>  include/hw/char/nrf51_uart.h |  54 ++++++++
>  tests/boot-serial-test.c     |  11 ++
>  6 files changed, 314 insertions(+), 5 deletions(-)
>  create mode 100644 hw/char/nrf51_uart.c
>  create mode 100644 include/hw/char/nrf51_uart.h
> 

Re: [Qemu-devel] [RFC 0/3] nRF51 SoC: Add UART support
Posted by Stefan Hajnoczi 5 years, 10 months ago
On Tue, May 29, 2018 at 11:57:47PM -0300, Philippe Mathieu-Daudé wrote:
> Hi Julia,
> 
> On 05/29/2018 07:03 PM, Julia Suvorova via Qemu-devel wrote:
> > This series adds basic support for the nRF51 SoC UART, that used in
> > BBC Micro:bit board, and QTest for it.
> > 
> > Based-on: <20180503090532.3113-1-joel@jms.id.au>
> > 
> > Julia Suvorova (3):
> >   hw/arm/nrf51_soc: Fix compilation and memory regions
> 
> Since Joel's series isn't merged, you can simply take his patches, fix
> them, and include them in your following series.  Usually you keep his
> Signed-off-by line, add a comment with your changes, then add your
> S-o-b, such:
> 
>     [PATCH ...] hw/arm: Add Nordic Semiconductor nRF51 SoC
> 
>     The nRF51 is a Cortex-M0 microcontroller with an on-board radio module,
>     plus other common ARM SoC peripherals.
> 
>     This defines a basic model of the CPU and memory, with no peripherals
>     implemented at this stage.
> 
>     Signed-off-by: Joel Stanley <joel@jms.id.au>
>     [Julia: Fixed BBC Micro:bit board ROM/RAM size, added FICR defines]
>     Signed-off-by: Julia Suvorova <jusual@mail.ru>

I think Joel will send another revision of his series.  It would make
sense for him to squash in this patch.

Stefan