Changeset
numa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Git apply log
Switched to a new branch '1526399447-64923-1-git-send-email-imammedo@redhat.com'
Applying: numa: clarify error message when node index is out of range in -numa dist, ...
To https://github.com/patchew-project/qemu
 * [new tag]         patchew/1526399447-64923-1-git-send-email-imammedo@redhat.com -> patchew/1526399447-64923-1-git-send-email-imammedo@redhat.com
Test passed: checkpatch

loading

Test passed: docker-mingw@fedora

loading

Test passed: docker-quick@centos7

loading

Test passed: s390x

loading

[Qemu-devel] [PATCH v3] numa: clarify error message when node index is out of range in -numa dist, ...
Posted by Igor Mammedov, 1 week ago
When using following CLI:
  -numa dist,src=128,dst=1,val=20
user gets a rather confusing error message:
   "Invalid node 128, max possible could be 128"

Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
---
v3:
 - s/,/./ in error message
 - add '.' at the end of sentence
---
 numa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/numa.c b/numa.c
index 188bfdf..d98c106 100644
--- a/numa.c
+++ b/numa.c
@@ -142,8 +142,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp)
 
     if (src >= MAX_NODES || dst >= MAX_NODES) {
         error_setg(errp,
-                   "Invalid node %d, max possible could be %d",
-                   MAX(src, dst), MAX_NODES);
+                   "Invalid node %d. The valid node range is [0 - %d].",
+                   MAX(src, dst), MAX_NODES - 1);
         return;
     }
 
-- 
2.7.4