[v4] numa: clarify error message when node index is out of range in -numa dist, ...

[Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...

Igor Mammedov posted 1 patch 5 years, 11 months ago

Diff against v1 v2 v3
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1526483174-169008-1-git-send-email-imammedo@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x passed

numa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...

Posted by Igor Mammedov 5 years, 11 months ago

When using following CLI:
  -numa dist,src=128,dst=1,val=20
user gets a rather confusing error message:
   "Invalid node 128, max possible could be 128"

Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
v4:
 - e error message suggested by Markus
v3:
 - s/,/./ in error message
 - add '.' at the end of sentence
---
 numa.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/numa.c b/numa.c
index 188bfdf..33572bf 100644
--- a/numa.c
+++ b/numa.c
@@ -141,9 +141,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp)
     uint8_t val = dist->val;
 
     if (src >= MAX_NODES || dst >= MAX_NODES) {
-        error_setg(errp,
-                   "Invalid node %d, max possible could be %d",
-                   MAX(src, dst), MAX_NODES);
+        error_setg(errp, "Parameter '%s' expects an integer between 0 and %d",
+                   src >= MAX_NODES ? "src" : "dst", MAX_NODES - 1);
         return;
     }
 
-- 
2.7.4

Re: [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...

Posted by Eric Blake 5 years, 11 months ago

On 05/16/2018 10:06 AM, Igor Mammedov wrote:
> When using following CLI:
>    -numa dist,src=128,dst=1,val=20
> user gets a rather confusing error message:
>     "Invalid node 128, max possible could be 128"
> 
> Where 128 is number of nodes that QEMU supports (MAX_NODES),
> while src/dst is an index up to that limit, so it should be
> MAX_NODES - 1 in error message.
> Make error message to explicitly state valid range for node
> index to be more clear.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...

Posted by Eduardo Habkost 5 years, 11 months ago

On Wed, May 16, 2018 at 05:06:14PM +0200, Igor Mammedov wrote:
> When using following CLI:
>   -numa dist,src=128,dst=1,val=20
> user gets a rather confusing error message:
>    "Invalid node 128, max possible could be 128"
> 
> Where 128 is number of nodes that QEMU supports (MAX_NODES),
> while src/dst is an index up to that limit, so it should be
> MAX_NODES - 1 in error message.
> Make error message to explicitly state valid range for node
> index to be more clear.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Queued, thanks.

-- 
Eduardo