[v4] xenfb: Enablement for Windows PV HID frontend

[Qemu-devel] [PATCH 0/3 v4] xenfb: Enablement for Windows PV HID frontend

Posted by Owen Smith 6 years, 7 months ago

Improve the input device model in xenfb, by updating the
Qemu input handlers and adding a feature to allow for
raw (unscaled) absolute coordinates to be represented.

By using a reverse mapping call, the Linux input.h #defines
are not pulled into xenfb, and so should remove the compiler
warnings reported.

Owen Smith (3):
  ui/input: add qemu_input_qcode_to_linux
  xenfb: Use Input Handlers directly
  xenfb: Add [feature|request]-raw-pointer

 hw/display/xenfb.c | 300 +++++++++++++++++++++++++----------------------------
 include/ui/input.h |   1 +
 ui/input-keymap.c  |  16 +++
 3 files changed, 161 insertions(+), 156 deletions(-)

-- 
2.1.4

Re: [Qemu-devel] [PATCH 0/3 v4] xenfb: Enablement for Windows PV HID frontend

Posted by Gerd Hoffmann 6 years, 6 months ago

On Tue, 2017-09-26 at 14:43 +0000, Owen Smith wrote:
> Improve the input device model in xenfb, by updating the
> Qemu input handlers and adding a feature to allow for
> raw (unscaled) absolute coordinates to be represented.
> 
> By using a reverse mapping call, the Linux input.h #defines
> are not pulled into xenfb, and so should remove the compiler
> warnings reported.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

What is the plan with this?  Merge through xen queue?  I can merge it
via ui queue too, but in that case I'd like to get an review from the
xen guys.

Note: conflicts with keycodemapdb patch series, might need a rebase
depending on merge order.

cheers,
  Gerd

Re: [Qemu-devel] [PATCH 0/3 v4] xenfb: Enablement for Windows PV HID frontend

Posted by Daniel P. Berrange 6 years, 6 months ago

On Fri, Sep 29, 2017 at 12:26:52PM +0200, Gerd Hoffmann wrote:
> On Tue, 2017-09-26 at 14:43 +0000, Owen Smith wrote:
> > Improve the input device model in xenfb, by updating the
> > Qemu input handlers and adding a feature to allow for
> > raw (unscaled) absolute coordinates to be represented.
> > 
> > By using a reverse mapping call, the Linux input.h #defines
> > are not pulled into xenfb, and so should remove the compiler
> > warnings reported.
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> What is the plan with this?  Merge through xen queue?  I can merge it
> via ui queue too, but in that case I'd like to get an review from the
> xen guys.
> 
> Note: conflicts with keycodemapdb patch series, might need a rebase
> depending on merge order.

I don't mind rebasing against this if it merges first.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|