[Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

Owen Smith posted 4 patches 6 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171103115631.15175-1-owen.smith@citrix.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
Makefile           |   1 +
hw/display/xenfb.c | 294 ++++++++++++++++++++++++++++-------------------------
include/ui/input.h |   3 +
ui/input-keymap.c  |   1 +
4 files changed, 161 insertions(+), 138 deletions(-)
[Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend
Posted by Owen Smith 6 years, 5 months ago
Improve the input device model in xenfb, by updating the
Qemu input handlers and adding a feature to allow for
raw (unscaled) absolute coordinates to be represented.

Changes:
  * use keycodedb to generate qcode to linux input mapping
  * move rescaling to the mouse_event handler
  * add activate for raw_pointer devices

Owen Smith (3):
  ui: generate qcode to linux mappings
  xenfb: Use Input Handlers directly
  xenfb: Add [feature|request]-raw-pointer
  xenfb: activate input handlers for raw pointer devices

 Makefile           |   1 +
 hw/display/xenfb.c | 294 ++++++++++++++++++++++++++++-------------------------
 include/ui/input.h |   3 +
 ui/input-keymap.c  |   1 +
 4 files changed, 161 insertions(+), 138 deletions(-)

-- 
2.11.0


Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend
Posted by Gerd Hoffmann 6 years, 5 months ago
On Fri, Nov 03, 2017 at 11:56:27AM +0000, Owen Smith wrote:
> Improve the input device model in xenfb, by updating the
> Qemu input handlers and adding a feature to allow for
> raw (unscaled) absolute coordinates to be represented.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Will this be merged via xen queue?

If not I can queue it up in my input queue, but I'd like to have a
review from the xen folks then.

cheers,
  Gerd


Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend
Posted by Owen Smith 6 years, 5 months ago
I'd imagine this would be merged via the Xen queue, as it primarily deals with the xen backend

Owen

> -----Original Message-----
> From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> Sent: 08 November 2017 10:21
> To: Owen Smith <owen.smith@citrix.com>
> Cc: sstabellini@kernel.org; Anthony Perard <anthony.perard@citrix.com>;
> qemu-devel@nongnu.org; xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v5 0/4] xenfb: Enablement for Windows PV HID
> frontend
> 
> On Fri, Nov 03, 2017 at 11:56:27AM +0000, Owen Smith wrote:
> > Improve the input device model in xenfb, by updating the Qemu input
> > handlers and adding a feature to allow for raw (unscaled) absolute
> > coordinates to be represented.
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Will this be merged via xen queue?
> 
> If not I can queue it up in my input queue, but I'd like to have a review from
> the xen folks then.
> 
> cheers,
>   Gerd


Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend
Posted by Anthony PERARD 6 years, 4 months ago
On Fri, Nov 03, 2017 at 11:56:27AM +0000, Owen Smith wrote:
> Improve the input device model in xenfb, by updating the
> Qemu input handlers and adding a feature to allow for
> raw (unscaled) absolute coordinates to be represented.
> 
> Changes:
>   * use keycodedb to generate qcode to linux input mapping
>   * move rescaling to the mouse_event handler
>   * add activate for raw_pointer devices
> 
> Owen Smith (3):
>   ui: generate qcode to linux mappings
>   xenfb: Use Input Handlers directly
>   xenfb: Add [feature|request]-raw-pointer
>   xenfb: activate input handlers for raw pointer devices

The patch series looks good to me:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD