Fix running integration pipeline in forks + collect daemon stack trace

[libvirt PATCH 0/2] [CI] Fix running integration pipeline in forks + collect daemon stack trace

Posted by Erik Skultety 2 years, 1 month ago

Even if users set the LIBVIRT_CI_INTEGRATION variable to 1 to enable the
integration test suite with their own private runner, the pipeline will be stuck
because we expect the runner to have the 'redhat-vm-host' tag. We need to define
the job tag dynamically instead, so that the users can set the variable for
their libvirt fork to match one of their runner's tags.

A recent crash in libvirt showed us that we also need to collect stack traces as
well, so this series also takes care of setting up systemd to be able to collect
them on failed jobs.

Both fixes are demoed with pipeline [1]. Note that for the pipeline I reverted
17fe6a090ba389cdd228c3e176788d9b2d45525f just to demonstrate the stack trace
collection on a crash.

[1] https://gitlab.com/eskultety/libvirt/-/pipelines/497404762

Erik Skultety (2):
  ci: Define the integration job tag dynamically via a variable
  ci: integration: Collect stack traces with coredumpctl

 ci/integration.yml | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

-- 
2.34.1

Re: [libvirt PATCH 0/2] [CI] Fix running integration pipeline in forks + collect daemon stack trace

Posted by Michal Prívozník 2 years, 1 month ago

On 3/22/22 07:52, Erik Skultety wrote:
> Even if users set the LIBVIRT_CI_INTEGRATION variable to 1 to enable the
> integration test suite with their own private runner, the pipeline will be stuck
> because we expect the runner to have the 'redhat-vm-host' tag. We need to define
> the job tag dynamically instead, so that the users can set the variable for
> their libvirt fork to match one of their runner's tags.
> 
> A recent crash in libvirt showed us that we also need to collect stack traces as
> well, so this series also takes care of setting up systemd to be able to collect
> them on failed jobs.
> 
> Both fixes are demoed with pipeline [1]. Note that for the pipeline I reverted
> 17fe6a090ba389cdd228c3e176788d9b2d45525f just to demonstrate the stack trace
> collection on a crash.
> 
> [1] https://gitlab.com/eskultety/libvirt/-/pipelines/497404762
> 
> Erik Skultety (2):
>   ci: Define the integration job tag dynamically via a variable
>   ci: integration: Collect stack traces with coredumpctl
> 
>  ci/integration.yml | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal