From nobody Thu May 16 03:03:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647931981; cv=none; d=zohomail.com; s=zohoarc; b=XmU3L/uCudSlUXZBgrzEZ/WFz+QVyg1CkHCT95WuUYTaKAjGTitUvSJTM2YXmubBeYiLR/ShTp9QTTDOPmM9O/0+dhDet1Oyyx+DxmW1DTkVrqdboh2JkR3Y5/X5B9KOk0hD2FNpwaVYcfA0HgB2igZtemFyp90j2cRQnR7F1NA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647931981; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=q5xpbbXBjvEGNyHbc7eAIjYG31IMe4Asgn3FxW7xkdw=; b=HOAYXx40JKRrS35LanWM6tCsvUsL1JSyz7cZFwDmP1DbMv+Mk3/UO6pVye1vtSg5e/mLWjgxqlE8aSKL/eyt7jr098O8PvWMo9KD6I1hXcstT7F9rqNm/p5VSsiTvFfkhV0xAREZc6joJMYmZSdBRTRCWoC/kVXuuiNIGozM59s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1647931981233638.6604112068803; Mon, 21 Mar 2022 23:53:01 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-Wu4W9Z4HMCS2UPG1N_G4dw-1; Tue, 22 Mar 2022 02:52:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D1DDC106656D; Tue, 22 Mar 2022 06:52:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EE8B1400E70; Tue, 22 Mar 2022 06:52:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E52211940353; Tue, 22 Mar 2022 06:52:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2A4E01947BBC for ; Tue, 22 Mar 2022 06:52:23 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0BC1AC159B3; Tue, 22 Mar 2022 06:52:23 +0000 (UTC) Received: from nautilus.redhat.com (unknown [10.40.192.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83B73C26E9A; Tue, 22 Mar 2022 06:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647931981; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=q5xpbbXBjvEGNyHbc7eAIjYG31IMe4Asgn3FxW7xkdw=; b=Khs6KMC72HXQFDCUuarc5e3MBpd/2Gm08GKW9VevU88EyR2prVzxlOoAlPNycS7CDSVnyo 8byO56Qj25ov5eEaXk3fxFmlWzkS7EY6Ab8blRxas7rSAq3Bl/l58O97jqRfmUirz9M4aU i4VMkYWovjBVbDXQpIn8cecCznGPnWE= X-MC-Unique: Wu4W9Z4HMCS2UPG1N_G4dw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 1/2] ci: Define the integration job tag dynamically via a variable Date: Tue, 22 Mar 2022 07:52:20 +0100 Message-Id: <87b33ea856393122233710adb18da25b2b2d7b4e.1647931914.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eskultet@redhat.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647931984256100003 Content-Type: text/plain; charset="utf-8" Custom runners are private to a project, so naturally forks cannot run any workloads on these. The integration test suite which requires access to our custom runner is naturally disabled on forks and can be enabled by setting LIBVIRT_CI_INTEGRATION=3D1. The problem is that the current integration jobs definitions have tags statically defined as 'redhat-vm-host'. If users are going to supply their own private runners for their forks, they can define whatever tags they want with it and so unless they add 'redhat-vm-host' to their own runner's tags, the pipeline won't run. To solve this, define the integration job tag using a variable. The repo config will use the value defined in the job for the variable while users can override the value easily on a project/pipeline level thanks to GitLab's CI variable precedence [1]. [1] https://docs.gitlab.com/ee/ci/variables/#cicd-variable-precedence Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration.yml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ci/integration.yml b/ci/integration.yml index 8551ce8776..9726f00bff 100644 --- a/ci/integration.yml +++ b/ci/integration.yml @@ -45,7 +45,6 @@ when: on_success - when: never =20 - centos-stream-8-tests: extends: .integration_tests needs: @@ -57,8 +56,10 @@ centos-stream-8-tests: variables: # needed by libvirt-gitlab-executor DISTRO: centos-stream-8 + # can be overriden in forks to set a different runner tag + LIBVIRT_CI_INTEGRATION_RUNNER_TAG: redhat-vm-host tags: - - redhat-vm-host + - $LIBVIRT_CI_INTEGRATION_RUNNER_TAG =20 centos-stream-9-tests: extends: .integration_tests @@ -71,8 +72,10 @@ centos-stream-9-tests: variables: # needed by libvirt-gitlab-executor DISTRO: centos-stream-9 + # can be overriden in forks to set a different runner tag + LIBVIRT_CI_INTEGRATION_RUNNER_TAG: redhat-vm-host tags: - - redhat-vm-host + - $LIBVIRT_CI_INTEGRATION_RUNNER_TAG =20 fedora-34-tests: extends: .integration_tests @@ -85,8 +88,10 @@ fedora-34-tests: variables: # needed by libvirt-gitlab-executor DISTRO: fedora-34 + # can be overriden in forks to set a different runner tag + LIBVIRT_CI_INTEGRATION_RUNNER_TAG: redhat-vm-host tags: - - redhat-vm-host + - $LIBVIRT_CI_INTEGRATION_RUNNER_TAG =20 fedora-35-tests: extends: .integration_tests @@ -99,5 +104,7 @@ fedora-35-tests: variables: # needed by libvirt-gitlab-executor DISTRO: fedora-35 + # can be overriden in forks to set a different runner tag + LIBVIRT_CI_INTEGRATION_RUNNER_TAG: redhat-vm-host tags: - - redhat-vm-host + - $LIBVIRT_CI_INTEGRATION_RUNNER_TAG --=20 2.34.1 From nobody Thu May 16 03:03:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647931954; cv=none; d=zohomail.com; s=zohoarc; b=AN50T7TeHYO3IfLy6dutENkzWQAl0zSno087j7gLiai51uF+mXTZWUJYX2OI36E79RoRCJH5B0KAzB4OxkvcY2LfEcDLnu+MCMgZdFhWr7D+C0ihHA3JgoxnnUBtZ4sVyn7lRV3jrQHh2SGeTpOW+G0jjPRx5Reb9Lzc2MglMgU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647931954; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=E72xzlBlVEQL1jVXvBL1AmuYertVbqnFDmplEMlIxBQ=; b=SQhw3jtiMEd/OBuJZVwxG/UHbGXi2TkMsYkvuhv+epaBPnGDmqg8j6iO6RDHH0ADsinnaBtpz2C5tZ/5rtM8ZA/QHPCHFJTyNbabET+va4WDHW843H7+oVsmywzzTOe+9q/0gEH+ESw+qSEOLGD/Xvh5Z3sBJOCPMV6NeKoWqX8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1647931954539281.70599023511056; Mon, 21 Mar 2022 23:52:34 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-393-mKyEsVs4NgqVyyBmmw7rjw-1; Tue, 22 Mar 2022 02:52:30 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D1A473800E9F; Tue, 22 Mar 2022 06:52:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D57F640E80E8; Tue, 22 Mar 2022 06:52:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3CF951940345; Tue, 22 Mar 2022 06:52:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D47861940350 for ; Tue, 22 Mar 2022 06:52:23 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C65D0C26E9B; Tue, 22 Mar 2022 06:52:23 +0000 (UTC) Received: from nautilus.redhat.com (unknown [10.40.192.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 49C5CC26E9A; Tue, 22 Mar 2022 06:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647931953; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=E72xzlBlVEQL1jVXvBL1AmuYertVbqnFDmplEMlIxBQ=; b=Dkp0ef5gXw70URgiygavb9uJeW5nlmpF5hsLlh6hEca9breX8G8xOrci7dQ4LlzlzdAd9v Yav63VPGi1Fx3vWwvOtyOI/lTE7Ibw6kXVD54OYfUXUezUm9iivBOQYwLZ7jm2SPLowmDf 8BJCeq792r3cotHgAGQNpP82+kzNXVc= X-MC-Unique: mKyEsVs4NgqVyyBmmw7rjw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 2/2] ci: integration: Collect stack traces with coredumpctl Date: Tue, 22 Mar 2022 07:52:21 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eskultet@redhat.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647931955683100001 Content-Type: text/plain; charset="utf-8" Some Red Hat-like distros have cores limited with a soft limit of 0 which means that neither a stack trace nor a core file will be available. Since we want the stack trace we need to set the core limit with systemd globally to unlimited/infinity. Signed-off-by: Erik Skultety Reviewed-by: Michal Privoznik --- ci/integration.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ci/integration.yml b/ci/integration.yml index 9726f00bff..b2932f2f39 100644 --- a/ci/integration.yml +++ b/ci/integration.yml @@ -2,6 +2,8 @@ stage: integration_tests before_script: - mkdir "$SCRATCH_DIR" + - sudo sh -c "echo DefaultLimitCORE=3Dinfinity >> /etc/systemd/system.= conf" # Explicitly allow storing cores globally + - sudo systemctl daemon-reexec # need to reexec systemd after changing= config - sudo dnf install -y libvirt-rpms/* libvirt-perl-rpms/* - sudo pip3 install --prefix=3D/usr avocado-framework - source /etc/os-release # in order to query the vendor-provided vari= ables @@ -31,6 +33,7 @@ after_script: - test "$CI_JOB_STATUS" =3D "success" && exit 0; - test -e "$SCRATCH_DIR"/avocado && sudo mv "$SCRATCH_DIR"/avocado/lat= est/test-results logs/avocado; + - sudo coredumpctl info --no-pager > logs/coredumpctl.info - sudo mv /var/log/libvirt logs/libvirt - sudo chown -R $(whoami):$(whoami) logs variables: --=20 2.34.1