remote: remoteDomainCreate: Add missing struct initializer for 'ret2'

[libvirt PATCH] remote: remoteDomainCreate: Add missing struct initializer for 'ret2'

Erik Skultety posted 1 patch 1 year, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/c2aeb5e4fb507f56e12ae095e5c1825fbc820201.1674042976.git.eskultet@redhat.com

src/remote/remote_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] remote: remoteDomainCreate: Add missing struct initializer for 'ret2'

Posted by Erik Skultety 1 year, 3 months ago

Fixes: 62448c1a4927682f999fecf55e896de4625e46f6

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

The commit in question broke many integration tests:
https://gitlab.com/libvirt/libvirt/-/jobs/3620679044

 src/remote/remote_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 206a3829e2..33eff0fe12 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -2428,7 +2428,7 @@ remoteDomainCreate(virDomainPtr domain)
 {
     remote_domain_create_args args;
     remote_domain_lookup_by_uuid_args args2;
-    remote_domain_lookup_by_uuid_ret ret2;
+    remote_domain_lookup_by_uuid_ret ret2 = {0};
     struct private_data *priv = domain->conn->privateData;
     VIR_LOCK_GUARD lock = remoteDriverLock(priv);
 
-- 
2.39.0

Re: [libvirt PATCH] remote: remoteDomainCreate: Add missing struct initializer for 'ret2'

Posted by Daniel P. Berrangé 1 year, 3 months ago

On Wed, Jan 18, 2023 at 12:57:26PM +0100, Erik Skultety wrote:
> Fixes: 62448c1a4927682f999fecf55e896de4625e46f6
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> 
> The commit in question broke many integration tests:
> https://gitlab.com/libvirt/libvirt/-/jobs/3620679044
> 
>  src/remote/remote_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|