From nobody Sun May 19 04:05:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1674043259; cv=none; d=zohomail.com; s=zohoarc; b=DVytq0Vs1EohBoIwmNqBXz6mAH9N3sFl9Y2yMPhXEInR3PG8uPuTIYPDXB5/ilwczKQseP/JwkERX73ER+GdNinQeSQW1+bvci8LFpHBSKc4unVos81TtQO/Fa6ohPz2W8x+33aoZmpxDJRHnq70mF70LadChhBcScMWKPDrnsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674043259; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/q7OQV25M26XiwohpuMD5pjuEKznWVKb4OwEhDI/vro=; b=mXfnATMlNo8FhPIlhVplDParByXUt2zrcPO8DRPBgaNhS7epuna1XcAdmP76HzDdZcBCMa1pxt4T/0wnRUisyHAjuooklCUgupcJoF3jKXKiswhGSjxa97ocwEH+Dzd+94uWDVCwLN5IeeLtjKZnCV+vfddJtebRwtyHU+FeP88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1674043259625957.2384465560178; Wed, 18 Jan 2023 04:00:59 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-494-3Zu7LgGhMYuBpMEuCYibQw-1; Wed, 18 Jan 2023 07:00:56 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CCCB480D0EB; Wed, 18 Jan 2023 12:00:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 101991121318; Wed, 18 Jan 2023 12:00:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5151F1946A6B; Wed, 18 Jan 2023 12:00:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 854E519465B7 for ; Wed, 18 Jan 2023 11:57:27 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6640D1121319; Wed, 18 Jan 2023 11:57:27 +0000 (UTC) Received: from ridgehead.redhat.com (ovpn-193-76.brq.redhat.com [10.40.193.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7C2F1121315; Wed, 18 Jan 2023 11:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674043258; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/q7OQV25M26XiwohpuMD5pjuEKznWVKb4OwEhDI/vro=; b=a1vQBlwi0UMqeI776hPNsjYfO2VEeYwIwqUmN8EI4fEM1RHWGcbu7xdLXA7dIsvvSIspd8 EzHVyZWAMclDq3S2r1haUbDiNEBzM6LRLydqyH64WthE4w9ShHT8M+j1cyOXufNEoKyQ4d jtTjdnXSQ0lXOR+kyfHmUAdlR5l0l3M= X-MC-Unique: 3Zu7LgGhMYuBpMEuCYibQw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH] remote: remoteDomainCreate: Add missing struct initializer for 'ret2' Date: Wed, 18 Jan 2023 12:57:26 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1674043260779100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Fixes: 62448c1a4927682f999fecf55e896de4625e46f6 Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 --- The commit in question broke many integration tests: https://gitlab.com/libvirt/libvirt/-/jobs/3620679044 src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 206a3829e2..33eff0fe12 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -2428,7 +2428,7 @@ remoteDomainCreate(virDomainPtr domain) { remote_domain_create_args args; remote_domain_lookup_by_uuid_args args2; - remote_domain_lookup_by_uuid_ret ret2; + remote_domain_lookup_by_uuid_ret ret2 =3D {0}; struct private_data *priv =3D domain->conn->privateData; VIR_LOCK_GUARD lock =3D remoteDriverLock(priv); =20 --=20 2.39.0