[PATCH] rpc: Fix error message in virNetServerSetClientLimits

Martin Kletzander posted 1 patch 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/77a0035dd0fe26735671b1925735f014f3d47f6c.1674565008.git.mkletzan@redhat.com
src/rpc/virnetserver.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[PATCH] rpc: Fix error message in virNetServerSetClientLimits
Posted by Martin Kletzander 1 year, 3 months ago
Commit f007940cb25a tried to change the error message so that it is unified
later in 35afa1d2d6c1, but various rewrites missed this particular error message
which does not make sense.  Fix it so that it is the same as the other two
messages checking the same thing in this file.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2033879

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/rpc/virnetserver.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index bf0fda04ee89..e97dfe81369f 100644
--- a/src/rpc/virnetserver.c
+++ b/src/rpc/virnetserver.c
@@ -1127,9 +1127,8 @@ virNetServerSetClientLimits(virNetServer *srv,
 
     if (max < max_unauth) {
         virReportError(VIR_ERR_INVALID_ARG, "%s",
-                       _("The overall maximum number of clients waiting "
-                         "for authentication must not be less than the overall "
-                         "maximum number of clients"));
+                       _("The overall maximum number of clients must not be less "
+                         "than the number of clients waiting for authentication"));
         return -1;
     }
 
-- 
2.39.1
Re: [PATCH] rpc: Fix error message in virNetServerSetClientLimits
Posted by Ján Tomko 1 year, 3 months ago
On a Tuesday in 2023, Martin Kletzander wrote:
>Commit f007940cb25a tried to change the error message so that it is unified
>later in 35afa1d2d6c1, but various rewrites missed this particular error message
>which does not make sense.  Fix it so that it is the same as the other two
>messages checking the same thing in this file.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2033879
>
>Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>---
> src/rpc/virnetserver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano