From nobody Sat May 18 23:44:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1674565030; cv=none; d=zohomail.com; s=zohoarc; b=E7YczAD7wn+vYMShTnsd7kbV0ISq9taXt46YT4VJmqTxyDU8KXYearyp2HlVrZ/aUhFDj0j94TmlQA14tsyTeT8AUPlVvlHztBCWNqcSSNRa4+vRMjID3u+nT0sasD6fCoB1AAql2boYjEL/LYkf9nR3dk0XIVo86bwjzWOeE1M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674565030; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=3GXSnMRydJRp7wtxjZrylfA2uQ4nn7oPQ8+GSb2HnRg=; b=kFXDP32xTyie3nYKMdrAE0h7faFJfIHDe3evHTKHHa9PP0QXXHKs2Wi+oitIkYThSgOKvRFzDGNYJfQGDlNUqAeIpVIpBnwwryXBqUXuYIMLjRiB8+sJYNnNoIJ7HXsd51BXVNVowDjCgI2zsWR+8i1r8HV7+3aMFW/LwHjEFcc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 167456503070273.32620959847611; Tue, 24 Jan 2023 04:57:10 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-rtwsPQOtPG-UXfRjOhxIlQ-1; Tue, 24 Jan 2023 07:57:05 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C27AB88B7A2; Tue, 24 Jan 2023 12:57:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BB2A492B00; Tue, 24 Jan 2023 12:57:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EEF49194658C; Tue, 24 Jan 2023 12:56:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 01B651946589 for ; Tue, 24 Jan 2023 12:56:58 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id D8BDB39D92; Tue, 24 Jan 2023 12:56:58 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0C9E53A0 for ; Tue, 24 Jan 2023 12:56:58 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9CDF53C0E44E for ; Tue, 24 Jan 2023 12:56:58 +0000 (UTC) Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-628-ISO-tDz7NYKfeJ-Osw_GOw-1; Tue, 24 Jan 2023 07:56:57 -0500 Received: by mail-vs1-f71.google.com with SMTP id k27-20020a67ef5b000000b003d0dce04b32so3661562vsr.13 for ; Tue, 24 Jan 2023 04:56:57 -0800 (PST) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id h15-20020a05620a13ef00b006cec8001bf4sm1396966qkl.26.2023.01.24.04.56.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 04:56:54 -0800 (PST) Received: from wheatley.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 2D746D2E5230 for ; Tue, 24 Jan 2023 13:56:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674565029; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3GXSnMRydJRp7wtxjZrylfA2uQ4nn7oPQ8+GSb2HnRg=; b=a1JOVacFKPFliuHbuCb1gEoZhwKQtVwl8cHXsWb2mj7WF/FIw/ZzHDy+w2FlKysrBVEUui d678I1UWUgk2tMbjY8i1PSnrnzVY+Im+pVe4eFIQQkV7wHeXWQM2h/OqjTTiTf4Ym4vsVn VVx8pAsJ/6p2hpsIovFYgds6FXVNSAM= X-MC-Unique: rtwsPQOtPG-UXfRjOhxIlQ-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: ISO-tDz7NYKfeJ-Osw_GOw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3GXSnMRydJRp7wtxjZrylfA2uQ4nn7oPQ8+GSb2HnRg=; b=VpytHPFl6vaq6TB9HwuGFlQHOiJQMJRBdqeuina2i7qG7BxCOljDZeVUr/xuA2AK0R J4nVgbZvW0fX2mJZFrXgruv0oYhzPeiE49pHAuPJcnZTXrTGAieO0zCDVwsQJBQy/XLE ILgo40RecJQO1uDLyyayT0g6wAYIpQuAXn0IIf5ZwRx8ZMI0vsedTnBho9JIAPfjBfyj 2VAQIGYomEYGFa/n8w3QIXMcD2vsSeVNCaTZWkMtDXjK5G8wcBYBDUR1Hlag2Z0VF499 O47u26MO4AxrFlJwRHjRpoqge+vcmwv8jTrd298UwJsgdreL6TtVaZIyb5m8u+TM0S0I Jeew== X-Gm-Message-State: AFqh2kobox2H1mrwNRamxa8OFLBCMJvptlGLFKfspY5GoUWh1P7HvuH6 tNwcoAzKjNfocrzKkztHrzrgSSCmVLLLE5SGKu6HtYI2i64tKOlKdMizk0sgG8EijQ1M3uVvQF/ oQJnE8mAsejt35DI0qqOgcdxB3+F6PvnPDPnOyQRmrfeyNZDGkASfuQUbq2ss/ra2gdtMC3o= X-Received: by 2002:a05:6102:3ca8:b0:3d2:422f:77ac with SMTP id c40-20020a0561023ca800b003d2422f77acmr19420760vsv.1.1674565016776; Tue, 24 Jan 2023 04:56:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXuWl8VtrhoUe1uKJM7AhmU2eYRQfEN2dWwaBf9u3xwkC0oErf2IRC7E3+5ZxEuwnBzj3+s+gA== X-Received: by 2002:a05:6102:3ca8:b0:3d2:422f:77ac with SMTP id c40-20020a0561023ca800b003d2422f77acmr19420749vsv.1.1674565016465; Tue, 24 Jan 2023 04:56:56 -0800 (PST) From: Martin Kletzander To: libvir-list@redhat.com Subject: [PATCH] rpc: Fix error message in virNetServerSetClientLimits Date: Tue, 24 Jan 2023 13:56:48 +0100 Message-Id: <77a0035dd0fe26735671b1925735f014f3d47f6c.1674565008.git.mkletzan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1674565032637100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Commit f007940cb25a tried to change the error message so that it is unified later in 35afa1d2d6c1, but various rewrites missed this particular error me= ssage which does not make sense. Fix it so that it is the same as the other two messages checking the same thing in this file. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2033879 Signed-off-by: Martin Kletzander Reviewed-by: J=C3=A1n Tomko --- src/rpc/virnetserver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index bf0fda04ee89..e97dfe81369f 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -1127,9 +1127,8 @@ virNetServerSetClientLimits(virNetServer *srv, =20 if (max < max_unauth) { virReportError(VIR_ERR_INVALID_ARG, "%s", - _("The overall maximum number of clients waiting " - "for authentication must not be less than the ove= rall " - "maximum number of clients")); + _("The overall maximum number of clients must not b= e less " + "than the number of clients waiting for authentic= ation")); return -1; } =20 --=20 2.39.1