m4: Don't enable bash-completion by default

[libvirt] [PATCH] m4: Don't enable bash-completion by default

Michal Privoznik posted 1 patch 6 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/462cb1a0d780d6684f42e3bcbac59ecc31d6eaec.1515705666.git.mprivozn@redhat.com

m4/virt-bash-completion.m4 | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

Expand all Fold all

[libvirt] [PATCH] m4: Don't enable bash-completion by default

Posted by Michal Privoznik 6 years, 3 months ago

Due to the way that check logic was written we basically enabled
bash completion whenever readline was enabled. This is not right
because it made bash-completion pkg-config module required.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Even though this would qualify as a build breaker, I'd rather have
another pair of eyes to look at it (sorry Cyclops).

 m4/virt-bash-completion.m4 | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/m4/virt-bash-completion.m4 b/m4/virt-bash-completion.m4
index e1ef58740..c8342176f 100644
--- a/m4/virt-bash-completion.m4
+++ b/m4/virt-bash-completion.m4
@@ -30,14 +30,10 @@ AC_DEFUN([LIBVIRT_CHECK_BASH_COMPLETION], [
   AC_REQUIRE([LIBVIRT_CHECK_READLINE])
 
   if test "x$with_readline" != "xyes" ; then
-    if test "x$with_bash_completion" != "xyes" ; then
-      with_bash_completion=no
-    else
+    if test "x$with_bash_completion" = "xyes" ; then
       AC_MSG_ERROR([readline is required for bash completion support])
-    fi
-  else
-    if test "x$with_bash_completion" = "xcheck" ; then
-      with_bash_completion=yes
+    else
+      with_bash_completion=no
     fi
   fi
 
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] m4: Don't enable bash-completion by default

Posted by Pavel Hrdina 6 years, 3 months ago

On Thu, Jan 11, 2018 at 10:22:16PM +0100, Michal Privoznik wrote:
> Due to the way that check logic was written we basically enabled
> bash completion whenever readline was enabled. This is not right
> because it made bash-completion pkg-config module required.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list