From nobody Mon May 6 01:56:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 151570579631658.22130758564799; Thu, 11 Jan 2018 13:23:16 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 056AFC00AE13; Thu, 11 Jan 2018 21:22:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0094B1713F; Thu, 11 Jan 2018 21:22:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 986814EBD7; Thu, 11 Jan 2018 21:22:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w0BLMP21005829 for ; Thu, 11 Jan 2018 16:22:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2E71A7FCE2; Thu, 11 Jan 2018 21:22:25 +0000 (UTC) Received: from localhost.localdomain (ovpn-204-118.brq.redhat.com [10.40.204.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94D047FCE1 for ; Thu, 11 Jan 2018 21:22:22 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 11 Jan 2018 22:22:16 +0100 Message-Id: <462cb1a0d780d6684f42e3bcbac59ecc31d6eaec.1515705666.git.mprivozn@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] m4: Don't enable bash-completion by default X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 11 Jan 2018 21:23:14 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Due to the way that check logic was written we basically enabled bash completion whenever readline was enabled. This is not right because it made bash-completion pkg-config module required. Signed-off-by: Michal Privoznik Reviewed-by: Pavel Hrdina --- Even though this would qualify as a build breaker, I'd rather have another pair of eyes to look at it (sorry Cyclops). m4/virt-bash-completion.m4 | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/m4/virt-bash-completion.m4 b/m4/virt-bash-completion.m4 index e1ef58740..c8342176f 100644 --- a/m4/virt-bash-completion.m4 +++ b/m4/virt-bash-completion.m4 @@ -30,14 +30,10 @@ AC_DEFUN([LIBVIRT_CHECK_BASH_COMPLETION], [ AC_REQUIRE([LIBVIRT_CHECK_READLINE]) =20 if test "x$with_readline" !=3D "xyes" ; then - if test "x$with_bash_completion" !=3D "xyes" ; then - with_bash_completion=3Dno - else + if test "x$with_bash_completion" =3D "xyes" ; then AC_MSG_ERROR([readline is required for bash completion support]) - fi - else - if test "x$with_bash_completion" =3D "xcheck" ; then - with_bash_completion=3Dyes + else + with_bash_completion=3Dno fi fi =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list