remote: add missing lock guard for secret value API

[PATCH] remote: add missing lock guard for secret value API

Daniel P. Berrangé posted 1 patch 1 year, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230118125508.466685-1-berrange@redhat.com

src/remote/remote_driver.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] remote: add missing lock guard for secret value API

Posted by Daniel P. Berrangé 1 year, 3 months ago

This fixes a bug in

  commit fda53ab3a536647192dd088672dcb6f4a6820e51
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Thu Dec 22 10:29:32 2022 -0500

    remote: use VIR_LOCK_GUARD in client code

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/remote/remote_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 206a3829e2..a1e08bcfe2 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -5088,6 +5088,7 @@ remoteSecretGetValue(virSecretPtr secret, size_t *value_size,
     remote_secret_get_value_args args;
     remote_secret_get_value_ret ret = {0};
     struct private_data *priv = secret->conn->privateData;
+    VIR_LOCK_GUARD lock = remoteDriverLock(priv);
 
     make_nonnull_secret(&args.secret, secret);
     args.flags = flags;
-- 
2.39.0

Re: [PATCH] remote: add missing lock guard for secret value API

Posted by Erik Skultety 1 year, 3 months ago

On Wed, Jan 18, 2023 at 12:55:08PM +0000, Daniel P. Berrangé wrote:
> This fixes a bug in
> 
>   commit fda53ab3a536647192dd088672dcb6f4a6820e51
>   Author: Daniel P. Berrangé <berrange@redhat.com>
>   Date:   Thu Dec 22 10:29:32 2022 -0500
> 
>     remote: use VIR_LOCK_GUARD in client code
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat>