From nobody Sat May 18 21:16:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1674046520; cv=none; d=zohomail.com; s=zohoarc; b=JZaoV+dt34Wgf5W3GuL7bn3+ErsNboAz4aAxXlf4M9WuXNId+DkIQOv2zG2afTmo17Ge6H5twcB3a5B5rtac0U1fAKAP8uF7omC8flK8STOMxD+TQsI3ncyeEM95n9DAMfkq4rSISwGTxGOTmn/xlljCv+/MGVewmk9SlFMj8Zw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674046520; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=L6JNHOFQOSKPZdY+R/OBhkLbwbd2Ity77xHGIeoMMMQ=; b=PMZj8gDh65Ef0MNRDttksmL7pxHy8MvfTBs//RNptjGDCBNj6z/zEGPoqVeLE838J2+deOK8+3CW6FZdVJZqit4fuldb06rzHq6UsgPLsykTr8scZ9Cbp0IQq6UlSkw1gd66tCDJvq3N/C/3frACk8Hyy74m7qnIbA5RhI8kOlQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1674046520987176.62559558683836; Wed, 18 Jan 2023 04:55:20 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-278-oOqsyLYqOyi7mwg_KJF6NQ-1; Wed, 18 Jan 2023 07:55:14 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 724F7280BCA6; Wed, 18 Jan 2023 12:55:12 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B3A0140EBF5; Wed, 18 Jan 2023 12:55:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 78F391946A45; Wed, 18 Jan 2023 12:55:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A4DDA19465B7 for ; Wed, 18 Jan 2023 12:55:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8C9B31121315; Wed, 18 Jan 2023 12:55:10 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 213851121318; Wed, 18 Jan 2023 12:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674046520; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=L6JNHOFQOSKPZdY+R/OBhkLbwbd2Ity77xHGIeoMMMQ=; b=hsdSd0I/ZUE5pfVg2OFqHgnej7Ke5jf2SZaiIl5+2tYydda9a7Hcatai5G2DZscFX880id idhTzE1XVeReYVFrxcp4ehmNvTuCJI++iNS++j82UxAUYR/N05X1Q1eGfDP1dIIPaic5G3 uQVWYz/Wtldq0cwr7b5efay+ekBDuH8= X-MC-Unique: oOqsyLYqOyi7mwg_KJF6NQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [PATCH] remote: add missing lock guard for secret value API Date: Wed, 18 Jan 2023 12:55:08 +0000 Message-Id: <20230118125508.466685-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1674046522656100001 This fixes a bug in commit fda53ab3a536647192dd088672dcb6f4a6820e51 Author: Daniel P. Berrang=C3=A9 Date: Thu Dec 22 10:29:32 2022 -0500 remote: use VIR_LOCK_GUARD in client code Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Erik Skultety --- src/remote/remote_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 206a3829e2..a1e08bcfe2 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5088,6 +5088,7 @@ remoteSecretGetValue(virSecretPtr secret, size_t *val= ue_size, remote_secret_get_value_args args; remote_secret_get_value_ret ret =3D {0}; struct private_data *priv =3D secret->conn->privateData; + VIR_LOCK_GUARD lock =3D remoteDriverLock(priv); =20 make_nonnull_secret(&args.secret, secret); args.flags =3D flags; --=20 2.39.0