qemu: Always check nodeset provided to numatune

[libvirt PATCH 0/2] qemu: Always check nodeset provided to numatune

Andrea Bolognani posted 2 patches 1 year, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230103183755.248044-1-abologna@redhat.com

src/qemu/qemu_command.c                       |  6 ++++--
...-unavailable-restrictive.x86_64-latest.err |  1 +
...matune-memnode-unavailable-restrictive.xml | 20 +++++++++++++++++++
...mnode-unavailable-strict.x86_64-latest.err |  1 +
.../numatune-memnode-unavailable-strict.xml   | 20 +++++++++++++++++++
tests/qemuxml2argvtest.c                      |  2 ++
6 files changed, 48 insertions(+), 2 deletions(-)
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_64-latest.err
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.xml
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.x86_64-latest.err
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.xml

Expand all Fold all

[libvirt PATCH 0/2] qemu: Always check nodeset provided to numatune

Posted by Andrea Bolognani 1 year, 4 months ago

Behave more consistently when presented with an invalid configuration.

Andrea Bolognani (2):
  tests: Add cases for numatune with unavailable nodes
  qemu: Always check nodeset provided to numatune

 src/qemu/qemu_command.c                       |  6 ++++--
 ...-unavailable-restrictive.x86_64-latest.err |  1 +
 ...matune-memnode-unavailable-restrictive.xml | 20 +++++++++++++++++++
 ...mnode-unavailable-strict.x86_64-latest.err |  1 +
 .../numatune-memnode-unavailable-strict.xml   | 20 +++++++++++++++++++
 tests/qemuxml2argvtest.c                      |  2 ++
 6 files changed, 48 insertions(+), 2 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_64-latest.err
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.xml
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.x86_64-latest.err
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.xml

-- 
2.39.0

Re: [libvirt PATCH 0/2] qemu: Always check nodeset provided to numatune

Posted by Michal Prívozník 1 year, 3 months ago

On 1/3/23 19:37, Andrea Bolognani wrote:
> Behave more consistently when presented with an invalid configuration.
> 
> Andrea Bolognani (2):
>   tests: Add cases for numatune with unavailable nodes
>   qemu: Always check nodeset provided to numatune
> 
>  src/qemu/qemu_command.c                       |  6 ++++--
>  ...-unavailable-restrictive.x86_64-latest.err |  1 +
>  ...matune-memnode-unavailable-restrictive.xml | 20 +++++++++++++++++++
>  ...mnode-unavailable-strict.x86_64-latest.err |  1 +
>  .../numatune-memnode-unavailable-strict.xml   | 20 +++++++++++++++++++
>  tests/qemuxml2argvtest.c                      |  2 ++
>  6 files changed, 48 insertions(+), 2 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_64-latest.err
>  create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.xml
>  create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.x86_64-latest.err
>  create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.xml
> 

Ooops, yes.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal