From nobody Sat May 18 10:57:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1672771092; cv=none; d=zohomail.com; s=zohoarc; b=Yylb4mKi6whC2Lj83NFE3FGB8R7wqrcym28ESAkMUm0noGV8s7wAR/AogVWOxiNb9iuNzdl1zY8VNYaFXmlxXhij6xbaNmaDwMrs7suGgeT0cieXY6WaZsNLJXyL5Ax1COHBncQflpk7vcoA4/cvVfrB+Ch+Lb0FN2gMwR+lTCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672771092; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=znhX3m8ViAhZJT0h/LzZ82ztDOcZSObflrlgqdS3tNE=; b=DHJxZ6jjKfKVd8ZMatM8ELDwU8K7lKZEpnQkAYl1jyEVjNV/bAmZWvrv7I04vBxVRe5YlqNi6z8y+dZrSVWoyDH3zXNjV/m+MpJRFx+MC4M42ciyLutzhn2OLMLdzDQNP1RhvtLFLNfelB/VAX+HIs6H4dov68y+4xMc5n/10TQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1672771092909520.6943713129791; Tue, 3 Jan 2023 10:38:12 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-18-yZmahuSmMUS8l9CDA7yM5A-1; Tue, 03 Jan 2023 13:38:08 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B009802D1B; Tue, 3 Jan 2023 18:38:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83A87140EBF4; Tue, 3 Jan 2023 18:38:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0925F1946587; Tue, 3 Jan 2023 18:38:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 36EA31946587 for ; Tue, 3 Jan 2023 18:38:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 1D061400D752; Tue, 3 Jan 2023 18:38:04 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (ovpn-194-251.brq.redhat.com [10.40.194.251]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 976BF40C1141 for ; Tue, 3 Jan 2023 18:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672771091; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=znhX3m8ViAhZJT0h/LzZ82ztDOcZSObflrlgqdS3tNE=; b=V505+9y58KsdLKVccA5O5D0rE9TWpgdOzVCUAGavHmBgBRuNDcP83Mw88XpAI3tiANfCJp 9JzCBvsLpUcns+6XPf+PEqV90U34n+a/kDtjaj6pTydO9b3H3pGfvKtm3QY/HvW5xAnkUd iVVMIkU6P2963v/xSO+G2y/YAYjWlno= X-MC-Unique: yZmahuSmMUS8l9CDA7yM5A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 1/2] tests: Add cases for numatune with unavailable nodes Date: Tue, 3 Jan 2023 19:37:54 +0100 Message-Id: <20230103183755.248044-2-abologna@redhat.com> In-Reply-To: <20230103183755.248044-1-abologna@redhat.com> References: <20230103183755.248044-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1672771093363100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The one for mode=3Dstrict fails, as expected, while the one for mode=3Drestrictive currently doesn't even though it should. The next commit will address the issue. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- ...unavailable-restrictive.x86_64-latest.args | 32 +++++++++++++++++++ ...matune-memnode-unavailable-restrictive.xml | 20 ++++++++++++ ...mnode-unavailable-strict.x86_64-latest.err | 1 + .../numatune-memnode-unavailable-strict.xml | 20 ++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 5 files changed, 75 insertions(+) create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-res= trictive.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-res= trictive.xml create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-str= ict.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-str= ict.xml diff --git a/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictiv= e.x86_64-latest.args b/tests/qemuxml2argvdata/numatune-memnode-unavailable-= restrictive.x86_64-latest.args new file mode 100644 index 0000000000..b257ef1c68 --- /dev/null +++ b/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_6= 4-latest.args @@ -0,0 +1,32 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/tmp/lib/domain--1-QEMUGuest \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/tmp/lib/domain--1-QEMUGuest/.local/share \ +XDG_CACHE_HOME=3D/tmp/lib/domain--1-QEMUGuest/.cache \ +XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest/.config \ +/usr/bin/qemu-system-x86_64 \ +-name guest=3DQEMUGuest,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tm= p/lib/domain--1-QEMUGuest/master-key.aes"}' \ +-machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram \ +-accel tcg \ +-cpu qemu64 \ +-m 24104 \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":25274875904= }' \ +-overcommit mem-lock=3Doff \ +-smp 32,sockets=3D32,cores=3D1,threads=3D1 \ +-uuid 9f4b6512-e73a-4a25-93e8-5307802821ce \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-no-acpi \ +-boot strict=3Don \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictiv= e.xml b/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.xml new file mode 100644 index 0000000000..741bec399b --- /dev/null +++ b/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.xml @@ -0,0 +1,20 @@ + + QEMUGuest + 9f4b6512-e73a-4a25-93e8-5307802821ce + 24682468 + 24682468 + 32 + + + + + hvm + + + + /usr/bin/qemu-system-x86_64 + + + + + diff --git a/tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.x86= _64-latest.err b/tests/qemuxml2argvdata/numatune-memnode-unavailable-strict= .x86_64-latest.err new file mode 100644 index 0000000000..a826c3cdeb --- /dev/null +++ b/tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.x86_64-lat= est.err @@ -0,0 +1 @@ +internal error: Mock: no numa node set is available at bit 999 diff --git a/tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.xml= b/tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.xml new file mode 100644 index 0000000000..a2805f7f91 --- /dev/null +++ b/tests/qemuxml2argvdata/numatune-memnode-unavailable-strict.xml @@ -0,0 +1,20 @@ + + QEMUGuest + 9f4b6512-e73a-4a25-93e8-5307802821ce + 24682468 + 24682468 + 32 + + + + + hvm + + + + /usr/bin/qemu-system-x86_64 + + + + + diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 2db0e90f2b..8130e12314 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1981,6 +1981,8 @@ mymain(void) DO_TEST_FAILURE_NOCAPS("numatune-static-nodeset-exceed-hostnode"); DO_TEST_PARSE_ERROR_NOCAPS("numatune-memnode-nocpu"); DO_TEST_PARSE_ERROR_NOCAPS("numatune-memnodes-problematic"); + DO_TEST_CAPS_LATEST_FAILURE("numatune-memnode-unavailable-strict"); + DO_TEST_CAPS_LATEST("numatune-memnode-unavailable-restrictive"); DO_TEST_NOCAPS("numad"); DO_TEST_NOCAPS("numad-auto-vcpu-static-numatune"); DO_TEST_PARSE_ERROR_NOCAPS("numad-auto-vcpu-static-numatune-no-nodeset= "); --=20 2.39.0 From nobody Sat May 18 10:57:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1672771145; cv=none; d=zohomail.com; s=zohoarc; b=N02Wo8hquUW79UAgpCZOajiHDw56ayIC9m+Lm8rs3NSIJwFXVN8iNNNGz/vj6I/4B5m7cpICP/4bS7TXxH/rn78tx2gLyFl8fQLNWuE3yHRwIqypPmCA9npdEASzeZB4/x9sVAuAuOZ/Zlc1wJiyuK4IJaQUqlm/WKa8JGVwoyk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672771145; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ECq+Scb9tsRQ0gW5SFrnPoYNcafgFp7IEaDavAHYy4g=; b=We+Yh6xMja8mcxgfPnoDx7Dtkv9eSDl7QN+TX8v+gfH5o1a17p9NJtUAWJ4uskb4R8puatl8h+qKCNtfJCUutP44ji+0ZGknCZoZFKf9vLOOIvhZ1j/TBisbSEjGcieK2ohEv9dR7/P4RmakHLI0gVSEO9fsFtIO7OQNP4Yt/So= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 167277114586651.703375108926025; Tue, 3 Jan 2023 10:39:05 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-323-m7w8riOTOc2qHKcReayDOA-1; Tue, 03 Jan 2023 13:38:09 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BFAF4101A55E; Tue, 3 Jan 2023 18:38:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC78BC15BA0; Tue, 3 Jan 2023 18:38:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 92D511946589; Tue, 3 Jan 2023 18:38:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1D8B71946A40 for ; Tue, 3 Jan 2023 18:38:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E473140C115E; Tue, 3 Jan 2023 18:38:04 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (ovpn-194-251.brq.redhat.com [10.40.194.251]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A6ED40C1141 for ; Tue, 3 Jan 2023 18:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672771144; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ECq+Scb9tsRQ0gW5SFrnPoYNcafgFp7IEaDavAHYy4g=; b=Ya8J2xxdY8FgLyZ6UCyX6LZMUZO1otHBIBsJFXgvoEjo3cKuMKzZ2ChU+7WGmlX2AaDLEK giTGnuH7uPlCx1Kp6kCRxYCMqtnjZUMsVupJFU1wOEFnoZSSUOsjqXT65+gTpyiuL6lwue v7cTHm/e1LIP02DUPuuAaY/+lSb5rN8= X-MC-Unique: m7w8riOTOc2qHKcReayDOA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 2/2] qemu: Always check nodeset provided to numatune Date: Tue, 3 Jan 2023 19:37:55 +0100 Message-Id: <20230103183755.248044-3-abologna@redhat.com> In-Reply-To: <20230103183755.248044-1-abologna@redhat.com> References: <20230103183755.248044-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1672771147593100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Up until commit 629282d88454, using mode=3Drestrictive caused virNumaSetupMemoryPolicy() to be called from qemuProcessHook(), and that in turn resulted in virNumaNodesetIsAvailable() being called and the nodeset being validated. After that change, the only validation for the nodeset is the one happening in qemuBuildMemoryBackendProps(), which is skipped when using mode=3Drestrictive. Make sure virNumaNodesetIsAvailable() is called whenever a nodeset has been provided by the user, regardless of the mode. https://bugzilla.redhat.com/show_bug.cgi?id=3D2156289 Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/qemu/qemu_command.c | 6 ++-- ...unavailable-restrictive.x86_64-latest.args | 32 ------------------- ...-unavailable-restrictive.x86_64-latest.err | 1 + tests/qemuxml2argvtest.c | 2 +- 4 files changed, 6 insertions(+), 35 deletions(-) delete mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-res= trictive.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/numatune-memnode-unavailable-res= trictive.x86_64-latest.err diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ee2e873b95..7a2c576e83 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3428,12 +3428,14 @@ qemuBuildMemoryBackendProps(virJSONValue **backendP= rops, return -1; } =20 + /* Make sure the requested nodeset is sensible */ + if (nodemask && !virNumaNodesetIsAvailable(nodemask)) + return -1; + /* If mode is "restrictive", we should only use cgroups setting allowe= d memory * nodes, and skip passing the host-nodes and policy parameters to QEM= U command * line which means we will use system default memory policy. */ if (nodemask && mode !=3D VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE) { - if (!virNumaNodesetIsAvailable(nodemask)) - return -1; if (virJSONValueObjectAdd(&props, "m:host-nodes", nodemask, "S:policy", qemuNumaPolicyTypeToString(m= ode), diff --git a/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictiv= e.x86_64-latest.args b/tests/qemuxml2argvdata/numatune-memnode-unavailable-= restrictive.x86_64-latest.args deleted file mode 100644 index b257ef1c68..0000000000 --- a/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_6= 4-latest.args +++ /dev/null @@ -1,32 +0,0 @@ -LC_ALL=3DC \ -PATH=3D/bin \ -HOME=3D/tmp/lib/domain--1-QEMUGuest \ -USER=3Dtest \ -LOGNAME=3Dtest \ -XDG_DATA_HOME=3D/tmp/lib/domain--1-QEMUGuest/.local/share \ -XDG_CACHE_HOME=3D/tmp/lib/domain--1-QEMUGuest/.cache \ -XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest/.config \ -/usr/bin/qemu-system-x86_64 \ --name guest=3DQEMUGuest,debug-threads=3Don \ --S \ --object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tm= p/lib/domain--1-QEMUGuest/master-key.aes"}' \ --machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram \ --accel tcg \ --cpu qemu64 \ --m 24104 \ --object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":25274875904= }' \ --overcommit mem-lock=3Doff \ --smp 32,sockets=3D32,cores=3D1,threads=3D1 \ --uuid 9f4b6512-e73a-4a25-93e8-5307802821ce \ --display none \ --no-user-config \ --nodefaults \ --chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ --mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ --rtc base=3Dutc \ --no-shutdown \ --no-acpi \ --boot strict=3Don \ --audiodev '{"id":"audio1","driver":"none"}' \ --sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ --msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictiv= e.x86_64-latest.err b/tests/qemuxml2argvdata/numatune-memnode-unavailable-r= estrictive.x86_64-latest.err new file mode 100644 index 0000000000..a826c3cdeb --- /dev/null +++ b/tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_6= 4-latest.err @@ -0,0 +1 @@ +internal error: Mock: no numa node set is available at bit 999 diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 8130e12314..44ad0f7049 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1982,7 +1982,7 @@ mymain(void) DO_TEST_PARSE_ERROR_NOCAPS("numatune-memnode-nocpu"); DO_TEST_PARSE_ERROR_NOCAPS("numatune-memnodes-problematic"); DO_TEST_CAPS_LATEST_FAILURE("numatune-memnode-unavailable-strict"); - DO_TEST_CAPS_LATEST("numatune-memnode-unavailable-restrictive"); + DO_TEST_CAPS_LATEST_FAILURE("numatune-memnode-unavailable-restrictive"= ); DO_TEST_NOCAPS("numad"); DO_TEST_NOCAPS("numad-auto-vcpu-static-numatune"); DO_TEST_PARSE_ERROR_NOCAPS("numad-auto-vcpu-static-numatune-no-nodeset= "); --=20 2.39.0