1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] src: Fix memory leak in virNWFilterBindingDispose

John Ferlan posted 1 patch 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180720150648.26401-1-jferlan@redhat.com
Test syntax-check passed
src/datatypes.c | 1 +
1 file changed, 1 insertion(+)
[libvirt] [PATCH] src: Fix memory leak in virNWFilterBindingDispose
Posted by John Ferlan 5 years, 9 months ago 
https://bugzilla.redhat.com/show_bug.cgi?id=1603025

Commit b57a9aec neglected to VIR_FREE(binding->filtername) as seen
in the following valgrind report

==6423== 17,328 bytes in 1,083 blocks are definitely lost in loss record 2,275 of 2,297
==6423==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
==6423==    by 0x83B20C9: strdup (in /usr/lib64/libc-2.17.so)
==6423==    by 0x533C144: virStrdup (virstring.c:977)
==6423==    by 0x54BDD53: virGetNWFilterBinding (datatypes.c:865)
==6423==    by 0x318D633C: nwfilterBindingCreateXML (nwfilter_driver.c:767)
==6423==    by 0x54F3FC5: virNWFilterBindingCreateXML (libvirt-nwfilter.c:701)
==6423==    by 0x539CE29: virDomainConfNWFilterInstantiate (domain_nwfilter.c:116)
==6423==    by 0x31E516C2: qemuInterfaceBridgeConnect (qemu_interface.c:589)
==6423==    by 0x31D98B56: qemuBuildInterfaceCommandLine (qemu_command.c:8418)
==6423==    by 0x31D9F783: qemuBuildNetCommandLine (qemu_command.c:8673)
==6423==    by 0x31D9F783: qemuBuildCommandLine (qemu_command.c:10354)
==6423==    by 0x31DE355F: qemuProcessLaunch (qemu_process.c:6292)
==6423==    by 0x31DE7881: qemuProcessStart (qemu_process.c:6686)

and

==6423== 17,328 bytes in 1,083 blocks are definitely lost in loss record 2,276 of 2,297
==6423==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
==6423==    by 0x83B20C9: strdup (in /usr/lib64/libc-2.17.so)
==6423==    by 0x533C144: virStrdup (virstring.c:977)
==6423==    by 0x54BDD53: virGetNWFilterBinding (datatypes.c:865)
==6423==    by 0x318D641F: nwfilterBindingLookupByPortDev (nwfilter_driver.c:678)
==6423==    by 0x54F3B63: virNWFilterBindingLookupByPortDev (libvirt-nwfilter.c:593)
==6423==    by 0x539CBC5: virDomainConfNWFilterTeardownImpl.isra.0 (domain_nwfilter.c:136)
==6423==    by 0x539CFA5: virDomainConfVMNWFilterTeardown (domain_nwfilter.c:170)
==6423==    by 0x31DE5651: qemuProcessStop (qemu_process.c:6912)
==6423==    by 0x31E37974: qemuDomainDestroyFlags (qemu_driver.c:2229)
==6423==    by 0x54C24BB: virDomainDestroy (libvirt-domain.c:475)
==6423==    by 0x1589A2: remoteDispatchDomainDestroy (remote_daemon_dispatch_stubs.h:4827)
==6423==    by 0x1589A2: remoteDispatchDomainDestroyHelper (remote_daemon_dispatch_stubs.h:4803)

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 src/datatypes.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/datatypes.c b/src/datatypes.c
index 878a1c5b5f..caf035f178 100644
--- a/src/datatypes.c
+++ b/src/datatypes.c
@@ -893,6 +893,7 @@ virNWFilterBindingDispose(void *obj)
     VIR_DEBUG("release binding %p %s", binding, binding->portdev);
 
     VIR_FREE(binding->portdev);
+    VIR_FREE(binding->filtername);
     virObjectUnref(binding->conn);
 }
 
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] src: Fix memory leak in virNWFilterBindingDispose
Posted by Daniel P. Berrangé 5 years, 9 months ago 
On Fri, Jul 20, 2018 at 11:06:48AM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1603025
> 
> Commit b57a9aec neglected to VIR_FREE(binding->filtername) as seen
> in the following valgrind report
> 
> ==6423== 17,328 bytes in 1,083 blocks are definitely lost in loss record 2,275 of 2,297
> ==6423==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
> ==6423==    by 0x83B20C9: strdup (in /usr/lib64/libc-2.17.so)
> ==6423==    by 0x533C144: virStrdup (virstring.c:977)
> ==6423==    by 0x54BDD53: virGetNWFilterBinding (datatypes.c:865)
> ==6423==    by 0x318D633C: nwfilterBindingCreateXML (nwfilter_driver.c:767)
> ==6423==    by 0x54F3FC5: virNWFilterBindingCreateXML (libvirt-nwfilter.c:701)
> ==6423==    by 0x539CE29: virDomainConfNWFilterInstantiate (domain_nwfilter.c:116)
> ==6423==    by 0x31E516C2: qemuInterfaceBridgeConnect (qemu_interface.c:589)
> ==6423==    by 0x31D98B56: qemuBuildInterfaceCommandLine (qemu_command.c:8418)
> ==6423==    by 0x31D9F783: qemuBuildNetCommandLine (qemu_command.c:8673)
> ==6423==    by 0x31D9F783: qemuBuildCommandLine (qemu_command.c:10354)
> ==6423==    by 0x31DE355F: qemuProcessLaunch (qemu_process.c:6292)
> ==6423==    by 0x31DE7881: qemuProcessStart (qemu_process.c:6686)
> 
> and
> 
> ==6423== 17,328 bytes in 1,083 blocks are definitely lost in loss record 2,276 of 2,297
> ==6423==    at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
> ==6423==    by 0x83B20C9: strdup (in /usr/lib64/libc-2.17.so)
> ==6423==    by 0x533C144: virStrdup (virstring.c:977)
> ==6423==    by 0x54BDD53: virGetNWFilterBinding (datatypes.c:865)
> ==6423==    by 0x318D641F: nwfilterBindingLookupByPortDev (nwfilter_driver.c:678)
> ==6423==    by 0x54F3B63: virNWFilterBindingLookupByPortDev (libvirt-nwfilter.c:593)
> ==6423==    by 0x539CBC5: virDomainConfNWFilterTeardownImpl.isra.0 (domain_nwfilter.c:136)
> ==6423==    by 0x539CFA5: virDomainConfVMNWFilterTeardown (domain_nwfilter.c:170)
> ==6423==    by 0x31DE5651: qemuProcessStop (qemu_process.c:6912)
> ==6423==    by 0x31E37974: qemuDomainDestroyFlags (qemu_driver.c:2229)
> ==6423==    by 0x54C24BB: virDomainDestroy (libvirt-domain.c:475)
> ==6423==    by 0x1589A2: remoteDispatchDomainDestroy (remote_daemon_dispatch_stubs.h:4827)
> ==6423==    by 0x1589A2: remoteDispatchDomainDestroyHelper (remote_daemon_dispatch_stubs.h:4803)
> 
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>  src/datatypes.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/datatypes.c b/src/datatypes.c
> index 878a1c5b5f..caf035f178 100644
> --- a/src/datatypes.c
> +++ b/src/datatypes.c
> @@ -893,6 +893,7 @@ virNWFilterBindingDispose(void *obj)
>      VIR_DEBUG("release binding %p %s", binding, binding->portdev);
>  
>      VIR_FREE(binding->portdev);
> +    VIR_FREE(binding->filtername);
>      virObjectUnref(binding->conn);
>  }

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.