From nobody Sat May 4 21:00:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1532099217048161.9170051540127; Fri, 20 Jul 2018 08:06:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DA68821C1; Fri, 20 Jul 2018 15:06:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C5192010CA4; Fri, 20 Jul 2018 15:06:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8AAF118037ED; Fri, 20 Jul 2018 15:06:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6KF6piD023787 for ; Fri, 20 Jul 2018 11:06:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id C69B35D9CB; Fri, 20 Jul 2018 15:06:51 +0000 (UTC) Received: from unknown4CEB42C824F4.redhat.com (ovpn-117-32.phx2.redhat.com [10.3.117.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F8215D9CA for ; Fri, 20 Jul 2018 15:06:49 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Fri, 20 Jul 2018 11:06:48 -0400 Message-Id: <20180720150648.26401-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] src: Fix memory leak in virNWFilterBindingDispose X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 20 Jul 2018 15:06:55 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1603025 Commit b57a9aec neglected to VIR_FREE(binding->filtername) as seen in the following valgrind report =3D=3D6423=3D=3D 17,328 bytes in 1,083 blocks are definitely lost in loss r= ecord 2,275 of 2,297 =3D=3D6423=3D=3D at 0x4C29BC3: malloc (vg_replace_malloc.c:299) =3D=3D6423=3D=3D by 0x83B20C9: strdup (in /usr/lib64/libc-2.17.so) =3D=3D6423=3D=3D by 0x533C144: virStrdup (virstring.c:977) =3D=3D6423=3D=3D by 0x54BDD53: virGetNWFilterBinding (datatypes.c:865) =3D=3D6423=3D=3D by 0x318D633C: nwfilterBindingCreateXML (nwfilter_drive= r.c:767) =3D=3D6423=3D=3D by 0x54F3FC5: virNWFilterBindingCreateXML (libvirt-nwfi= lter.c:701) =3D=3D6423=3D=3D by 0x539CE29: virDomainConfNWFilterInstantiate (domain_= nwfilter.c:116) =3D=3D6423=3D=3D by 0x31E516C2: qemuInterfaceBridgeConnect (qemu_interfa= ce.c:589) =3D=3D6423=3D=3D by 0x31D98B56: qemuBuildInterfaceCommandLine (qemu_comm= and.c:8418) =3D=3D6423=3D=3D by 0x31D9F783: qemuBuildNetCommandLine (qemu_command.c:= 8673) =3D=3D6423=3D=3D by 0x31D9F783: qemuBuildCommandLine (qemu_command.c:103= 54) =3D=3D6423=3D=3D by 0x31DE355F: qemuProcessLaunch (qemu_process.c:6292) =3D=3D6423=3D=3D by 0x31DE7881: qemuProcessStart (qemu_process.c:6686) and =3D=3D6423=3D=3D 17,328 bytes in 1,083 blocks are definitely lost in loss r= ecord 2,276 of 2,297 =3D=3D6423=3D=3D at 0x4C29BC3: malloc (vg_replace_malloc.c:299) =3D=3D6423=3D=3D by 0x83B20C9: strdup (in /usr/lib64/libc-2.17.so) =3D=3D6423=3D=3D by 0x533C144: virStrdup (virstring.c:977) =3D=3D6423=3D=3D by 0x54BDD53: virGetNWFilterBinding (datatypes.c:865) =3D=3D6423=3D=3D by 0x318D641F: nwfilterBindingLookupByPortDev (nwfilter= _driver.c:678) =3D=3D6423=3D=3D by 0x54F3B63: virNWFilterBindingLookupByPortDev (libvir= t-nwfilter.c:593) =3D=3D6423=3D=3D by 0x539CBC5: virDomainConfNWFilterTeardownImpl.isra.0 = (domain_nwfilter.c:136) =3D=3D6423=3D=3D by 0x539CFA5: virDomainConfVMNWFilterTeardown (domain_n= wfilter.c:170) =3D=3D6423=3D=3D by 0x31DE5651: qemuProcessStop (qemu_process.c:6912) =3D=3D6423=3D=3D by 0x31E37974: qemuDomainDestroyFlags (qemu_driver.c:22= 29) =3D=3D6423=3D=3D by 0x54C24BB: virDomainDestroy (libvirt-domain.c:475) =3D=3D6423=3D=3D by 0x1589A2: remoteDispatchDomainDestroy (remote_daemon= _dispatch_stubs.h:4827) =3D=3D6423=3D=3D by 0x1589A2: remoteDispatchDomainDestroyHelper (remote_= daemon_dispatch_stubs.h:4803) Signed-off-by: John Ferlan Reviewed-by: Daniel P. Berrang=C3=A9 --- src/datatypes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/datatypes.c b/src/datatypes.c index 878a1c5b5f..caf035f178 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -893,6 +893,7 @@ virNWFilterBindingDispose(void *obj) VIR_DEBUG("release binding %p %s", binding, binding->portdev); =20 VIR_FREE(binding->portdev); + VIR_FREE(binding->filtername); virObjectUnref(binding->conn); } =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list