The git:// protocol can cause issues when the client is
behind a corporate firewall; https:// works in pretty much
any scenario, and these days it's basically as efficient.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 xml_test.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xml_test.go b/xml_test.go
index dcec589..2a2e16f 100644
--- a/xml_test.go
+++ b/xml_test.go
@@ -388,7 +388,7 @@ func syncGit(t *testing.T) {
 	_, err := os.Stat("testdata/libvirt/tests")
 	if err != nil {
 		if os.IsNotExist(err) {
-			msg, err := exec.Command("git", "clone", "--depth", "1", "git://libvirt.org/libvirt.git", "testdata/libvirt").CombinedOutput()
+			msg, err := exec.Command("git", "clone", "--depth", "1", "https://libvirt.org/git/libvirt.git", "testdata/libvirt").CombinedOutput()
 			if err != nil {
 				t.Fatal(fmt.Errorf("Unable to clone libvirt.git: %s: %s", err, msg))
 			}
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, May 10, 2018 at 03:43:47PM +0200, Andrea Bolognani wrote:
> The git:// protocol can cause issues when the client is
> behind a corporate firewall; https:// works in pretty much
> any scenario, and these days it's basically as efficient.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  xml_test.go | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list