From nobody Sat May 4 22:50:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1525959842267626.8249168394525; Thu, 10 May 2018 06:44:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F364230B27AA; Thu, 10 May 2018 13:43:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C967430012B4; Thu, 10 May 2018 13:43:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 77D971801242; Thu, 10 May 2018 13:43:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4ADhruI017000 for ; Thu, 10 May 2018 09:43:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id D08F763F3E; Thu, 10 May 2018 13:43:53 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74EB463F37 for ; Thu, 10 May 2018 13:43:51 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 10 May 2018 15:43:47 +0200 Message-Id: <20180510134347.32574-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [go-xml PATCH] test: Clone libvirt.git via https:// instead of git:// X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 10 May 2018 13:44:00 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The git:// protocol can cause issues when the client is behind a corporate firewall; https:// works in pretty much any scenario, and these days it's basically as efficient. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- xml_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml_test.go b/xml_test.go index dcec589..2a2e16f 100644 --- a/xml_test.go +++ b/xml_test.go @@ -388,7 +388,7 @@ func syncGit(t *testing.T) { _, err :=3D os.Stat("testdata/libvirt/tests") if err !=3D nil { if os.IsNotExist(err) { - msg, err :=3D exec.Command("git", "clone", "--depth", "1", "git://libvi= rt.org/libvirt.git", "testdata/libvirt").CombinedOutput() + msg, err :=3D exec.Command("git", "clone", "--depth", "1", "https://lib= virt.org/git/libvirt.git", "testdata/libvirt").CombinedOutput() if err !=3D nil { t.Fatal(fmt.Errorf("Unable to clone libvirt.git: %s: %s", err, msg)) } --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list