1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

Maciej Wolny posted 1 patch 5 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180501134919.13442-1-maciej.wolny@codethink.co.uk
Test syntax-check passed
There is a newer version of this series
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
Posted by Maciej Wolny 5 years, 11 months ago 
Fixes "can't find libtool" error when running valgrind checks.
---
 tests/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7b93fbde6..05db6b119 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
 	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
 	--suppressions=$(srcdir)/.valgrind.supp
 valgrind:
-	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
+	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
 
 sockettest_SOURCES = \
 	sockettest.c \
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
Posted by Andrea Bolognani 5 years, 11 months ago 
On Tue, 2018-05-01 at 14:49 +0100, Maciej Wolny wrote:
> Fixes "can't find libtool" error when running valgrind checks.
> ---
>  tests/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 7b93fbde6..05db6b119 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
>  	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
>  	--suppressions=$(srcdir)/.valgrind.supp
>  valgrind:
> -	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
> +	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
>  
>  sockettest_SOURCES = \
>  	sockettest.c \

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

We're in development freeze now, so I'll push this after release.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
Posted by Andrea Bolognani 5 years, 11 months ago 
On Wed, 2018-05-02 at 12:24 +0200, Andrea Bolognani wrote:
> On Tue, 2018-05-01 at 14:49 +0100, Maciej Wolny wrote:
> > Fixes "can't find libtool" error when running valgrind checks.
> > ---
> >  tests/Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index 7b93fbde6..05db6b119 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
> >  	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
> >  	--suppressions=$(srcdir)/.valgrind.supp
> >  valgrind:
> > -	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
> > +	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
> >  
> >  sockettest_SOURCES = \
> >  	sockettest.c \
> 
>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> We're in development freeze now, so I'll push this after release.

Sorry, I forgot to mention the fact that libvirt requires a
Signed-off-by for all contributions these days... So you're going
to have to provide that before I can push your patch.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
Posted by Maciej Wolny 5 years, 11 months ago 
On 02/05/18 17:15, Andrea Bolognani wrote:
> On Wed, 2018-05-02 at 12:24 +0200, Andrea Bolognani wrote:
>> On Tue, 2018-05-01 at 14:49 +0100, Maciej Wolny wrote:
>>> Fixes "can't find libtool" error when running valgrind checks.
>>> ---
>>>  tests/Makefile.am | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>>> index 7b93fbde6..05db6b119 100644
>>> --- a/tests/Makefile.am
>>> +++ b/tests/Makefile.am
>>> @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
>>>  	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
>>>  	--suppressions=$(srcdir)/.valgrind.supp
>>>  valgrind:
>>> -	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
>>> +	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
>>>  
>>>  sockettest_SOURCES = \
>>>  	sockettest.c \
>>
>>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>
>>
>> We're in development freeze now, so I'll push this after release.
> 
> Sorry, I forgot to mention the fact that libvirt requires a
> Signed-off-by for all contributions these days... So you're going
> to have to provide that before I can push your patch.
> 

Hah, no problem, hopefully PATCH v4 will be the last one. :)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.