[libvirt] [PATCH v4] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

Maciej Wolny posted 1 patch 5 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180502165408.4084-1-maciej.wolny@codethink.co.uk
Test syntax-check passed
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH v4] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
Posted by Maciej Wolny 5 years, 11 months ago
Fixes "can't find libtool" error when running valgrind checks.

Signed-off-by: Maciej Wolny <maciej.wolny@codethink.co.uk>
---
 tests/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7b93fbde6..05db6b119 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
 	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
 	--suppressions=$(srcdir)/.valgrind.supp
 valgrind:
-	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
+	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
 
 sockettest_SOURCES = \
 	sockettest.c \
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v4] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
Posted by Andrea Bolognani 5 years, 11 months ago
On Wed, 2018-05-02 at 17:54 +0100, Maciej Wolny wrote:
> Fixes "can't find libtool" error when running valgrind checks.
> 
> Signed-off-by: Maciej Wolny <maciej.wolny@codethink.co.uk>
> ---
>  tests/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 7b93fbde6..05db6b119 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
>  	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
>  	--suppressions=$(srcdir)/.valgrind.supp
>  valgrind:
> -	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
> +	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
>  
>  sockettest_SOURCES = \
>  	sockettest.c \

Pushed. Congratulations on your first contribution to libvirt :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list