virsh: Fix --nvram and --keep-nvram help strings

[PATCH] virsh: Fix --nvram and --keep-nvram help strings

Michal Privoznik posted 1 patch 2 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1440e30455d9dc0c6287483a7030be3b54c049c7.1633071952.git.mprivozn@redhat.com

tools/virsh-domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] virsh: Fix --nvram and --keep-nvram help strings

Posted by Michal Privoznik 2 years, 7 months ago

The --nvram and --keep-nvram options of the undefine command can
be used regardless of the domain status (the only consumer so far
- qemuDomainUndefineFlags() doesn't care about the domain
status). Yet, their corresponding help strings say something
about inactive domains while manpage says nothing. Remove the
reference to domain state.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2007659
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tools/virsh-domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 0b78fbf728..f73d9a057e 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -3595,11 +3595,11 @@ static const vshCmdOptDef opts_undefine[] = {
     },
     {.name = "nvram",
      .type = VSH_OT_BOOL,
-     .help = N_("remove nvram file, if inactive")
+     .help = N_("remove nvram file")
     },
     {.name = "keep-nvram",
      .type = VSH_OT_BOOL,
-     .help = N_("keep nvram file, if inactive")
+     .help = N_("keep nvram file")
     },
     {.name = NULL}
 };
-- 
2.32.0

Re: [PATCH] virsh: Fix --nvram and --keep-nvram help strings

Posted by Andrea Bolognani 2 years, 7 months ago

On Fri, Oct 01, 2021 at 09:05:52AM +0200, Michal Privoznik wrote:
> The --nvram and --keep-nvram options of the undefine command can
> be used regardless of the domain status (the only consumer so far
> - qemuDomainUndefineFlags() doesn't care about the domain
> status). Yet, their corresponding help strings say something
> about inactive domains while manpage says nothing. Remove the
> reference to domain state.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2007659
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tools/virsh-domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization