From nobody Sun May 19 05:00:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633071977; cv=none; d=zohomail.com; s=zohoarc; b=YUSUoILYqVhlRyfI9GXeiboAsla98duGifNNfC0usY8IweoZaZlZ/3BuWOWItaXHvABYvuSkDv0ceYkNdfVJ/QUMNzNJOQmv5dmqUDESeRkwnxplU+7adKCjRXXW95iilmpkJx1rhNkefdjUXlY5Nx0N27yKNyCls+TlspTMhf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633071977; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=osLq2Fpg5v1P94XkzrahbnZl6zU7d89HoDbpos2gnUs=; b=kH/u/NZm7w/4aigWVITCRexOxVNNmaPW4KwHTAijVojwIRI10gi+0+PYWW1iXz83QSj0ddDSbH6OGL2bLZ1r0R0tO1f+6RiLUTeQy2YFvmPBFOpPYQHlNGgJ03bTcuUoaZ3bZk2zpNHaZARyUcLUO70OeMOuT5Fhc6nr3+Bcsn8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1633071977981697.6857514889781; Fri, 1 Oct 2021 00:06:17 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-tvf22-uINP-rcXfRKn9aOQ-1; Fri, 01 Oct 2021 03:06:15 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB93D10168C0; Fri, 1 Oct 2021 07:06:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFB1819C59; Fri, 1 Oct 2021 07:06:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C0B3A1803B30; Fri, 1 Oct 2021 07:06:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 191760WZ008329 for ; Fri, 1 Oct 2021 03:06:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id CF5EB5C1CF; Fri, 1 Oct 2021 07:06:00 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.93]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A0675C1C5 for ; Fri, 1 Oct 2021 07:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633071976; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=osLq2Fpg5v1P94XkzrahbnZl6zU7d89HoDbpos2gnUs=; b=hYb+CRVqTOgYtNQKlGVolvQN1s0eL/WBKcHFS1yAAHg/t77SekmRXa3tm56ld+NTnhIEeN TYEfRCNsvSamqp+c0l723UF+kPD2+GBHwLTGEruTRoBMUXWjH5YOEFf2qO4uvV7QYx2MSY 4o3tTO/+1MYXR9BqOCjXfma892PCaKU= X-MC-Unique: tvf22-uINP-rcXfRKn9aOQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] virsh: Fix --nvram and --keep-nvram help strings Date: Fri, 1 Oct 2021 09:05:52 +0200 Message-Id: <1440e30455d9dc0c6287483a7030be3b54c049c7.1633071952.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633071979938100001 Content-Type: text/plain; charset="utf-8" The --nvram and --keep-nvram options of the undefine command can be used regardless of the domain status (the only consumer so far - qemuDomainUndefineFlags() doesn't care about the domain status). Yet, their corresponding help strings say something about inactive domains while manpage says nothing. Remove the reference to domain state. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2007659 Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0b78fbf728..f73d9a057e 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -3595,11 +3595,11 @@ static const vshCmdOptDef opts_undefine[] =3D { }, {.name =3D "nvram", .type =3D VSH_OT_BOOL, - .help =3D N_("remove nvram file, if inactive") + .help =3D N_("remove nvram file") }, {.name =3D "keep-nvram", .type =3D VSH_OT_BOOL, - .help =3D N_("keep nvram file, if inactive") + .help =3D N_("keep nvram file") }, {.name =3D NULL} }; --=20 2.32.0