MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue

[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue

Ranbir Singh via groups.io posted 1 patch 1 year, 4 months ago

Download mbox

Failed in applying to current master (apply log)

MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ----
1 file changed, 4 deletions(-)

Expand all Fold all

[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue

Posted by Ranbir Singh via groups.io 1 year, 4 months ago

The code can reach line 65 only through the else path above at line 53.
The else path already has the same NULL check at line 55 and hence the
duplicate code lines are totally redundant which can be deleted.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4220
Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com>
---
MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
index d704c62eaa..1d03d49640 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
@@ -62,10 +62,6 @@ NvmeS3SkipThisController (
}
}

-  if (S3InitDevices == NULL) {
-    return Skip;
-  }
-
//
// Only need to initialize the controllers that exist in the device list.
//
--
2.36.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97921): https://edk2.groups.io/g/devel/message/97921
Mute This Topic: https://groups.io/mt/96046337/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-