From nobody Sat May 18 19:48:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97921+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97921+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1672817542; cv=none; d=zohomail.com; s=zohoarc; b=XLofK68FbBLfjqduwJAJt/vOainoDd3PiBShjPC51Q4NCJ6uczaqZPbagVpSDTBwyrupyN/x9hY43/H6oAEGwG5bYtzSvDrWKXP9z+j+iEzHvj/msu1TAomY/JJJ0fxemcGHoAiDfGKpeVCyEecuwahAZ0v4nRc/NyAPJMSUVOE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672817542; h=Content-Type:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=6w+VtlYH+9aH13OrpiTwqBt7Qp+mQ+zS5spX4Cyjyu4=; b=fqQlBzs+sqw/UCWUzxz1+HTlZJIZYKPM2x42abfCb70j4MM/OwKJevKhDsVVX/QngIQTzTiivfM1JbRjIDg5e4b++jca7Nf1xJWJDBVGJzZgsbckRYSZJVpsJdQQsLiH9Sc6ss1THlgS0ohTJZHlQON5Hv+85HQQ4zeBPKlcEoE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97921+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1672817542691965.564988764065; Tue, 3 Jan 2023 23:32:22 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id CFYaYY1788612x3vM81kWbDY; Tue, 03 Jan 2023 23:32:22 -0800 Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue To: devel@edk2.groups.io From: "Ranbir Singh via groups.io" X-Originating-Location: Bengaluru, Karnataka, IN (122.172.85.38) X-Originating-Platform: Windows Chrome 108 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Tue, 03 Jan 2023 23:32:22 -0800 Message-ID: Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Ranbir.Singh3@Dell.com X-Gm-Message-State: 6mPiogODTAY8BnDvMXs6d8Gix1787277AA= Content-Type: multipart/alternative; boundary="zZL2VnmKsk8zjHhCvR6b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1672817542; bh=77FX+YKjfiCLix8xdTvXoLHdhdbjDrPXPbtY1tiJLkE=; h=Content-Type:Date:From:Reply-To:Subject:To; b=E/mMS8wkM4pJNo+843d+gbJTDJ8Hta4HNeuYn3AoQ+7YYTku7y6Abcz36PHMmGZRc4w KCE8+1arfvgcskUSen2+NZl0mAkB+wC7ziBA5lTHK+jvcIQTsd3jMP9tuauYXtwkpygAM 2Aw50LkGmtr0uAZtMX0jwwmNodLnkthJvq0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1672817543094100001 --zZL2VnmKsk8zjHhCvR6b Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 The code can reach line 65 only through the else path above at line 53. The else path already has the same NULL check at line 55 and hence the duplicate code lines are totally redundant which can be deleted. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4220 Signed-off-by: Ranbir Singh --- MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c b/MdeModu= lePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c index d704c62eaa..1d03d49640 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c @@ -62,10 +62,6 @@ NvmeS3SkipThisController ( } } -=C2=A0 if (S3InitDevices =3D=3D NULL) { -=C2=A0 =C2=A0 return Skip; -=C2=A0 } - // // Only need to initialize the controllers that exist in the device list. // -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97921): https://edk2.groups.io/g/devel/message/97921 Mute This Topic: https://groups.io/mt/96046337/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --zZL2VnmKsk8zjHhCvR6b Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
The code can reach line 65 only through the else path above at line 53= .
The else path already has the same NULL check at line 55 and hence the=
duplicate code lines are totally redundant which can be deleted.
 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4220
Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com>
---
 MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ----
 1 file changed, 4 deletions(-)
 
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c b/Md= eModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
index d704c62eaa..1d03d49640 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c
@@ -62,10 +62,6 @@ NvmeS3SkipThisController (
     }
   }
 
-  if (S3InitDevices =3D=3D NULL) {
-    return Skip;
-  }
-
   //
   // Only need to initialize the controllers that exist in = the device list.
   //
--
2.36.1.windows.1
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

= View/Reply Online (#97921) | =20 | Mute = This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [importer@patchew.org]

_._,_._,_
--zZL2VnmKsk8zjHhCvR6b--