1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] Get HobListPtr before calling the Multiphase FSPS

kurugodx posted 1 patch 10 months, 3 weeks ago
Failed in applying to current master (apply log)
.../FspsWrapperPeim/FspsWrapperPeim.c             | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
[edk2-devel] [PATCH] Get HobListPtr before calling the Multiphase FSPS
Posted by kurugodx 10 months, 3 weeks ago 
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480

In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler
and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so
that BL will be able to get the correct FspHobListPtr value

Signed-off-by: kurugodx <kurugodumelmatamx.aishwarya@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Chen Gang C <gang.c.chen@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
---
 .../FspsWrapperPeim/FspsWrapperPeim.c             | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 08fe0fdb7e..1d4dd60577 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify (
 
   DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status));
 
+  //
+  // Get FspHobList
+  //
+  GuidHob = GetFirstGuidHob (&gFspHobGuid);
+  ASSERT (GuidHob != NULL);
+  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
+  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
+
   if (Status == FSP_STATUS_VARIABLE_REQUEST) {
     //
     // call to Variable request handler
@@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify (
     DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status = %r\n", Status));
   }
 
-  //
-  // Now FspHobList complete, process it
-  //
-  GuidHob = GetFirstGuidHob (&gFspHobGuid);
-  ASSERT (GuidHob != NULL);
-  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
-  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
   PostFspsHobProcess (FspHobListPtr);
 
   //
-- 
2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105984): https://edk2.groups.io/g/devel/message/105984
Mute This Topic: https://groups.io/mt/99428705/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] Get HobListPtr before calling the Multiphase FSPS
Posted by Chiu, Chasel 10 months, 3 weeks ago 
Please update the subject per format requirement -
    PackageName: title

With this update, Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel


> -----Original Message-----
> From: Aishwarya, KurugoduMelmatamX
> <kurugodumelmatamx.aishwarya@intel.com>
> Sent: Friday, June 9, 2023 6:40 AM
> To: devel@edk2.groups.io
> Cc: Aishwarya, KurugoduMelmatamX
> <kurugodumelmatamx.aishwarya@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B
> <chinni.b.duggapu@intel.com>; Chen, Gang C <gang.c.chen@intel.com>; Zeng,
> Star <star.zeng@intel.com>; Kuo, Ted <ted.kuo@intel.com>; S, Ashraf Ali
> <ashraf.ali.s@intel.com>; Mohapatra, Susovan
> <susovan.mohapatra@intel.com>
> Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS
> 
> REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480
> 
> In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and
> FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will
> be able to get the correct FspHobListPtr value
> 
> Signed-off-by: kurugodx <kurugodumelmatamx.aishwarya@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Chen Gang C <gang.c.chen@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> ---
>  .../FspsWrapperPeim/FspsWrapperPeim.c             | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 08fe0fdb7e..1d4dd60577 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify (
> 
>    DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status));
> 
> +  //
> +  // Get FspHobList
> +  //
> +  GuidHob = GetFirstGuidHob (&gFspHobGuid);  ASSERT (GuidHob != NULL);
> + FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);  DEBUG
> + ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
> +
>    if (Status == FSP_STATUS_VARIABLE_REQUEST) {
>      //
>      // call to Variable request handler @@ -356,13 +364,6 @@
> PeiMemoryDiscoveredNotify (
>      DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status
> = %r\n", Status));
>    }
> 
> -  //
> -  // Now FspHobList complete, process it
> -  //
> -  GuidHob = GetFirstGuidHob (&gFspHobGuid);
> -  ASSERT (GuidHob != NULL);
> -  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
> -  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
>    PostFspsHobProcess (FspHobListPtr);
> 
>    //
> --
> 2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105978): https://edk2.groups.io/g/devel/message/105978
Mute This Topic: https://groups.io/mt/99428705/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] Get HobListPtr before calling the Multiphase FSPS
Posted by Ashraf Ali S 10 months, 3 weeks ago 
Reviewed-by: Ashraf Ali S <ashraf.ali.s@intel.com>

-----Original Message-----
From: Aishwarya, KurugoduMelmatamX <kurugodumelmatamx.aishwarya@intel.com> 
Sent: Friday, June 9, 2023 7:10 PM
To: devel@edk2.groups.io
Cc: Aishwarya, KurugoduMelmatamX <kurugodumelmatamx.aishwarya@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>; Chen, Gang C <gang.c.chen@intel.com>; Zeng, Star <star.zeng@intel.com>; Kuo, Ted <ted.kuo@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>; Mohapatra, Susovan <susovan.mohapatra@intel.com>
Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS

REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480

In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will be able to get the correct FspHobListPtr value

Signed-off-by: kurugodx <kurugodumelmatamx.aishwarya@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Chen Gang C <gang.c.chen@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
---
 .../FspsWrapperPeim/FspsWrapperPeim.c             | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 08fe0fdb7e..1d4dd60577 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify (
 
   DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status));
 
+  //
+  // Get FspHobList
+  //
+  GuidHob = GetFirstGuidHob (&gFspHobGuid);  ASSERT (GuidHob != NULL);  
+ FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);  DEBUG 
+ ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
+
   if (Status == FSP_STATUS_VARIABLE_REQUEST) {
     //
     // call to Variable request handler @@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify (
     DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status = %r\n", Status));
   }
 
-  //
-  // Now FspHobList complete, process it
-  //
-  GuidHob = GetFirstGuidHob (&gFspHobGuid);
-  ASSERT (GuidHob != NULL);
-  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
-  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
   PostFspsHobProcess (FspHobListPtr);
 
   //
--
2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105972): https://edk2.groups.io/g/devel/message/105972
Mute This Topic: https://groups.io/mt/99428705/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.