From nobody Fri May 17 06:07:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105984+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105984+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1686328588; cv=none; d=zohomail.com; s=zohoarc; b=oDk9VaVNospfwx9A3PrMTmvo9r+RIU7IeKaAVhIHp/0uSn/8Ysg0U13Nd1tppbBv/kOZHOGk1yyYSaQEdpKQLyImOzjcI3IVqeXweujTKHYbC45VhLDiO1uaho5qCjLoJfSj4mFPM2vtmkXZA30t70YpWZ6FCbuc0copln2nCE4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686328588; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=GEZSpviod7mkduNWdCb1SJY/MbdXq+uS/wqdGatu4to=; b=jclpVcXzedKzjqcC398JGP3gCRbtCGq7BPfNQnkl1JZEn3wXn7bcHYsU+zVIG8hQGRcmMZChNuMSOW73I8ob6QJnFKYxAJcqlz8bTn6y8ltXaNXqlXdJ2IlADagMsUOmSyam/nCfFEN4ATmKdWM+nN8i4Kth7gXj9yfqzBQQH08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105984+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1686328588525509.55944315278043; Fri, 9 Jun 2023 09:36:28 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PvqHYY1788612xncPd8QPMyg; Fri, 09 Jun 2023 09:36:28 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.13660.1686317991310394256 for ; Fri, 09 Jun 2023 06:39:51 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="342275232" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="342275232" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 06:39:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="713519965" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="713519965" X-Received: from kurugodx-desk.gar.corp.intel.com ([10.66.234.59]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 06:39:47 -0700 From: kurugodx To: devel@edk2.groups.io Cc: kurugodx , Chasel Chiu , Nate DeSimone , Duggapu Chinni B , Chen Gang C , Star Zeng , Ted Kuo , Ashraf Ali S , Susovan Mohapatra Subject: [edk2-devel] [PATCH] Get HobListPtr before calling the Multiphase FSPS Date: Fri, 9 Jun 2023 06:39:41 -0700 Message-ID: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kurugodumelmatamx.aishwarya@intel.com X-Gm-Message-State: GUGsQOWkPptVx45VqGzWKe8Zx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1686328588; bh=T9cy8+YqEpQSzhpgQLQf7/cuGY5ly9ARAlYQZWU59to=; h=Cc:Date:From:Reply-To:Subject:To; b=hNiWGXkPuNr1T1cRxS2odA8YzxYy1NlO3j6Z/xCwDJ3VKUtJqr8S7VFgMT3SLm/+hbo 3rtyU9AeKGlsFGlMK3ogVO4POI/a6x4sHDw2bxqoLkeTSUn99nfnh6cXRTpQvJ4a1aF9b /ushvRFdPvPc3Z4iQ01MqZwcPxdTtR160pA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1686328589539100009 Content-Type: text/plain; charset="utf-8" REF : https://bugzilla.tianocore.org/show_bug.cgi?id=3D4480 In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will be able to get the correct FspHobListPtr value Signed-off-by: kurugodx Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Chen Gang C Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra Reviewed-by: Ashraf Ali S --- .../FspsWrapperPeim/FspsWrapperPeim.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelF= sp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c index 08fe0fdb7e..1d4dd60577 100644 --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify ( =20 DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status)); =20 + // + // Get FspHobList + // + GuidHob =3D GetFirstGuidHob (&gFspHobGuid); + ASSERT (GuidHob !=3D NULL); + FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); + DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); + if (Status =3D=3D FSP_STATUS_VARIABLE_REQUEST) { // // call to Variable request handler @@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify ( DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Sta= tus =3D %r\n", Status)); } =20 - // - // Now FspHobList complete, process it - // - GuidHob =3D GetFirstGuidHob (&gFspHobGuid); - ASSERT (GuidHob !=3D NULL); - FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); - DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); PostFspsHobProcess (FspHobListPtr); =20 // --=20 2.41.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105984): https://edk2.groups.io/g/devel/message/105984 Mute This Topic: https://groups.io/mt/99428705/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-