[v5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging

[edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging

Posted by Zhiguang Liu 11 months, 4 weeks ago

This patch set simplify the page table creation code, remove some
hard-code, combine files and support 5 Level paging.

V4:
Refine comments and update below macro names:
PG_NLE -> PAGE_NLE
PTE_2MB -> PDE_2MB
PDP_1G -> PDPTE_1GB
PAGE_BLP_ATTR -> PAGE_BLE_ATTR

No code logic impact

V5:
Update below macro names:
PDE_2MB -> PAGE_PDE_2MB
PDPTE_1GB -> PAGE_PDPTE_1GB

No code logic impact

Zhiguang Liu (5):
  UefiCpuPkg/ResetVector: Rename macros about page table.
  UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector
  UefiCpuPkg/ResetVector: Combine PageTables1G.asm and PageTables2M.asm
  UefiCpuPkg/ResetVector: Modify Page Table in ResetVector
  UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector

 .../ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm  | 25 ++++-
 .../ResetVector/Vtf0/Ia32/PageTables64.asm    | 24 -----
 UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb        |  9 +-
 .../ResetVector/Vtf0/X64/PageTables.asm       | 93 +++++++++++++++++++
 .../ResetVector/Vtf0/X64/PageTables1G.asm     | 53 -----------
 .../ResetVector/Vtf0/X64/PageTables2M.asm     | 60 ------------
 6 files changed, 118 insertions(+), 146 deletions(-)
 delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Ia32/PageTables64.asm
 create mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm
 delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables1G.asm
 delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables2M.asm

-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104256): https://edk2.groups.io/g/devel/message/104256
Mute This Topic: https://groups.io/mt/98756994/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging

Posted by Ni, Ray 11 months, 3 weeks ago

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhiguang
> Liu
> Sent: Monday, May 8, 2023 4:15 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page
> table creation, and support 5 Level paging
> 
> This patch set simplify the page table creation code, remove some
> hard-code, combine files and support 5 Level paging.
> 
> V4:
> Refine comments and update below macro names:
> PG_NLE -> PAGE_NLE
> PTE_2MB -> PDE_2MB
> PDP_1G -> PDPTE_1GB
> PAGE_BLP_ATTR -> PAGE_BLE_ATTR
> 
> No code logic impact
> 
> V5:
> Update below macro names:
> PDE_2MB -> PAGE_PDE_2MB
> PDPTE_1GB -> PAGE_PDPTE_1GB
> 
> No code logic impact
> 
> Zhiguang Liu (5):
>   UefiCpuPkg/ResetVector: Rename macros about page table.
>   UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector
>   UefiCpuPkg/ResetVector: Combine PageTables1G.asm and PageTables2M.asm
>   UefiCpuPkg/ResetVector: Modify Page Table in ResetVector
>   UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector
> 
>  .../ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm  | 25 ++++-
>  .../ResetVector/Vtf0/Ia32/PageTables64.asm    | 24 -----
>  UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb        |  9 +-
>  .../ResetVector/Vtf0/X64/PageTables.asm       | 93 +++++++++++++++++++
>  .../ResetVector/Vtf0/X64/PageTables1G.asm     | 53 -----------
>  .../ResetVector/Vtf0/X64/PageTables2M.asm     | 60 ------------
>  6 files changed, 118 insertions(+), 146 deletions(-)
>  delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Ia32/PageTables64.asm
>  create mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm
>  delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables1G.asm
>  delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables2M.asm
> 
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104466): https://edk2.groups.io/g/devel/message/104466
Mute This Topic: https://groups.io/mt/98756994/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging

Posted by Gerd Hoffmann 11 months, 3 weeks ago

On Mon, May 08, 2023 at 04:14:59PM +0800, Zhiguang Liu wrote:
> This patch set simplify the page table creation code, remove some
> hard-code, combine files and support 5 Level paging.
> 
> V4:
> Refine comments and update below macro names:
> PG_NLE -> PAGE_NLE
> PTE_2MB -> PDE_2MB
> PDP_1G -> PDPTE_1GB
> PAGE_BLP_ATTR -> PAGE_BLE_ATTR
> 
> No code logic impact
> 
> V5:
> Update below macro names:
> PDE_2MB -> PAGE_PDE_2MB
> PDPTE_1GB -> PAGE_PDPTE_1GB
> 
> No code logic impact
> 
> Zhiguang Liu (5):
>   UefiCpuPkg/ResetVector: Rename macros about page table.
>   UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector
>   UefiCpuPkg/ResetVector: Combine PageTables1G.asm and PageTables2M.asm
>   UefiCpuPkg/ResetVector: Modify Page Table in ResetVector
>   UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector

Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104392): https://edk2.groups.io/g/devel/message/104392
Mute This Topic: https://groups.io/mt/98756994/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging

Posted by Zhiguang Liu 11 months, 3 weeks ago

Thanks Gerd for helping test.

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, May 9, 2023 11:38 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: Re: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine
> page table creation, and support 5 Level paging
> 
> On Mon, May 08, 2023 at 04:14:59PM +0800, Zhiguang Liu wrote:
> > This patch set simplify the page table creation code, remove some
> > hard-code, combine files and support 5 Level paging.
> >
> > V4:
> > Refine comments and update below macro names:
> > PG_NLE -> PAGE_NLE
> > PTE_2MB -> PDE_2MB
> > PDP_1G -> PDPTE_1GB
> > PAGE_BLP_ATTR -> PAGE_BLE_ATTR
> >
> > No code logic impact
> >
> > V5:
> > Update below macro names:
> > PDE_2MB -> PAGE_PDE_2MB
> > PDPTE_1GB -> PAGE_PDPTE_1GB
> >
> > No code logic impact
> >
> > Zhiguang Liu (5):
> >   UefiCpuPkg/ResetVector: Rename macros about page table.
> >   UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector
> >   UefiCpuPkg/ResetVector: Combine PageTables1G.asm and
> PageTables2M.asm
> >   UefiCpuPkg/ResetVector: Modify Page Table in ResetVector
> >   UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector
> 
> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104449): https://edk2.groups.io/g/devel/message/104449
Mute This Topic: https://groups.io/mt/98756994/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-