[v2] IPMI changes for Redfish

[edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish

Posted by Chang, Abner via groups.io 1 year, 4 months ago

From: Abner Chang <abner.chang@amd.com>

This patch updates IPMI related definitions for supporting
Redfish Host interface Credential bootstrapping spec and
building up SMBIOS 42 record for the USB NIC host
interface exposed by BMC.
The corresponding updates on IpmiFeaturePkg is in the
separate pacth for edk2-platforms.

This is the part I of upstream, the follow up patche sets are:
- RedfishPlatformCredentialLib contributed by NVidia.
- Relocate IpmiCommandLib.h from edk2-platforms
  to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
  and located under MdePkg. With above, RedfishPkg doesn't have the
  dependence with edk2-platforms. The implementation of IpmiCommandLib
  stays in edk2-platforms without relocation, which can be pulled in
  to platform DSC as needed.
- PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
  temporarily because some requirements are necessray to be spec out
  in the Redfish section in UEFI spec.

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Abner Chang (3):
  MdePkg/IndustryStandard: Update IPMI definitions
  RedfishPkg/Include: Add Redfish IPMI definitions
  RedfishPkg/Include: Redfish USB Interface V2 update

 MdePkg/Include/IndustryStandard/Ipmi.h        | 17 +++++++
 .../Include/IndustryStandard/IpmiNetFnApp.h   | 37 ++++++++++++--
 .../IndustryStandard/IpmiNetFnTransport.h     | 32 ++++++++++++
 .../IndustryStandard/RedfishHostInterface.h   | 25 +++++++++-
 .../RedfishHostInterfaceIpmi.h                | 50 +++++++++++++++++++
 5 files changed, 156 insertions(+), 5 deletions(-)
 create mode 100644 RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h

-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97773): https://edk2.groups.io/g/devel/message/97773
Mute This Topic: https://groups.io/mt/95915832/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish

Posted by Michael D Kinney 1 year, 4 months ago

Hi Abner,

Can you provide an overview of the RedFish features that are required to interact with
HW interfaces such as USB and IPMI and network services?

I am wondering if these can be abstracted through dynamic interfaces such as PPI/Protocol
instead of static interfaces such as library classes.  It may help provide more options
on where the Device/Platform specific sources are hosted. 

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Tuesday, December 27, 2022 9:14 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> This patch updates IPMI related definitions for supporting
> Redfish Host interface Credential bootstrapping spec and
> building up SMBIOS 42 record for the USB NIC host
> interface exposed by BMC.
> The corresponding updates on IpmiFeaturePkg is in the
> separate pacth for edk2-platforms.
> 
> This is the part I of upstream, the follow up patche sets are:
> - RedfishPlatformCredentialLib contributed by NVidia.
> - Relocate IpmiCommandLib.h from edk2-platforms
>   to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
>   and located under MdePkg. With above, RedfishPkg doesn't have the
>   dependence with edk2-platforms. The implementation of IpmiCommandLib
>   stays in edk2-platforms without relocation, which can be pulled in
>   to platform DSC as needed.
> - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
>   temporarily because some requirements are necessray to be spec out
>   in the Redfish section in UEFI spec.
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Abner Chang (3):
>   MdePkg/IndustryStandard: Update IPMI definitions
>   RedfishPkg/Include: Add Redfish IPMI definitions
>   RedfishPkg/Include: Redfish USB Interface V2 update
> 
>  MdePkg/Include/IndustryStandard/Ipmi.h        | 17 +++++++
>  .../Include/IndustryStandard/IpmiNetFnApp.h   | 37 ++++++++++++--
>  .../IndustryStandard/IpmiNetFnTransport.h     | 32 ++++++++++++
>  .../IndustryStandard/RedfishHostInterface.h   | 25 +++++++++-
>  .../RedfishHostInterfaceIpmi.h                | 50 +++++++++++++++++++
>  5 files changed, 156 insertions(+), 5 deletions(-)
>  create mode 100644 RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
> 
> --
> 2.37.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97809): https://edk2.groups.io/g/devel/message/97809
Mute This Topic: https://groups.io/mt/95915832/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish

Posted by Chang, Abner via groups.io 1 year, 3 months ago

[AMD Official Use Only - General]

Hi Mike and all,
Please check here: https://github.com/changab/edk2-staging/tree/RedfishReadme/RedfishPkg#platform-components for the overview of Redfish-Network-USBNIC-IPMI.

Thanks
Abner

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, December 30, 2022 1:37 AM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
> Can you provide an overview of the RedFish features that are required to
> interact with HW interfaces such as USB and IPMI and network services?
> 
> I am wondering if these can be abstracted through dynamic interfaces such
> as PPI/Protocol instead of static interfaces such as library classes.  It may help
> provide more options on where the Device/Platform specific sources are
> hosted.
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Tuesday, December 27, 2022 9:14 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>;
> > Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>
> > Subject: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > This patch updates IPMI related definitions for supporting Redfish
> > Host interface Credential bootstrapping spec and building up SMBIOS 42
> > record for the USB NIC host interface exposed by BMC.
> > The corresponding updates on IpmiFeaturePkg is in the separate pacth
> > for edk2-platforms.
> >
> > This is the part I of upstream, the follow up patche sets are:
> > - RedfishPlatformCredentialLib contributed by NVidia.
> > - Relocate IpmiCommandLib.h from edk2-platforms
> >   to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
> >   and located under MdePkg. With above, RedfishPkg doesn't have the
> >   dependence with edk2-platforms. The implementation of
> IpmiCommandLib
> >   stays in edk2-platforms without relocation, which can be pulled in
> >   to platform DSC as needed.
> > - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
> >   temporarily because some requirements are necessray to be spec out
> >   in the Redfish section in UEFI spec.
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> >
> > Abner Chang (3):
> >   MdePkg/IndustryStandard: Update IPMI definitions
> >   RedfishPkg/Include: Add Redfish IPMI definitions
> >   RedfishPkg/Include: Redfish USB Interface V2 update
> >
> >  MdePkg/Include/IndustryStandard/Ipmi.h        | 17 +++++++
> >  .../Include/IndustryStandard/IpmiNetFnApp.h   | 37 ++++++++++++--
> >  .../IndustryStandard/IpmiNetFnTransport.h     | 32 ++++++++++++
> >  .../IndustryStandard/RedfishHostInterface.h   | 25 +++++++++-
> >  .../RedfishHostInterfaceIpmi.h                | 50 +++++++++++++++++++
> >  5 files changed, 156 insertions(+), 5 deletions(-)  create mode
> > 100644 RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
> >
> > --
> > 2.37.1.windows.1
> >
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98155): https://edk2.groups.io/g/devel/message/98155
Mute This Topic: https://groups.io/mt/95915832/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish

Posted by Chang, Abner via groups.io 1 year, 4 months ago

[AMD Official Use Only - General]

Sure, I am glad to provide the overview of edk2 Redfish feature.

Abner

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, December 30, 2022 1:37 AM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
> Can you provide an overview of the RedFish features that are required to
> interact with HW interfaces such as USB and IPMI and network services?
> 
> I am wondering if these can be abstracted through dynamic interfaces such
> as PPI/Protocol instead of static interfaces such as library classes.  It may help
> provide more options on where the Device/Platform specific sources are
> hosted.
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Tuesday, December 27, 2022 9:14 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>;
> > Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>
> > Subject: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > This patch updates IPMI related definitions for supporting Redfish
> > Host interface Credential bootstrapping spec and building up SMBIOS 42
> > record for the USB NIC host interface exposed by BMC.
> > The corresponding updates on IpmiFeaturePkg is in the separate pacth
> > for edk2-platforms.
> >
> > This is the part I of upstream, the follow up patche sets are:
> > - RedfishPlatformCredentialLib contributed by NVidia.
> > - Relocate IpmiCommandLib.h from edk2-platforms
> >   to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
> >   and located under MdePkg. With above, RedfishPkg doesn't have the
> >   dependence with edk2-platforms. The implementation of
> IpmiCommandLib
> >   stays in edk2-platforms without relocation, which can be pulled in
> >   to platform DSC as needed.
> > - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
> >   temporarily because some requirements are necessray to be spec out
> >   in the Redfish section in UEFI spec.
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> >
> > Abner Chang (3):
> >   MdePkg/IndustryStandard: Update IPMI definitions
> >   RedfishPkg/Include: Add Redfish IPMI definitions
> >   RedfishPkg/Include: Redfish USB Interface V2 update
> >
> >  MdePkg/Include/IndustryStandard/Ipmi.h        | 17 +++++++
> >  .../Include/IndustryStandard/IpmiNetFnApp.h   | 37 ++++++++++++--
> >  .../IndustryStandard/IpmiNetFnTransport.h     | 32 ++++++++++++
> >  .../IndustryStandard/RedfishHostInterface.h   | 25 +++++++++-
> >  .../RedfishHostInterfaceIpmi.h                | 50 +++++++++++++++++++
> >  5 files changed, 156 insertions(+), 5 deletions(-)  create mode
> > 100644 RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
> >
> > --
> > 2.37.1.windows.1
> >
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97822): https://edk2.groups.io/g/devel/message/97822
Mute This Topic: https://groups.io/mt/95915832/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-