From nobody Tue May 14 11:12:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97774+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1672204475408836.067009086523; Tue, 27 Dec 2022 21:14:35 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4gU1YY1788612xjDRTvLZsNM; Tue, 27 Dec 2022 21:14:34 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.65]) by mx.groups.io with SMTP id smtpd.web11.175876.1672204473736269223 for ; Tue, 27 Dec 2022 21:14:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=THXTdRUuAUCuVt7kI6ul7M8q8uG2koYlcVpWPDqlksswCZKZ1SejM1MMILhoLFF+LgjqGeRg7nJDNdaWXZOHq6zNvJAKSUsrr9U+Sb8U77Xp1HUnjlPx7oyEurjCLCv2KShYHhkA/XbxrEadmPe/6JxexksKqMzK9qQGEgEqf/WNnYMEZVAUOYRokLRWCaD7Y+7RNkSmHKN269oNsPbNa06+mLLYRvy1CAE51zwKTTDZAxBhcZI5Exps/1ORMYKNPE3IgbxtlXpy6je1RB25+CYjGM32O7iZlC7VZP+rFbKOtunrCXhbWlCDCQ6VVydi5jWrKLzEruVoLRr/LG8D+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xyIi+eAfJyqW/bukcHW4X3StutdYua0jpmwFPeT3nT8=; b=YvOEo0D0LF2Z5gsHGpBOfM54Pzoy89Q3ELZL0cwbkjmOXYi38HLIMVyGNL1bMBhjLR30NT8OJPwHZGxGGxLUx8dsZtYxufOXOXHIuiqsndRw3UUFrwD7+oMUcH4iwQIo9MAFKl05iMeoZuMY8EPE88IhwVoIMAi+6Kd7tQhPC0GMBXMf0CbZ7t3W1VeKoFr7kHtKSFfo5oiA9xgn1B4/4m7EM3rXqbHyqyt6fm0mXkcp0P4zjXN6apzQ0QtgKBREDSAtEITu7jbgbsrVPaxygRKcVnChNrgn74u4cPy7KFIZyhwKIjBcrQWVy/xVHnvUL/InWOwUWFSBLDSYcCCUoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MW2PR2101CA0010.namprd21.prod.outlook.com (2603:10b6:302:1::23) by IA1PR12MB6307.namprd12.prod.outlook.com (2603:10b6:208:3e5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Wed, 28 Dec 2022 05:14:30 +0000 X-Received: from CO1NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:302:1:cafe::c4) by MW2PR2101CA0010.outlook.office365.com (2603:10b6:302:1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.7 via Frontend Transport; Wed, 28 Dec 2022 05:14:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97774+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT011.mail.protection.outlook.com (10.13.175.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.17 via Frontend Transport; Wed, 28 Dec 2022 05:14:29 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 27 Dec 2022 23:14:22 -0600 From: "Chang, Abner via groups.io" To: CC: Michael D Kinney , Liming Gao , Zhiguang Liu , Nickle Wang , Igor Kulchytskyy , Isaac Oram , Nate DeSimone Subject: [edk2-devel] [PATCH V2 1/3] MdePkg/IndustryStandard: Update IPMI definitions Date: Wed, 28 Dec 2022 13:13:34 +0800 Message-ID: <20221228051336.1769-2-abner.chang@amd.com> In-Reply-To: <20221228051336.1769-1-abner.chang@amd.com> References: <20221228051336.1769-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT011:EE_|IA1PR12MB6307:EE_ X-MS-Office365-Filtering-Correlation-Id: 93a135e2-8ed9-41fd-0d71-08dae89265de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: zc5abTfmI/L6c8VV9oPQLYIHCaL0FNeS5hcSGEdSkkWF6onB/NU3qjF6tVT3YgLhw1PjHreJpi3LaSIr+fpK6YP4bM8t1+kzoNb0btufBUOH4TBa8i6FhWtE5pfvSmkUr78SmGj4hrTUzU0YvoAkS0bcq3Wr4wqupid9NsJLPo7ufhVf2lui9z3ZoenuUg+3LFrx/ffuMwKFSywLmWtHGd/rQ4MVaOMVaRSfRlIP9dQVnXhsgfJZJzzp1Nve/b7jEGwIpdXJdrD32eJiAfqxfEADQfczCIDHWEyjU0qP6+NGzK7YqYgeHlTTd56kfm7nvuZjQ/YHbo/LESFcdrU4Y9Kox1vhfK1pGy2r8crQ5GDreOTsiAFS2t0plM/qymgpBsk8/sLlXk0uDV8aPrboARewr+zkw6WkKCE+6IOgj+GTdRfq3vYL18EmfsZS4T2fvpnZs36JKFFNiczVd4MIs8Yom1HGr/F8VJQ7djqlBIb1hDIkgDdNWaQfyOOf1zWVw4DIopeoKu5ftPmrX2DHErpy2yI8JpkrrHMroIdpgRb4/bz5egPJieNFnoaa6Xn+GTUwbR054mDA2ETIe3LFxTycegPGt85Ga/SfarEGM7JfDIY2nCA0rl8CvCU1h16x5q/YZfOye/5aeIPCq9oDUq1cwxlRGZ3Tfmrz4WFBvzWbx3gLxh64jVCtz3CvW7OC1wpxC9rJy2xGlU52Ooj9wkRxd2YdRKTzMMWxD+KJKHE= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2022 05:14:29.6079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93a135e2-8ed9-41fd-0d71-08dae89265de X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6307 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com X-Gm-Message-State: 2jrlya5CMJHL4a5ARD75Px8Zx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1672204474; bh=VrCP9HSIgb1FOZSNpcGp0irGNRupPJPMGJLYO3MDwzM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=VHjq3Bqo91VDDojtmfYB4BF45iUAwNkYz6FA8MLzQrEeT/vFi5DaxaWiniJkSqHKbjN azaIyX/9qjBYVhCf2pkI43qsDiMZpsuAFskrcrj+zqwBEHA+mdiMAu2zHzkjZEvenY4eN bbfcEBWcrxbRWJOgnA9X/2bFq8LBKCsQoIQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1672204476155000002 Content-Type: text/plain; charset="utf-8" From: Abner Chang This change updates IPMI header files to support build up SMBIOS 42 Redfish Host Interface record using the information retrieved via IPMI App/Net Function. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Isaac Oram Cc: Nate DeSimone --- MdePkg/Include/IndustryStandard/Ipmi.h | 17 +++++++++ .../Include/IndustryStandard/IpmiNetFnApp.h | 37 +++++++++++++++++-- .../IndustryStandard/IpmiNetFnTransport.h | 32 ++++++++++++++++ 3 files changed, 82 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Ipmi.h b/MdePkg/Include/Indust= ryStandard/Ipmi.h index 9d1d412b53e..e16c1281862 100644 --- a/MdePkg/Include/IndustryStandard/Ipmi.h +++ b/MdePkg/Include/IndustryStandard/Ipmi.h @@ -6,6 +6,7 @@ and Appendix H, Sub-function Assignments. =20 Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -52,4 +53,20 @@ #define IPMI_COMP_CODE_SUBFUNCTION_DISABLED 0xD6 #define IPMI_COMP_CODE_UNSPECIFIED 0xFF =20 +#define IPMI_CHANNEL_NUMBER_PRIMARY_IPMB 0x00 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_1 0x01 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_2 0x02 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_3 0x03 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_4 0x04 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_5 0x05 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_6 0x06 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_7 0x07 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_8 0x08 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_9 0x09 +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_10 0x0A +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_11 0x0B +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_RESERVED_12 0x0C +#define IPMI_CHANNEL_NUMBER_IMPLEMENTATION_RESERVED_13 0x0D +#define IPMI_CHANNEL_NUMBER_PRIMARY_PRESENT_IF 0x0E +#define IPMI_CHANNEL_NUMBER_PRIMARY_SYSTEM_INTERFACE 0x0F #endif diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h b/MdePkg/Includ= e/IndustryStandard/IpmiNetFnApp.h index 0721bc6b271..08f977f2087 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h @@ -12,6 +12,7 @@ and Appendix H, Sub-function Assignments. =20 Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -486,6 +487,11 @@ typedef struct { // #define IPMI_APP_GET_SYSTEM_GUID 0x37 =20 +typedef struct { + UINT8 CompletionCode; + EFI_GUID SystemUuid; +} IPMI_GET_SYSTEM_UUID_RESPONSE; + // // Constants and Structure definitions for "Get System GUID" command to f= ollow here // @@ -671,6 +677,30 @@ typedef struct { #define IPMI_CHANNEL_MEDIA_TYPE_OEM_START 0x60 #define IPMI_CHANNEL_MEDIA_TYPE_OEM_END 0x7F =20 +// +// Definitions for channel protocol type +// +// Not available +#define IPMI_CHANNEL_PROTOCOL_TYPE_NA 0x00 +// IPMB-1.0 +#define IPMI_CHANNEL_PROTOCOL_TYPE_IPMB_1_0 0x01 +// ICMB-1.0 +#define IPMI_CHANNEL_PROTOCOL_TYPE_ICMB_1_0 0x02 +// Reserved +#define IPMI_CHANNEL_PROTOCOL_TYPE_RESERVED 0x03 +// IPMI SMBUS +#define IPMI_CHANNEL_PROTOCOL_TYPE_IPMI_SMBUS 0x04 +// KCS +#define IPMI_CHANNEL_PROTOCOL_TYPE_KCS 0x05 +// SMIC +#define IPMI_CHANNEL_PROTOCOL_TYPE_SMIC 0x06 +// BT-10 +#define IPMI_CHANNEL_PROTOCOL_TYPE_BT_10 0x07 +// BT-15 +#define IPMI_CHANNEL_PROTOCOL_TYPE_BT_15 0x08 +// TMode +#define IPMI_CHANNEL_PROTOCOL_TYPE_TMODE 0x09 + typedef union { struct { UINT8 ChannelNo : 4; @@ -713,10 +743,9 @@ typedef struct { UINT16 AuxChannelInfo; } IPMI_GET_CHANNEL_INFO_RESPONSE; =20 -// -// Definitions for Get Channel Info command -// -#define IPMI_APP_GET_CHANNEL_INFO 0x42 +typedef struct { + IPMI_CHANNEL_INFO_CHANNEL_NUMBER ChannelNumber; +} IPMI_GET_CHANNEL_INFO_REQUEST; =20 // // Constants and Structure definitions for "Get Channel Info" command to = follow here diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnTransport.h b/MdePkg/= Include/IndustryStandard/IpmiNetFnTransport.h index 19db84e5122..2eb6cd9b344 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnTransport.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnTransport.h @@ -11,6 +11,7 @@ and Appendix H, Sub-function Assignments. =20 Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -60,6 +61,7 @@ typedef enum { IpmiLanReserved3, IpmiLanDestinationType, IpmiLanDestinationAddress, + IpmiLanVlanId =3D 0x14, IpmiIpv4OrIpv6Support =3D 0x32, IpmiIpv4OrIpv6AddressEnable, IpmiIpv6HdrStatTrafficClass, @@ -103,6 +105,14 @@ typedef enum { IpmiOem2 } IPMI_LAN_DEST_TYPE_DEST_TYPE; =20 +// +// Destination address format +// +typedef enum { + IpmiDestinationAddressVersion4, + IpmiDestinationAddressVersion6 +} IPMI_LAN_DEST_ADDRESS_VERSION; + typedef union { struct { UINT8 NoAuth : 1; @@ -177,6 +187,10 @@ typedef struct { UINT8 ArpInterval; } IPMI_LAN_ARP_INTERVAL; =20 +typedef struct { + UINT8 IpAddress[4]; +} IPMI_LAN_DEFAULT_GATEWAY; + typedef struct { UINT8 Data[18]; } IPMI_LAN_COMMUNITY_STRING; @@ -227,6 +241,24 @@ typedef struct { IPMI_LAN_MAC_ADDRESS AlertingMacAddress; } IPMI_LAN_DEST_ADDRESS; =20 +typedef struct { + UINT8 VanIdLowByte; +} IPMI_LAN_VLAN_ID_DATA1; + +typedef union { + struct { + UINT8 VanIdHighByte : 4; + UINT8 Reserved : 3; + UINT8 Enabled : 1; + } Bits; + UINT8 Uint8; +} IPMI_LAN_VLAN_ID_DATA2; + +typedef struct { + IPMI_LAN_VLAN_ID_DATA1 Data1; + IPMI_LAN_VLAN_ID_DATA2 Data2; +} IPMI_LAN_VLAN_ID; + typedef union { IPMI_LAN_AUTH_TYPE IpmiLanAuthType; IPMI_LAN_IP_ADDRESS IpmiLanIpAddress; --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97774): https://edk2.groups.io/g/devel/message/97774 Mute This Topic: https://groups.io/mt/95915833/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 11:12:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97775+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1672204477047504.91716329015617; Tue, 27 Dec 2022 21:14:37 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id QxXlYY1788612x2Kjki3RZnn; Tue, 27 Dec 2022 21:14:36 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.51]) by mx.groups.io with SMTP id smtpd.web11.175878.1672204475234454975 for ; Tue, 27 Dec 2022 21:14:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRuflDScSB+kLXeWWR8hWdtVg6cRio7u5HjYNf04lwY8XptB3lzWD4wldhLlJ3XKDsJx6ANUZggVir4xRR2S/t4ZcT+fk1IwTngsxz+5nfsGni66guE7yUD2ChskMFTtE7f6q35AJtVA/Nnu5bwrHp4sjkvKTlBiBbOuarT47EEse7/dmSQ2UvAbgS/mpLJOQoWY9eksGnQJgKGXxl3TECyRNHBwyGgzqKwDKZHSU0+1T2z72Yyg9sYzkBeLqurZWL8ruj5Oro5U3/kiVhzoX0yL381G6D76FNRuK0gqclcvu6bVn1mxV2TayD2nMY7MFwM/1kHWUJ4rwWYMxcAe6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tr/rxSYYQ8BuDjlDjioXz8F6LbW2lp6GRiNBLdzJmdU=; b=jXDQ0SdqoH+VFA5SGz1yDXeJL3Oe83L8ubxsfUsR/y+CIitNFzpvkHwuSCEf8OYJCt8b5CE8G8J1rZSKdg7n2vnH0867rO6ZhsTWcNBYL10i0W+9Aj3BW+chbFFZ8Z6qxSiJoEPLc790G7l90tt45rBxg9mxLDboqSD/3itSxbDptcgUmxh5zabhrt3FzLvbdcXd/m8Jhq4iimYDj+NX0nyddObWfuPl98Y7Juh1MZH0/bLTYGThjMCErDIt/Y2W+dTT0+RGe8dgHUVpFEKKdtrwoD4FTLwZ+tS0m5oXFvKfBQG5Bab5reBMXDN429bkP3T/fn+TC+wrbuuFp+z6tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MW4PR02CA0029.namprd02.prod.outlook.com (2603:10b6:303:16d::34) by PH8PR12MB6819.namprd12.prod.outlook.com (2603:10b6:510:1ca::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Wed, 28 Dec 2022 05:14:31 +0000 X-Received: from CO1NAM11FT074.eop-nam11.prod.protection.outlook.com (2603:10b6:303:16d:cafe::db) by MW4PR02CA0029.outlook.office365.com (2603:10b6:303:16d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.17 via Frontend Transport; Wed, 28 Dec 2022 05:14:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97775+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT074.mail.protection.outlook.com (10.13.174.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.16 via Frontend Transport; Wed, 28 Dec 2022 05:14:30 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 27 Dec 2022 23:14:25 -0600 From: "Chang, Abner via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH V2 2/3] RedfishPkg/Include: Add Redfish IPMI definitions Date: Wed, 28 Dec 2022 13:13:35 +0800 Message-ID: <20221228051336.1769-3-abner.chang@amd.com> In-Reply-To: <20221228051336.1769-1-abner.chang@amd.com> References: <20221228051336.1769-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT074:EE_|PH8PR12MB6819:EE_ X-MS-Office365-Filtering-Correlation-Id: 354982a5-b44d-4772-2ab6-08dae892669c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: E3mdun8Xd3Eo3rEYhOXfNf6Wokkr5b3E1QV+cNX9aDOHUG+30q0Bk/1Ki0O2rDjL9KCXSXrlXwA7oGW9t8qQ/t+5pM1uTBJTFV4WMWduiVn2h/GsRc+C0yV23EGmbwtqLe0ci0D4M4JO5hgVXFCTMM4jlZpI25VjCqch+TDqNF8crqYKLDUBSmvH1Rkh2ns40cuGd6vs6w6XMPJWmAVMK2l++3wQ0JCp1v70TEyP028BdY9y8GkRXGClX7C5acL5H0UiOUnjMjh+tV5n1WjJz718xLl2EH5nMevT2v+RCAyAbiQcMffcEpx4bv7ueGLlohTEeD18PRGLH0H+pxIUgBzEfJrcYhGJ80qmSitaWk2qswx/GhgLpXp+6Fa9tlhHxEWNcMVAFEuUR+rWPOvfCYOawPIbYI2kiW14NG0NQmG3I7ukW99/h0e8k/JXWZS8C8vtDr+30OncQ63vcup+d09z/1aWROta4WTIKPws8kn613vI1aWTdSkSAZrdm0qKXYm3Ycb7Jv7sILYLwWZcuUImyZT4rURc75Nvy7mglwpMW5/5G6s5mdXddyajc8FOFBSixy9GUXPARWWlNHgm1vONf6fdB6oWSkgQfLYsK0/lGw9zA6EosryH8L77MLlBvpJNxXYDNS0oNFdGO3xvL1KVHjv7iBPTkUXeix0vohzSbvPfC4AA/5MOxaoj75qTIPCk+IuIrn2dh1ssspvyyaMd5zl/EguCFzem7CWXUVI= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2022 05:14:30.9163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 354982a5-b44d-4772-2ab6-08dae892669c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT074.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6819 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com X-Gm-Message-State: 8yIobDXjGrPJqnwbwe8UsTdBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1672204476; bh=t02Sh8Baaf7BDPQhHyEYorfkDhnd3u0vbz3ZrkUvI3g=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Gxcrgy3ic2XlaElPaUA8Hi5zHYjf57Kqh49jRy97ReAu+tCq0grZJwE3X1l83YSI0/9 fQigNiUc19h1oyipluIsUjJRcGqcMWBfvzuI5quFFd9xCjR3dxT0FRlVgg1gbZ3Wwjz39 i3ng+GPy5hLaFHsWP5ieSVUON02QKh3vQ5A= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1672204478083000011 Content-Type: text/plain; charset="utf-8" From: Abner Chang Add the definitions of Redfish Host Interface credential bootstrapping IPMI commands. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishHostInterfaceIpmi.h | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 RedfishPkg/Include/IndustryStandard/RedfishHostInterfac= eIpmi.h diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h= b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h new file mode 100644 index 00000000000..892b744c458 --- /dev/null +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h @@ -0,0 +1,50 @@ +/** @file + Redfish Host Interface IPMI command + + Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved. + SPDX-License-Identifier: BSD-2-Clause-Patent +**/ + +#ifndef REDFISH_HOST_INTERFACE_IPMI_H_ +#define REDFISH_HOST_INTERFACE_IPMI_H_ + +#include +#include + +#define REDFISH_IPMI_GROUP_EXTENSION 0x52 +#define REDFISH_IPMI_GET_BOOTSTRAP_CREDENTIALS_CMD 0x02 +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_ENABLE 0xA5 +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_DISABLE 0x00 +#define REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED 0x80 + +/// +/// Per Redfish Host Interface Specification 1.3, The maximum lenght of +/// username and password is 16 characters long. +// +#define USERNAME_MAX_LENGTH 16 +#define PASSWORD_MAX_LENGTH 16 +#define USERNAME_MAX_SIZE (USERNAME_MAX_LENGTH + 1) // NULL terminator +#define PASSWORD_MAX_SIZE (PASSWORD_MAX_LENGTH + 1) // NULL terminator + +#pragma pack(1) + +/// +/// The definition of IPMI command to get bootstrap account credentials +/// typedef struct { +typedef struct { + UINT8 GroupExtensionId; + UINT8 DisableBootstrapControl; +} IPMI_BOOTSTRAP_CREDENTIALS_COMMAND_DATA; + +/// +/// The response data of getting bootstrap credential /// typedef +typedef struct { + UINT8 CompletionCode; + UINT8 GroupExtensionId; + CHAR8 Username[USERNAME_MAX_LENGTH]; + CHAR8 Password[PASSWORD_MAX_LENGTH]; +} IPMI_BOOTSTRAP_CREDENTIALS_RESULT_RESPONSE; + +#pragma pack() + +#endif --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97775): https://edk2.groups.io/g/devel/message/97775 Mute This Topic: https://groups.io/mt/95915834/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 11:12:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97776+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1672204476418980.7790776549566; Tue, 27 Dec 2022 21:14:36 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 2L1ZYY1788612xf6EW19a1r6; Tue, 27 Dec 2022 21:14:35 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.83]) by mx.groups.io with SMTP id smtpd.web10.174866.1672204475249324255 for ; Tue, 27 Dec 2022 21:14:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rc1vjlOm5lQ/96YO6/SxmnZJ6IkGh73Pqan47Lqyr52ylhzETwNtOLjpR9jM1YRnLFvPs1YL6CbvlDoTlDjXyhKA9XBTyfX1lg0559wQN4kcCx6BTkiMBHaxfqnvi8qucH3xZVW89maiNLVF451Zk4u06X1x/LUGDgBGqs2Sbgt5wmxqRyYfpiBolM4Ki0WPf6kGcf/PUeIW++zc75Nz7IEuq8wmNljgf3yTYA2wcwpsE/LOX/PdLa3468TilDuwGvFLmU71xEZpIn2xat+ffoIwwf7RX/4IqPJWLTlc1rnq4N0WYdfL0ZILnSFDmn/MddYpecceQjpyjDqnqSHzDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iYDEBjCKlQXO3iDoBKuwYeYL/fxWy62y/j1Hu0sp1r4=; b=kg3d/yi/vaEtd50OpoXnlaJnol6IHxBrFYHUkWe7RrmnFuh7L16MejMlrsxQoMKHj+GnWGViHuPjguDMi9gl19TXWJB8pUDN7ZEUKxVpwFAOnWvvOtTUzRK1JJDR5S91SdTT7c2yz1AQLuTuWaPdDdK+A4cu5TqdzSBQYZG2461tE4VV8KNBcvICZzIGjiTey0mclXivIVV2JQDDgmzGPUY8ift9KfaZgOuuu169X7kCxYMkRiSmI6K8iuc4/1s+8NhxSuWqZY3yUL0mhl/VhnG1DI4JhECg2W7h78ZrnogaQLBD485JcsVKJ2YetMIeFNmKGZtDg3wtzj0d4HKn0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MW2PR2101CA0012.namprd21.prod.outlook.com (2603:10b6:302:1::25) by PH7PR12MB7985.namprd12.prod.outlook.com (2603:10b6:510:27b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.15; Wed, 28 Dec 2022 05:14:31 +0000 X-Received: from CO1NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:302:1:cafe::9e) by MW2PR2101CA0012.outlook.office365.com (2603:10b6:302:1::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.7 via Frontend Transport; Wed, 28 Dec 2022 05:14:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97776+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT011.mail.protection.outlook.com (10.13.175.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.17 via Frontend Transport; Wed, 28 Dec 2022 05:14:31 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 27 Dec 2022 23:14:26 -0600 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Date: Wed, 28 Dec 2022 13:13:36 +0800 Message-ID: <20221228051336.1769-4-abner.chang@amd.com> In-Reply-To: <20221228051336.1769-1-abner.chang@amd.com> References: <20221228051336.1769-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT011:EE_|PH7PR12MB7985:EE_ X-MS-Office365-Filtering-Correlation-Id: 9887a53c-f9ef-4e3e-3579-08dae892670f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Gykrnuz5irwtPV7ZkQIXsPZTNPQpjKwWKGE5fuJRj84hy3ULcI4PeC5FQ4+0MUcDiBqogZiEfjhgNfjCe/fb4MfmeLN2j7dT787taszqFoLQFmLIEnflq4ZXKW/Orp5GslfHb2CnSqPWLDjQisqaURlqYyZTvrMtjs4tHTF/ZYqkaXDWaOZ18UaqjHS9xhAH/USVQ9OqYcIWTS2yFbCdE06CA9Br1sdAJ+F25J8wTl49dtCzq5zENlMbPnQhtBsx7eGW5eXywgPvimRkKCCW+WtoWOfua/rsrqzRWWc5ZKIby6d11BxCyfv3EcUTfuhV8cIOhbkfgJe2Xz8hnGy4Bvip8qsmv/YK5PHxCi3ORGqZWvlmxVZFcww7MJCPY/m/WBSq4/NV4mdlF0QPGXF88eQ/TL+IWsq0VSitvKN7qtADyE5vG1UtuHNJNzOypBSpVJjUCZIYDlP9pOwHj1uHgVkdsAIhRevU5NcBhmcK6AoyA2zzsK6g/9KFbg60KkJyCTCSJ44tq1Lcu0CPTNdkXbBJxSujtUUD3tEPXlGoUTLRdv5+8Vc+Lk3sNfqUnAe8ozZWscR3ZG+rPwSzc9/NIAkNPcumOssO/GVwunYwpCbNe/rwCj16/Tz5o6qFKHZ/tR64+eZHFlFJmVOexJwNpl0IxYLAFufuD0IZzDOybREm0xDjHUbD5CAJqEWtxNkYJDVb4T4o2sbYZIQjIZ2FXu3+Y8eMczfe+l1XFj11UBQ= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2022 05:14:31.6859 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9887a53c-f9ef-4e3e-3579-08dae892670f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7985 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com X-Gm-Message-State: VJ84lWxbwP0dIYpwPDPrmuLRx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1672204475; bh=qzsCkn/XH7Q9AgvtAa1K5u/nlBW/tX+YYS/Qd3e+xAY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ErTDCCrRh7fmxxwDfyf+JtIbEeA3OuTlRE9cVR0G6kpFImqF/foxq2wsktDb6I2jdiK TV6pkGny6dcxSV6Blqn8oKmpUXactRKwWRu3Kpy+m8Waz8RzYjFzE8qugpiuNHfq7lzJV EEvAFGxMgK6F6ec0eOT8i3zbKdbPz9c27hI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1672204478089000012 Content-Type: text/plain; charset="utf-8" From: Abner Chang Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host Interface spec v1.3. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../IndustryStandard/RedfishHostInterface.h | 25 ++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h b/R= edfishPkg/Include/IndustryStandard/RedfishHostInterface.h index 49b3ceee39c..022bd1f36ef 100644 --- a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -29,6 +30,18 @@ #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01 #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 0x02 =20 +/// +/// Definitions for IP assignment tyeps. +/// +typedef enum { + RedfishHostIpAssignmentUnknown, + RedfishHostIpAssignmentStatic, + RedfishHostIpAssignmentDhcp, + RedfishHostIpAssignmentAutoConfigure, + RedfishHostIpAssignmentHostSelected, + RedfishHostIpAssignmentReserved +} REDFISH_HOST_IP_ASSIGNMENT; + #pragma pack(1) /// /// Structure definitions of Host Interface device type 04h (USB Network I= nterface V2) @@ -40,12 +53,18 @@ typedef struct { ///< idVendor field of the USB = descriptor. UINT16 IdProduct; ///< The Product ID of the devi= ce, as read from the ///< idProduct field of the USB= descriptor. - UINT8 SecialNumberStr; ///< The string number for the = Serial Number of the + UINT8 SerialNumberStr; ///< The string number for the = Serial Number of the ///< device. The string data is= read from the ///< iSerialNumber.bDescriptorT= ype field of the USB ///< descriptor, and is convert= ed from Unicode to ASCII ///< and is NULL terminated. UINT8 MacAddress[6]; ///< The MAC address of the PCI= /PCIe network device. + + /// + /// Below is defined in Redfish Host Interface spec v1.3 + /// + UINT16 Characteristics; ///< Additional device characte= ristics. + UINT16 CredentialBootstrappingHandle; ///< Credential bootstrapping h= andle. } USB_INTERFACE_DEVICE_DESCRIPTOR_V2; =20 // @@ -74,6 +93,10 @@ typedef struct { /// /// Define union for the Host Interface Device Descriptor /// +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_3 0x11 ///< Leng= th USB interface device v2 defined in + ///< Redf= ish host interface spec v1.3 +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_2 0x0d ///< Leng= th USB interface device v2 defined in + ///< Redf= ish host interface spec v1.2 typedef union { USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< Devi= ce type USB V2 device discriptor. PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; ///< Devi= ce type PCI/PCIe V2 device discriptor. --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97776): https://edk2.groups.io/g/devel/message/97776 Mute This Topic: https://groups.io/mt/95915835/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-