[v1] Fixes for SEV-SNP CC blob and CPUID table handling

[edk2-devel] [PATCH 0/4] Fixes for SEV-SNP CC blob and CPUID table handling

Posted by Roth, Michael via groups.io 1 year, 4 months ago

Here are a number of fixes related to OVMF handling of the SEV-SNP
Confidential Computing blob and CPUID table.

Patch #1 is a fix for recently-reported issue that can cause
significant problems with some SEV-SNP guest operating systems.
Please consider applying this patch directly if the other
patches in this series are held up for any reason.

Patches 2-4 are minor changes for things that aren't currently
triggered in practice, but make OVMF's SEV-SNP implementation more
robust for different build/hypervisor environments in the future.
Patch #2 was submitted previously, but refreshed here to apply
cleanly on top of Patch #1, with no other functional changes since
the initial review.

----------------------------------------------------------------
Michael Roth (4):
      OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory
      OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition
      OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation
      OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP

 OvmfPkg/AmdSevDxe/AmdSevDxe.c                          | 64 ++++++++++++++++++++++++++++++++++----------
 OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h |  6 +++--
 OvmfPkg/Library/CcExitLib/CcExitVcHandler.c            | 13 ++++-----
 3 files changed, 59 insertions(+), 24 deletions(-)




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97701): https://edk2.groups.io/g/devel/message/97701
Mute This Topic: https://groups.io/mt/95815539/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] Fixes for SEV-SNP CC blob and CPUID table handling

Posted by Roth, Michael via groups.io 1 year, 4 months ago

On Wed, Dec 21, 2022 at 10:06:47AM -0600, Michael Roth wrote:
> Here are a number of fixes related to OVMF handling of the SEV-SNP
> Confidential Computing blob and CPUID table.
> 
> Patch #1 is a fix for recently-reported issue that can cause
> significant problems with some SEV-SNP guest operating systems.
> Please consider applying this patch directly if the other
> patches in this series are held up for any reason.
> 
> Patches 2-4 are minor changes for things that aren't currently
> triggered in practice, but make OVMF's SEV-SNP implementation more
> robust for different build/hypervisor environments in the future.
> Patch #2 was submitted previously, but refreshed here to apply
> cleanly on top of Patch #1, with no other functional changes since
> the initial review.
> 
> ----------------------------------------------------------------
> Michael Roth (4):
>       OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory
>       OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition
>       OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation
>       OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP

Adding some Cc's from Maintainers.txt that I should have included
originally:

  Ard Biesheuvel <ardb+tianocore@kernel.org>
  Jiewen Yao <jiewen.yao@intel.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Erdem Aktas <erdemaktas@google.com>
  James Bottomley <jejb@linux.ibm.com>
  Min Xu <min.m.xu@intel.com>

Thanks,

Mike

> 
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c                          | 64 ++++++++++++++++++++++++++++++++++----------
>  OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h |  6 +++--
>  OvmfPkg/Library/CcExitLib/CcExitVcHandler.c            | 13 ++++-----
>  3 files changed, 59 insertions(+), 24 deletions(-)
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97708): https://edk2.groups.io/g/devel/message/97708
Mute This Topic: https://groups.io/mt/95815539/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] Fixes for SEV-SNP CC blob and CPUID table handling

Posted by Yao, Jiewen 1 year, 3 months ago

Hi Roth
I got weird merge conflict when I try to apply the patches from email.

Would you please resubmit the patch based on latest code base?

Once I see the new version, I will try to merge them again.

Thank you
Yao, Jiewen

> -----Original Message-----
> From: Michael Roth <michael.roth@amd.com>
> Sent: Thursday, December 22, 2022 1:42 AM
> To: devel@edk2.groups.io
> Cc: Tom Lendacky <thomas.lendacky@amd.com>; Ni, Ray
> <ray.ni@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao,
> Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Aktas, Erdem <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>; Xu, Min M <min.m.xu@intel.com>
> Subject: Re: [PATCH 0/4] Fixes for SEV-SNP CC blob and CPUID table handling
> 
> On Wed, Dec 21, 2022 at 10:06:47AM -0600, Michael Roth wrote:
> > Here are a number of fixes related to OVMF handling of the SEV-SNP
> > Confidential Computing blob and CPUID table.
> >
> > Patch #1 is a fix for recently-reported issue that can cause
> > significant problems with some SEV-SNP guest operating systems.
> > Please consider applying this patch directly if the other
> > patches in this series are held up for any reason.
> >
> > Patches 2-4 are minor changes for things that aren't currently
> > triggered in practice, but make OVMF's SEV-SNP implementation more
> > robust for different build/hypervisor environments in the future.
> > Patch #2 was submitted previously, but refreshed here to apply
> > cleanly on top of Patch #1, with no other functional changes since
> > the initial review.
> >
> > ----------------------------------------------------------------
> > Michael Roth (4):
> >       OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as
> EfiACPIReclaimMemory
> >       OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct
> definition
> >       OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation
> >       OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP
> 
> Adding some Cc's from Maintainers.txt that I should have included
> originally:
> 
>   Ard Biesheuvel <ardb+tianocore@kernel.org>
>   Jiewen Yao <jiewen.yao@intel.com>
>   Gerd Hoffmann <kraxel@redhat.com>
>   Erdem Aktas <erdemaktas@google.com>
>   James Bottomley <jejb@linux.ibm.com>
>   Min Xu <min.m.xu@intel.com>
> 
> Thanks,
> 
> Mike
> 
> >
> >  OvmfPkg/AmdSevDxe/AmdSevDxe.c                          | 64
> ++++++++++++++++++++++++++++++++++----------
> >  OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h |  6 +++--
> >  OvmfPkg/Library/CcExitLib/CcExitVcHandler.c            | 13 ++++-----
> >  3 files changed, 59 insertions(+), 24 deletions(-)
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98760): https://edk2.groups.io/g/devel/message/98760
Mute This Topic: https://groups.io/mt/95815539/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-