[edk2-devel] [PATCH v2 0/4] Fixes for SEV-SNP CC blob and CPUID table handling

Roth, Michael via groups.io posted 4 patches 1 year ago
Failed in applying to current master (apply log)
OvmfPkg/AmdSevDxe/AmdSevDxe.c                          | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++--------------
OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h |  6 ++++--
OvmfPkg/Library/CcExitLib/CcExitVcHandler.c            | 13 +++++--------
3 files changed, 59 insertions(+), 24 deletions(-)
[edk2-devel] [PATCH v2 0/4] Fixes for SEV-SNP CC blob and CPUID table handling
Posted by Roth, Michael via groups.io 1 year ago
(Mainly a resend of v1, but rolled in Gerd's Acked-by's, addressed
new coding style check in the CI, and updated Cc list)

Here are a number of fixes related to OVMF handling of the SEV-SNP
Confidential Computing blob and CPUID table.

Patch #1 is a fix for recently-reported issue that can cause
significant problems with some SEV-SNP guest operating systems.
Please consider applying this patch directly if the other
patches in this series are held up for any reason.

Patches 2-4 are minor changes for things that aren't currently
triggered in practice, but make OVMF's SEV-SNP implementation more
robust for different build/hypervisor environments in the future.
Patch #2 was submitted previously, but refreshed here to apply
cleanly on top of Patch #1, with no other functional changes since
the initial review.

v2:
 - rebased/retested on latest master
 - replaced usage of __FUNCTION__ with __func__ to comply with new CI
   test cases

----------------------------------------------------------------
Michael Roth (4):
      OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory
      OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition
      OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation
      OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP

 OvmfPkg/AmdSevDxe/AmdSevDxe.c                          | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++--------------
 OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h |  6 ++++--
 OvmfPkg/Library/CcExitLib/CcExitVcHandler.c            | 13 +++++--------
 3 files changed, 59 insertions(+), 24 deletions(-)




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103596): https://edk2.groups.io/g/devel/message/103596
Mute This Topic: https://groups.io/mt/98501793/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/4] Fixes for SEV-SNP CC blob and CPUID table handling
Posted by Yao, Jiewen 1 year ago
Merged https://github.com/tianocore/edk2/pull/4313

> -----Original Message-----
> From: Michael Roth <michael.roth@amd.com>
> Sent: Wednesday, April 26, 2023 4:33 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb@kernel.org>; Tom Lendacky
> <thomas.lendacky@amd.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Aktas,
> Erdem <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>;
> Xu, Min M <min.m.xu@intel.com>
> Subject: [PATCH v2 0/4] Fixes for SEV-SNP CC blob and CPUID table handling
> 
> (Mainly a resend of v1, but rolled in Gerd's Acked-by's, addressed
> new coding style check in the CI, and updated Cc list)
> 
> Here are a number of fixes related to OVMF handling of the SEV-SNP
> Confidential Computing blob and CPUID table.
> 
> Patch #1 is a fix for recently-reported issue that can cause
> significant problems with some SEV-SNP guest operating systems.
> Please consider applying this patch directly if the other
> patches in this series are held up for any reason.
> 
> Patches 2-4 are minor changes for things that aren't currently
> triggered in practice, but make OVMF's SEV-SNP implementation more
> robust for different build/hypervisor environments in the future.
> Patch #2 was submitted previously, but refreshed here to apply
> cleanly on top of Patch #1, with no other functional changes since
> the initial review.
> 
> v2:
>  - rebased/retested on latest master
>  - replaced usage of __FUNCTION__ with __func__ to comply with new CI
>    test cases
> 
> ----------------------------------------------------------------
> Michael Roth (4):
>       OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as
> EfiACPIReclaimMemory
>       OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct
> definition
>       OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation
>       OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP
> 
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c                          | 64
> ++++++++++++++++++++++++++++++++++++++++++++++++++--------------
>  OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h |  6 ++++--
>  OvmfPkg/Library/CcExitLib/CcExitVcHandler.c            | 13 +++++--------
>  3 files changed, 59 insertions(+), 24 deletions(-)
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103653): https://edk2.groups.io/g/devel/message/103653
Mute This Topic: https://groups.io/mt/98501793/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-