1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl

aryeh.chen@intel.com posted 1 patch 1 year, 7 months ago
Failed in applying to current master (apply log)
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
1 file changed, 1 deletion(-)
[edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Posted by aryeh.chen@intel.com 1 year, 7 months ago 
From: Aryeh Chen <aryeh.chen@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057

According to ASL Coding Guidelines - Device Identifiers
"A Device should contain either an _ADR or a _HID object, never both."
, so remove _ADR due to _HID exist.

Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
index 0d94472450..4efb8709ac 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
@@ -27,7 +27,6 @@ DefinitionBlock (
       Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy
       Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID
       Name(_SEG, 0)
-      Name(_ADR, 0x00000000)
       Method(^BN00, 0){ return(0x0000) }  // Returns default Bus number for Peer PCI busses. Name can be overriden with control method placed directly under Device scope
       Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root PCI Bus
       Name(_UID, 0x0000)  // Unique Bus ID, optional
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93640): https://edk2.groups.io/g/devel/message/93640
Mute This Topic: https://groups.io/mt/93627173/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Posted by Chiu, Chasel 1 year, 6 months ago 
Patch has been merged:
https://github.com/tianocore/edk2-platforms/commit/ae75c51f27e21036b6ee021a2d5b9f365f951413

Thanks,
Chasel


> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Sinha, Ankit <ankit.sinha@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> 
> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> 
> According to ASL Coding Guidelines - Device Identifiers "A Device should contain
> either an _ADR or a _HID object, never both."
> , so remove _ADR due to _HID exist.
> 
> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> index 0d94472450..4efb8709ac 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> @@ -27,7 +27,6 @@ DefinitionBlock (
>        Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host
> hierarchy       Name(_CID, EISAID("PNP0A03")) // To support legacy OS that
> doesn't understand the new HID       Name(_SEG, 0)-      Name(_ADR, 0x00000000)
> Method(^BN00, 0){ return(0x0000) }  // Returns default Bus number for Peer PCI
> busses. Name can be overriden with control method placed directly under
> Device scope       Method(_BBN, 0){ return(BN00()) } // Bus number, optional for
> the Root PCI Bus       Name(_UID, 0x0000)  // Unique Bus ID, optional--
> 2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94721): https://edk2.groups.io/g/devel/message/94721
Mute This Topic: https://groups.io/mt/93627173/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Posted by Ankit Sinha 1 year, 7 months ago 
Hi Aryeh,

Can you please post the test results for this change. It would be good to note that there is no change in behavior in the OS.

Thank you,
Ankit

> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Gao,
> Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> 
> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> 
> According to ASL Coding Guidelines - Device Identifiers "A Device should
> contain either an _ADR or a _HID object, never both."
> , so remove _ADR due to _HID exist.
> 
> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> index 0d94472450..4efb8709ac 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> @@ -27,7 +27,6 @@ DefinitionBlock (
>        Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy       Name(_CID, EISAID("PNP0A03")) // To support legacy OS
> that doesn't understand the new HID       Name(_SEG, 0)-      Name(_ADR,
> 0x00000000)       Method(^BN00, 0){ return(0x0000) }  // Returns default Bus
> number for Peer PCI busses. Name can be overriden with control method
> placed directly under Device scope       Method(_BBN, 0){ return(BN00()) } //
> Bus number, optional for the Root PCI Bus       Name(_UID, 0x0000)  // Unique
> Bus ID, optional--
> 2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93663): https://edk2.groups.io/g/devel/message/93663
Mute This Topic: https://groups.io/mt/93627173/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Posted by Chen, Aryeh 1 year, 7 months ago 
Hi Ankit,

Add a change to remove Name(_ADR, 0x00000000) from edk2-platforms\Platform\Intel\MinPlatformPkg\Acpi\MinDsdt\MinDsdt.asl
It can boot to OS success on Win10 21H2 and Ubuntu 22.4.0 on TGLU openboard bios.

=== Acpidump ===
Signature	"DSDT"
Length	0x000000FD (253)
Revision	0x01 (1)
Checksum	0x33 (51)
OEM ID	"INTEL "
OEM Table ID	"MIN     "
OEM Revision	0x00000000 (0)
Creator ID	"INTL"
Creator Revision	0x20210930 (539035952)
DefinitionBlock ("DSDT.AML", "DSDT", 0x01, "INTEL ", "MIN     ", 0x00000000)
{
	Scope(_SB)
	{
		Device(PCI0)
		{
			Name(_HID, EISAID("PNP0A08"))
			Name(_CID, EISAID("PNP0A03"))
			Name(_SEG, Zero)
			Method(^BN00, 0, NotSerialized)
			{
				Return(Zero)
			}

=== Original mindsdt.asl ===
  Scope(\_SB) {
  //---------------------------------------------------------------------------
  // Begin PCI tree object scope
  //---------------------------------------------------------------------------
    Device(PCI0) { // PCI Bridge "Host Bridge"
      Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy
      Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID
      Name(_SEG, 0)
      Name(_ADR, 0x00000000)
      Method(^BN00, 0){ return(0x0000) }  // Returns default Bus number for Peer PCI busses. Name can be overriden with control method placed directly under Device scope
      Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root PCI Bus

Thanks,
Aryeh

-----Original Message-----
From: Sinha, Ankit <ankit.sinha@intel.com> 
Sent: Tuesday, September 13, 2022 4:54 AM
To: Chen, Aryeh <aryeh.chen@intel.com>; devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl

Hi Aryeh,

Can you please post the test results for this change. It would be good to note that there is no change in behavior in the OS.

Thank you,
Ankit

> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel 
> <chasel.chiu@intel.com>; Desimone, Nathaniel L 
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W 
> <isaac.w.oram@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Gao, 
> Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> 
> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> 
> According to ASL Coding Guidelines - Device Identifiers "A Device 
> should contain either an _ADR or a _HID object, never both."
> , so remove _ADR due to _HID exist.
> 
> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> index 0d94472450..4efb8709ac 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> @@ -27,7 +27,6 @@ DefinitionBlock (
>        Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy       Name(_CID, EISAID("PNP0A03")) // To support legacy OS
> that doesn't understand the new HID       Name(_SEG, 0)-      Name(_ADR,
> 0x00000000)       Method(^BN00, 0){ return(0x0000) }  // Returns default Bus
> number for Peer PCI busses. Name can be overriden with control method
> placed directly under Device scope       Method(_BBN, 0){ return(BN00()) } //
> Bus number, optional for the Root PCI Bus       Name(_UID, 0x0000)  // Unique
> Bus ID, optional--
> 2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94052): https://edk2.groups.io/g/devel/message/94052
Mute This Topic: https://groups.io/mt/93627173/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Posted by Ankit Sinha 1 year, 7 months ago 
Hi Aryeh,

Thank you for testing.

Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>

> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Wednesday, September 21, 2022 12:34 AM
> To: Sinha, Ankit <ankit.sinha@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> 
> Hi Ankit,
> 
> Add a change to remove Name(_ADR, 0x00000000) from edk2-
> platforms\Platform\Intel\MinPlatformPkg\Acpi\MinDsdt\MinDsdt.asl
> It can boot to OS success on Win10 21H2 and Ubuntu 22.4.0 on TGLU
> openboard bios.
> 
> === Acpidump ===
> Signature	"DSDT"
> Length	0x000000FD (253)
> Revision	0x01 (1)
> Checksum	0x33 (51)
> OEM ID	"INTEL "
> OEM Table ID	"MIN     "
> OEM Revision	0x00000000 (0)
> Creator ID	"INTL"
> Creator Revision	0x20210930 (539035952)
> DefinitionBlock ("DSDT.AML", "DSDT", 0x01, "INTEL ", "MIN     ", 0x00000000)
> {
> 	Scope(_SB)
> 	{
> 		Device(PCI0)
> 		{
> 			Name(_HID, EISAID("PNP0A08"))
> 			Name(_CID, EISAID("PNP0A03"))
> 			Name(_SEG, Zero)
> 			Method(^BN00, 0, NotSerialized)
> 			{
> 				Return(Zero)
> 			}
> 
> === Original mindsdt.asl ===
>   Scope(\_SB) {
>   //---------------------------------------------------------------------------
>   // Begin PCI tree object scope
>   //---------------------------------------------------------------------------
>     Device(PCI0) { // PCI Bridge "Host Bridge"
>       Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy
>       Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't
> understand the new HID
>       Name(_SEG, 0)
>       Name(_ADR, 0x00000000)
>       Method(^BN00, 0){ return(0x0000) }  // Returns default Bus number for
> Peer PCI busses. Name can be overriden with control method placed directly
> under Device scope
>       Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root
> PCI Bus
> 
> Thanks,
> Aryeh
> 
> -----Original Message-----
> From: Sinha, Ankit <ankit.sinha@intel.com>
> Sent: Tuesday, September 13, 2022 4:54 AM
> To: Chen, Aryeh <aryeh.chen@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> 
> Hi Aryeh,
> 
> Can you please post the test results for this change. It would be good to note
> that there is no change in behavior in the OS.
> 
> Thank you,
> Ankit
> 
> > -----Original Message-----
> > From: Chen, Aryeh <aryeh.chen@intel.com>
> > Sent: Sunday, September 11, 2022 10:18 PM
> > To: devel@edk2.groups.io
> > Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel
> > <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> > <isaac.w.oram@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Gao,
> > Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> > Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> >
> > From: Aryeh Chen <aryeh.chen@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> >
> > According to ASL Coding Guidelines - Device Identifiers "A Device
> > should contain either an _ADR or a _HID object, never both."
> > , so remove _ADR due to _HID exist.
> >
> > Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Ankit Sinha <ankit.sinha@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Eric Dong <eric.dong@intel.com>
> > ---
> >  Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > index 0d94472450..4efb8709ac 100644
> > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > @@ -27,7 +27,6 @@ DefinitionBlock (
> >        Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> > host hierarchy       Name(_CID, EISAID("PNP0A03")) // To support legacy OS
> > that doesn't understand the new HID       Name(_SEG, 0)-      Name(_ADR,
> > 0x00000000)       Method(^BN00, 0){ return(0x0000) }  // Returns default Bus
> > number for Peer PCI busses. Name can be overriden with control method
> > placed directly under Device scope       Method(_BBN, 0){ return(BN00()) }
> //
> > Bus number, optional for the Root PCI Bus       Name(_UID, 0x0000)  //
> Unique
> > Bus ID, optional--
> > 2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94486): https://edk2.groups.io/g/devel/message/94486
Mute This Topic: https://groups.io/mt/93627173/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Posted by Igor Mammedov 1 year, 7 months ago 
On Mon, 12 Sep 2022 13:17:45 +0800
aryeh.chen@intel.com wrote:

> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> 
> According to ASL Coding Guidelines - Device Identifiers
> "A Device should contain either an _ADR or a _HID object, never both."
> , so remove _ADR due to _HID exist.

I'm curious where exactly in ACPI spec it's said...

> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> index 0d94472450..4efb8709ac 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> @@ -27,7 +27,6 @@ DefinitionBlock (
>        Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy
>        Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID
>        Name(_SEG, 0)
> -      Name(_ADR, 0x00000000)
Spec also says
v6.3
6.1.1 _ADR (Address)
An _ADR object must be used when specifying the address of any device on a bus that has a standard enumeration algorithm

>        Method(^BN00, 0){ return(0x0000) }  // Returns default Bus number for Peer PCI busses. Name can be overriden with control method placed directly under Device scope
>        Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root PCI Bus
>        Name(_UID, 0x0000)  // Unique Bus ID, optional



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93642): https://edk2.groups.io/g/devel/message/93642
Mute This Topic: https://groups.io/mt/93627173/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Posted by Ankit Sinha 1 year, 7 months ago 
Hi Igor,

Section 6.1  of the ACPI specification describes this (Last line of the paragraph below states what Aryeh was saying):

For any device that is on a non-enumerable type of bus (for example, an ISA bus), OSPM enumerates the devices' identifier(s) and the ACPI system firmware must supply an _HID object (plus one or more optional objects such as _CID, _CLS, _HRV, _SUB) for each device to enable OSPM to do that. For devices on an enumerable type of bus, such as a PCI bus, the ACPI system must identify which device on the enumerable bus is identified by a particular address; the ACPI system firmware must supply an _ADR object for each device to enable this. A device object must contain either an _HID object or an _ADR object, but must not contain both.

Thank you,
Ankit

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Igor
> Mammedov
> Sent: Monday, September 12, 2022 1:33 AM
> To: Chen, Aryeh <aryeh.chen@intel.com>
> Cc: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Gao,
> Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from
> MinDsdt.asl
> 
> On Mon, 12 Sep 2022 13:17:45 +0800
> aryeh.chen@intel.com wrote:
> 
> > From: Aryeh Chen <aryeh.chen@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> >
> > According to ASL Coding Guidelines - Device Identifiers "A Device
> > should contain either an _ADR or a _HID object, never both."
> > , so remove _ADR due to _HID exist.
> 
> I'm curious where exactly in ACPI spec it's said...
> 
> > Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Ankit Sinha <ankit.sinha@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Eric Dong <eric.dong@intel.com>
> > ---
> >  Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > index 0d94472450..4efb8709ac 100644
> > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > @@ -27,7 +27,6 @@ DefinitionBlock (
> >        Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy
> >        Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't
> understand the new HID
> >        Name(_SEG, 0)
> > -      Name(_ADR, 0x00000000)
> Spec also says
> v6.3
> 6.1.1 _ADR (Address)
> An _ADR object must be used when specifying the address of any device on
> a bus that has a standard enumeration algorithm
> 
> >        Method(^BN00, 0){ return(0x0000) }  // Returns default Bus number for
> Peer PCI busses. Name can be overriden with control method placed directly
> under Device scope
> >        Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the
> Root PCI Bus
> >        Name(_UID, 0x0000)  // Unique Bus ID, optional
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93662): https://edk2.groups.io/g/devel/message/93662
Mute This Topic: https://groups.io/mt/93627173/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.