From nobody Thu May 9 18:57:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93640+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93640+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1662959873; cv=none; d=zohomail.com; s=zohoarc; b=Rc5322vC9kYN3MqeepGn/s2Fsvw3+ibSGuDnLIZ4PWnb8rz/CUit8wUoN2CE9VLYXSToud/5+53e6Jc5IFVEqp0rdkvKmjjimdqd3egr5dw808ZCj6TwrmkmHinvHRgYIDEbHhAQ15pfabB7zyQidaZOOrKkT0FAM54XB8IiO0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662959873; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=OYMavo0fE0YT/RnAwnAxOevUqBIXrUtvMmNWWxjrJ0g=; b=apwytiAL56/+HPP2gBlWwA6xzep7maxwXPd/hehNeC2BUafJFUPi7t1WZOytoIqEnVF9FQKE7F0r0+mbzspHnjaBpIuiaEdXWuYI5S4Efl5020Exd/U+vmY+HuRcxExNqE4h9+T0E8QI/lar2IrRPeYAvY/232NG/miTK+Qy7cg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93640+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662959873254665.5714871287036; Sun, 11 Sep 2022 22:17:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id hCfOYY1788612xek6DhgnA2n; Sun, 11 Sep 2022 22:17:52 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.4217.1662959872341173582 for ; Sun, 11 Sep 2022 22:17:52 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10467"; a="384083071" X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="384083071" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2022 22:17:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="705038186" X-Received: from aryehche-desk1.gar.corp.intel.com ([10.5.215.0]) by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2022 22:17:50 -0700 From: aryeh.chen@intel.com To: devel@edk2.groups.io Cc: Aryeh Chen , Chasel Chiu , Nate DeSimone , Isaac Oram , Ankit Sinha , Liming Gao , Eric Dong Subject: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Date: Mon, 12 Sep 2022 13:17:45 +0800 Message-Id: <20220912051745.1539-1-aryeh.chen@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aryeh.chen@intel.com X-Gm-Message-State: RJCXu7AqRGBJCRWRVHH8eUCax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662959872; bh=tQ3mzkPm6+4vj697Nay9cig50vIFaYYk9Ag0dgHjhr4=; h=Cc:Date:From:Reply-To:Subject:To; b=ViLDIf2nbZGfY8341HT4o4lL+j2LyjxSGbEs0ep+tYeiJmvzCkqLjnuTdd6eYyS6RvT mm34CdJwad551eIKwRNgdpkTb8yNOuZ4ecwq84MTDSil//YiVN141ey0ADwO7u8KYCYqN pos/k2YgJvaEonr+fMMJ4BUZkTDtyfMEaLE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662959875253100001 Content-Type: text/plain; charset="utf-8" From: Aryeh Chen REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4057 According to ASL Coding Guidelines - Device Identifiers "A Device should contain either an _ADR or a _HID object, never both." , so remove _ADR due to _HID exist. Signed-off-by: Aryeh Chen Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Ankit Sinha Cc: Liming Gao Cc: Eric Dong Reviewed-by: Ankit Sinha --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platf= orm/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl index 0d94472450..4efb8709ac 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl @@ -27,7 +27,6 @@ DefinitionBlock ( Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 h= ost hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't u= nderstand the new HID Name(_SEG, 0) - Name(_ADR, 0x00000000) Method(^BN00, 0){ return(0x0000) } // Returns default Bus number fo= r Peer PCI busses. Name can be overriden with control method placed directl= y under Device scope Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Ro= ot PCI Bus Name(_UID, 0x0000) // Unique Bus ID, optional --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93640): https://edk2.groups.io/g/devel/message/93640 Mute This Topic: https://groups.io/mt/93627173/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-