Hello,
Some of the patches are modifying:
ArmPkg/Universal/Smbios/SmbiosMiscDxe/
This folder has been ignored by the EccCheck done in the CI in order to
enable uncrustify:
https://edk2.groups.io/g/devel/topic/87268735#83984
Indeed, the EccCheck is only run on the code which is modified, and a lot
of code was modified to enable uncrustify, ignoring this folder was the
easiest solution.
The EccCheck doesn't support the declaration of functions with macros.
For intance at:
https://github.com/tianocore/edk2/blob/dfdba857a6b6a708e754ddb1a04086a3402acdef/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c#L38
the following errors should normally be triggered:
- "The body of a function should be contained by open and close braces that must be in the first column"
- "Function name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters"
- "Any optional functional modifiers should exist and next to the return type"
This is just to be sure everyone is aware of the situation,
Regards,
Pierre
On 8/23/22 12:59, Nhi Pham via groups.io wrote:
> This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.
>
> Minh Nguyen (5):
> ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib
> ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call
> ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"
> ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2
> ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib
>
> Nhi Pham (1):
> ArmPkg/SmbiosMiscDxe: Support fetching System UUID
>
> ArmPkg/Include/Library/OemMiscLib.h | 37 +++++++++++++++-
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 46 ++++++++++++++++++++
> ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 8 +++-
> ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 6 +--
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 32 +++++++++-----
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 3 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +-----
> 7 files changed, 117 insertions(+), 28 deletions(-)
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92681): https://edk2.groups.io/g/devel/message/92681
Mute This Topic: https://groups.io/mt/93201501/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-