From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92667+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92667+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661252520893354.3474510678699; Tue, 23 Aug 2022 04:02:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id whVCYY1788612x2VZhBZfOgs; Tue, 23 Aug 2022 04:02:00 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.112]) by mx.groups.io with SMTP id smtpd.web12.29938.1661252518731396771 for ; Tue, 23 Aug 2022 04:01:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJYfA4GjTRhWT8B9goCkvBqBmtQUH5NGUMwsDGGHwhvO4qcXGThc+I+ySWkOMrSf5gTPmUxeuBw4klPMRxGeY/q0H+/X/n10FdBvAFOyvVx+6K7a5/hRC2nxItVaOniVwfDZYXzxGzmgXYh9CL5aeOk+YS0pNT2MBw/dq1sTV5pwMhu2BwMvQIt0Y5TLMrTM4q+4kGGLa/kEJvGRKotC2khkmeLqnqM8IkzZw29cWDf12kEpRcg+L3O67F7xrkrVwA6mW+Lc7Tz7MnMCe1B8eVBPfai0HI/b6fIoyj1VjHXleLpZ26ilK4RnYg/OaLwCXnkaYXary6W2ozNoiFiKRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EPVeuXcE3uFuF78yRIGGCfFGbxk/DvZwsPKJY8u/QHw=; b=fkJsMgjx28aJ53KnTmgVDQrhBe7DT1g8KWFcoGT0XfE69D+9dSqNeNtIYYczBz+nunYvxeIuYdLChgyYtCSa1X6RKbXoqLKLh3j+q3gHVw/4PfKZClA7A9Zt/D+ew9mlVhO0spzakTVB53wllQq7R9Z/gE1FB2wdSUH+2MjIivzuHk2nL5gu/ehPat1YhRgJUEzqn4Ywp5sLrauXdv5X0+22d1uQ8bz2hBB6nB6NApo99LclzShjCz6uPJLfP4S4v7t5xQsl/Xc31/D9LzMFWXsD/1ND8rscDkLJJ4XQcI+3t82y2nl2HAlXycSckaujH2Ee8e9NgdW9LNtnhrcpRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SJ0PR01MB6430.prod.exchangelabs.com (2603:10b6:a03:297::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 11:01:58 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 11:01:58 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham Subject: [edk2-devel] [PATCH 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib Date: Tue, 23 Aug 2022 17:59:21 +0700 Message-Id: <20220823105926.1379824-2-nhi@os.amperecomputing.com> In-Reply-To: <20220823105926.1379824-1-nhi@os.amperecomputing.com> References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 335fe1c5-1cd2-4488-925b-08da84f6e601 X-MS-TrafficTypeDiagnostic: SJ0PR01MB6430:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: nQ1hivnWF/b1kc+a1bK0RP9xeiwCyFWFmN3TDyT7BfnsnQMXkdGGdDFvTwRQOHLWW8hFBkIlOrecHnquIyq89bwiI9sdB99CESck8hZGmqYCd0SvS8pZkQUmpIzqalKVgyzfEWOfVF+XOqzvx2Ytkz4TkeKIC16Bh7BpVY7ty6yHdHkbuEKgEb1Dbea8pxZMxYJlByXUfMs0Lu5xX9z8gQ1Z2+xby3Xz2AJoSD4WgWg+kLGUcLTtGuufk70wZzRMAEBBoq75Xb359iAVRFm7NeP+flxUR0m5roB4oiqA7Z9DzRdh1I/w9HSHxXTifGVCV5cB8CIjoNNQOr7WddfD+BIwjUEc3CIqfzxjXF2OzfVh9VauWhFHe2ymxFScEtf/KN6TkYrRAyXHStQooZHqBPbn/7wg8dQJuJsLZj2zrbKZDB+7ZrVRHJJu/NOcY+tT3g791ld73lIpjmLbw6AoMQ53jsO9cvnKQbaoc9A0wFYliMmPpPE239IoIljSWsezMpCbTCpR9r0f1WmAMX6AY3qyBQbOwHu608bVlBQ6OOawx5JcZ9R4xQptC5eV+5CFERyQAdYPta8uIP2FiGWCdAhAotyXnbzxAhJwU6LNhY9dg5rc9yenfQhbg49zxL1CFLBuklVq1osko+KzygDNM6rk+mgCFMkSWEZ3J172DoZEla0WHuJqY/JIsFjbmfqa3NEy711l4faXOAUJh6LhlY+9oC8MKSx5fKs/ySJrtmXZXQ+ZxbbvfPfZ+d3ibO9p7CYHPTWrDUKB3shY3RS1AQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zSDUyMbLcYKEWN6vVTioNY4J6AaJW3cDj9LBmF8lkAWbK4XVbk+JFZHxGR90?= =?us-ascii?Q?Ees3gi+JUALSA+MkhbLfpyiA0QjqZLgpS22G0xCY2v6AVqud0IU0MXDwmi6j?= =?us-ascii?Q?lN6DACNPtpyA2wtTJsEhsU5vzfsXkxPRgNW9y/UTfELBmdSMvlRX30r7esCR?= =?us-ascii?Q?aeRJ/7VBybreg5WN9EGXsfWwJ8ixpSlBWOCFSp2me/0FYb0aPX87AmFr8Cqo?= =?us-ascii?Q?mzyMHC749kFtwyLZFolB1VjmYKnHQ/RW5pd4aE+FKP197gWTC3RcLSwI2gRu?= =?us-ascii?Q?XovAENbnu4UlyTtBSUgXtXJyO3JoQ02xOgFhLAYfuRRN8USIIHlwx+vTs5WF?= =?us-ascii?Q?Pc1BmTVsMqLg/qw4DyNQ9zuLpksQcLvqT/hX0AaiH7t73n5ctxPZMcF4Gk2/?= =?us-ascii?Q?cFxRQV7VoutNr/eXBr1nQlyiuR6FLGHxAx5V4qnj+8AgkYIsR2q7QAiMAnGy?= =?us-ascii?Q?xD1BHu+iffb512+uveJVLQRxMuHhxpuqKjGOl6aQ19vxaIKD6YCCeWq4kZz9?= =?us-ascii?Q?fW+Mwh3G6inToNvlOpCgsXDbkbFYrDuC7lZ1GObg/tGRo57ImlPVH/hw1Zyq?= =?us-ascii?Q?27tEKDXcmszttPkbyfWMVnyQ16mo9XvahvXV69nra5vW4tlLEGJGePL5IujO?= =?us-ascii?Q?7cUVpbfSKwDp6RaVHth4SFwBgTgj5/OWE8KQW3b/POp6yOKshYFQvojs2V7Z?= =?us-ascii?Q?v7v0U2w1FdFFbh5W11VtelPEJaR1vZpoEPdvzSAxDan4+bP23PG6yGmI021S?= =?us-ascii?Q?l49mW9RbFH11eEBhZvlWkQlLOFAqbljgiK/gfaGd0inlLDZaZMuUBrGGHAQ3?= =?us-ascii?Q?8fH1zY94+xq4PxRCP8XzTvV/hYio97r0jWI+m52P0KrUtNxcIZzVahU0+BdT?= =?us-ascii?Q?dXGVGYCPsnY4dSulLmV1FlMAWqywkvhHAayOhSKQErkPj691dnE/UDYlb0GT?= =?us-ascii?Q?KsUkYKviRJv2u/DCiASpOfQajVAOFJNA08e2v7HrcI1Oe9vk8i45G9wk1j0H?= =?us-ascii?Q?JwUh/dAkQaEKJZtwbq5AMk1cjw2nxNWmCbBPn/dinQeVPa7z4wHqBjMez45A?= =?us-ascii?Q?WVxD7CuRChlTqWc7bQotYxpo1RSKdqh9Ydg/v874Fpcc/N+szxwTJdyWsArp?= =?us-ascii?Q?QOVqq9nzdf2KkXCeSXYOfy4+EzD49KgXeGCINetK9uMRZN7VlOVoIx6QddE6?= =?us-ascii?Q?VWhE3mf+BHqQO5bp9w/Ll4+PDr1wBTCBSctIoQfH46JGW0OkWvbBynuwKEPK?= =?us-ascii?Q?WI2xD2lTwWMxa9nLtYDwjyyDqE+rX7aleEnPfHt0gWB0P9sEzwSQcxBtyQcs?= =?us-ascii?Q?8ouzRvI7OcJrLUrbUZgGNUoPqBu0rlEHWhSx6R5SniZMc0rY2Hqs5jaFm+Rz?= =?us-ascii?Q?vvZ6ewF/7Gyj+64CCkCWPpZQhtKZvuzGc92VFU5qSoBwkTipPbJmwXgMjht3?= =?us-ascii?Q?bdYBJ4k8FV7eMFmGsMn3jNVfysmjyWri85Cwc3qLrXHXSl0todOwJghuS8wT?= =?us-ascii?Q?Qi/RlCIED72bXk/jUw384w60tTrmBKJMSGpbSOye8C3TkP63q+mMHTBSU2Kk?= =?us-ascii?Q?aFTQ8VQeDc+hF8+ssvWM/JxLhaIYbNi25T0Ms1U/+W4QYauQb9adgcccVT07?= =?us-ascii?Q?RvyV1EVFNEq8QXy18l2THes=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 335fe1c5-1cd2-4488-925b-08da84f6e601 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 11:01:58.4060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DD8N1J/41b38s84JHXzT7x9V+GsfuYPgcdKXApSmo6vRD+JdQOnJjqrXa2rF0JrcoUepaA8WkaKSBELgYGTKLXmsCynyXwh4x/bF53nPmUE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6430 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: 6FjKwThUCH5rJO6NaIwWhPYUx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661252520; bh=SxEM2sSaHzyFanfpTaDUAZACiAnWOSKOOIkBDcMEVZw=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=lTCKKSORTZ8ADcHB4Xury39eyjvteGCZEXQOeXgpGO/xrYIqOJVDsmgW1OsqqVyjKvS 4hC3+VsD/EiZdj+lAoq3w7/cuckhmhY7z468kaFcZSM7uR8c8OSe1sIyT/N/I4CdDQrco shc27F+3OmwVIbMt27TdxwXl8O0qd/2JLD0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661252521399100002 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen In some scenarios, the processor version may be updated dynamically from pre-UEFI firmware during booting. But the processor version is fixed with PCD (PcdProcessorVersion), so it can not be updated it dynamically. This patch will support setting that value both statically and dynamically. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran --- ArmPkg/Include/Library/OemMiscLib.h | 2 ++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 8 +++++= ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 47cb30d84a62..330bb4b014de 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -1,5 +1,6 @@ /** @file * +* Copyright (c) 2022, Ampere Computing LLC. All rights reserved. * Copyright (c) 2021, NUVIA Inc. All rights reserved. * Copyright (c) 2015, Hisilicon Limited. All rights reserved. * Copyright (c) 2015, Linaro Limited. All rights reserved. @@ -58,6 +59,7 @@ typedef enum { SkuNumberType03, ProcessorPartNumType04, ProcessorSerialNumType04, + ProcessorVersionType04, SmbiosHiiStringFieldMax } OEM_MISC_SMBIOS_HII_STRING_FIELD; =20 diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass= .c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c index 0b9af9bd7e1c..524b37b10479 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c @@ -1,6 +1,7 @@ /** @file ProcessorSubClass.c =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved. Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved. Copyright (c) 2015, Linaro Limited. All rights reserved. @@ -512,7 +513,6 @@ AllocateType4AndSetProcessorInformationStrings ( PartNumber =3D STRING_TOKEN (STR_PROCESSOR_PART_NUMBER); =20 SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorManufacturer, ProcessorManu= ); - SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorVersion, ProcessorVersion); SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorAssetTag, AssetTag); =20 if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorSerialNumber)) > 0) { @@ -527,6 +527,12 @@ AllocateType4AndSetProcessorInformationStrings ( OemUpdateSmbiosInfo (mHiiHandle, PartNumber, ProcessorPartNumType04); } =20 + if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorVersion)) > 0) { + HiiSetString (mHiiHandle, PartNumber, (CHAR16 *)FixedPcdGetPtr (PcdPro= cessorVersion), NULL); + } else { + OemUpdateSmbiosInfo (mHiiHandle, ProcessorVersion, ProcessorVersionTyp= e04); + } + // Processor Designation StringBufferSize =3D sizeof (CHAR16) * SMBIOS_STRING_MAX_LENGTH; ProcessorStr =3D AllocateZeroPool (StringBufferSize); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92667): https://edk2.groups.io/g/devel/message/92667 Mute This Topic: https://groups.io/mt/93201502/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92668+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92668+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661252525120447.290466074983; Tue, 23 Aug 2022 04:02:05 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id zpk1YY1788612xvZZOViBidU; Tue, 23 Aug 2022 04:02:04 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.102]) by mx.groups.io with SMTP id smtpd.web12.29940.1661252523145416299 for ; Tue, 23 Aug 2022 04:02:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gsXcr9m2FN4R4dc5lwcjUbyKbJ/ylKI0GrA16n9V3mdfuSV7LcGWO2GbhvpuQfmqVg+wNbpM7zbdXkcFn5zEAzwJLWryWHoqOqoQqhQF8HFGj/bgKb0giqLl+GR/1nCmosZDzuu7Rfizv5+LVgjCFFjLa6oT8M5+1Vos1FX3f5TyuQNfoK5iOVH5PXJ2tdTHrXZYVrNnm7h0cg866kFFBF7CIEnVk2AAIs54tJMRsKXNkXpxZjUgE1l94kacAwZN75HH7MV8T/fgIaDS9hTHMImSt7BP2yNKHAN5y2ZmarrqOpubIcHCA9gUdUxvkNIfyRuTZUwAmO/O3APcu7Q1AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fHPBj1jSA3bzFCqwEyFwq/KA5ecvS3iD15fmXfxLW5U=; b=F2zym5SHwAUCZawoS8So2ba5rdcR970Kv24KLmmqx/NArR+PbWx2x3+hpZs9ZV+QcI7uqbCrdIg/UdzDYyVa6p1BsQoe+GnKH5JsD/QYn3OE/UMG3NqLERqOWzFS1B5ircr3tynXg2g9YzLh9Ei+KvnoRj1nezWxE4IG7zJN5hZi/d4RVPOnf9t5H+QJE9n9oC342SnKZqXjbs/S+QoAcsg+sKrTgepNB9mVkPPcLfY2Z/a1td4kP2OIm6z401AOiunE7HMscDgZusEa9CJq48cTDzkkDU9iz8BZd00vrmjzF6beZQM2BeDGi9rlz2jRtbMQf3pjrH4j9GPd7ciHAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SJ0PR01MB6430.prod.exchangelabs.com (2603:10b6:a03:297::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 11:02:01 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 11:02:01 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham Subject: [edk2-devel] [PATCH 2/6] ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call Date: Tue, 23 Aug 2022 17:59:22 +0700 Message-Id: <20220823105926.1379824-3-nhi@os.amperecomputing.com> In-Reply-To: <20220823105926.1379824-1-nhi@os.amperecomputing.com> References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05753ea8-5221-4ea2-187e-08da84f6e78b X-MS-TrafficTypeDiagnostic: SJ0PR01MB6430:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: BoQyYA25nDv9byZE1SSKn/dIZagHDHBfIFYwqlRL5YUwCU98L3PreV4IQ8cYq65PLEk82WjdJulwP+pBMI8djDpuYnhA07Qc5uNqgZrXIdCrSj5weqbUJaOWOmzwhVX9PxvbdbEzFYmk0/isPBV3+Um6Y1QAfxXs1OAC0sLbF+9cOfuJzRrBKKaVH6JvnJBROYktd7GbZComMX9h+GcLpnkG+FepULFKHF7n0w2IQRLltentXJdxmrW2tJ/qsDmfLjMNPyVOy8/D6YOvyOiqJP15l7lkmUXPv8Eh7t4yKA50G1GMD57ttfjst7m0zB4z0XOyEapjfoIWsJTH6at8zhPyCnPVQSHlu5wACy9fKf2R8qUX/vslvfIMDqL/6NYKp/RXgo9DFhYy7aGBSiAB8GHtZWH5o08MlkkF4k0scZ2d9GBYcDFJgVd90YrotBzWpN984fay33fYQOT0rtBp5D9Pd/5ORAEOkM83sSveGs5jYMVmM55yxIpCqUeYk/wLmLYuhyxJz0JLYypSmg6cXlDBSfbzuZeffFu9bxTY6Seh7zvczC38aBVG5qP9/JU0VxsBweX5sd57422MST1MCDJuCo0aQ8cZqrwLfjMLGNCTyrMvFV/MPd7OM4ww9PQPkZ+Opzhf3OoF99DJGgpUMGtyvlsRMunSxNMg7Ldjl15A+IIfZyJR+EOfsibqS50H1mML9lq7bV5wvi3uxv/3aSsV4+B1zyWhKc1ACAkknmbs3uW4C3YyEzXUE9z99UV/pDkCKPqWOWFf9B+vLdna/w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4dAVryDZ4pbS4WA0qbbsuXAfjMmJUVg9kN7zrlAYmjuIR5Ks1EBIVblFCz7K?= =?us-ascii?Q?oQ4nn/NIOutl0gHhjt/B3zeAPtxBmbE+UHxffM5qk8X/lHxkgppHMc8KFBiO?= =?us-ascii?Q?EAuMVk5vxYEV0e4rlAK3+MERdtkiFffcVSJuydixCZ91R3wWrxxetIs9sqfu?= =?us-ascii?Q?t1XSQ9WeabIExHGSel5JECvOTY7eHVWcQexTP7fp/Y04B5pc3dH2PZt/komT?= =?us-ascii?Q?S8k3VFYYsb0fhQBAh1o37Ci/4i+cviaUtyCNbv8nQ6J7Wiq2bFlcmNAR7okX?= =?us-ascii?Q?rSvx3Uip9OKSDK51ixLcFPdvASwUHFukcvdKlTLULFha3OXfjQRI9Odp+v9D?= =?us-ascii?Q?YyOpVuDruDXpHXPBGjU/Yz5fvQXXipwVGX6lDRr3SPPj+9bIwes9Dh1tsICV?= =?us-ascii?Q?/mlti7b9NOvffEkiNVqwtdzaqNxD9MBj0r9ZwVP2gFhcqwIg7/uWhQdylVMx?= =?us-ascii?Q?gimEd0MgjtmdDKzK1w1KBgq/DsjoIHsEeoiKZJGOlDq10EbTYQxz0FlLpjiU?= =?us-ascii?Q?48b7sz9FBZM0PA4rwMVAJo8i8lNUxXL+YXOJ5yvwYJQ7gw4I9uxxHB5GR9P8?= =?us-ascii?Q?MbL7Wt0tCR84vacFnz2RKJc/Wbk3I9HOBzgpZpmJAxVWAV1ci3B6hV0vRX6r?= =?us-ascii?Q?BRulIQbU2Y0ABdsw8SYMR6NewvEN8R7iw1ktxyLmJ0OT6Dfolpg8nlL27qAI?= =?us-ascii?Q?QWTFns7kmu0VIxERRalOWIsRkTXUtiJROgPdqi2UX1gbg9C1SHiISzV6GOvf?= =?us-ascii?Q?apt3Rr806NqjkT55ABrLJsfoEgjEBrB4xSVhco2BRnb2VGRkppBItVvFOPWp?= =?us-ascii?Q?HK4pu60I8CG2qJQ9NPKsa7szYMuzGG6/kpDOgxNKOxDga0JOm3ySAUs0eW31?= =?us-ascii?Q?5bwIx677naVJcgeem+Z4q9WKLLi8G/B8KYQwKqZSgLKvSujTdEIbOzUsFuiI?= =?us-ascii?Q?pP8VrYEutviZ8fELxjTnO4qQEm8qZ8rxuskKRkqZcl2y7xr47ttfI+DigFUz?= =?us-ascii?Q?vJYGSU99XkR60RmFTOrFHSQmj7Dz0/y7jGGf7XLvpWu/tDesr/RYGqm23df9?= =?us-ascii?Q?7yde8v8YdHncABBjljhGudv8z+yLUfzKczFE5H4kC5kVHVGj7cW8xfeTGJ/O?= =?us-ascii?Q?1+ioEzsmF5xUBwlofodNVc+klLIhZ8oln5StcZ95wsJyVSSmDpSEvJI8Q3p1?= =?us-ascii?Q?BVsBX1fe3TsM9XUEbsz7LLl8ulGc996XXIerj6r77PCikFzMFPJLjFbIZm9I?= =?us-ascii?Q?3oPXPmPqX9Ciqtt9vjz1QBMVWfwsyTaCaznX3jRFcvJ3tkHucQ+BBI3zYJRD?= =?us-ascii?Q?guXoB/IAz4KtxBs6MAtbdKrjC2xzhezmJ2mf28ACEctJjbhVXENz53reXRDw?= =?us-ascii?Q?+g5F4ItVSTOQhOHjkUEsab0t0RIHZJ7e5qxt+JNITUyDfpjx8N/RFpVCfcIW?= =?us-ascii?Q?M1t6Y2U4N2svUpwzSguJ3sAvm9ngMCV0ffHhDttCT850iKyOlwXGgtFcXxh5?= =?us-ascii?Q?VXUUO4tRqvdjPJ3qdzRkY6eo0zwgALVHlHl+EbbVufT2gJJIJouk8udsdcbp?= =?us-ascii?Q?3R3t7QIb8PqSqBcqcNmd8C1Y+SJqpIXmshA6gnsvqhrWj5KBC+Y1BSF6T/JD?= =?us-ascii?Q?EZAByqY2/a/PA4d2etcuz+w=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05753ea8-5221-4ea2-187e-08da84f6e78b X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 11:02:00.9695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o/w8ChcFC0SlOeRV+IsFJ1fvHHgqrZe5jUC3k6gbFYGV6Dx3kKw7vke1lxPkjhSYgrAQqn91iR9cyULzZFlwRE96rmivE5gTlF+YbC7iPoY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6430 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: O4Qgxb4MurRywZDyu2dCWov2x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661252524; bh=J66d9hLms2A70hsY7f2e2UgyZfKId1hy8Es0FSqK73M=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=TSjnNUoqdMjiaQsOsZFGjbajhOxZDGQ/3w2rrevXWk1M1mIPW+c3EQUAAaNtBIJ0CR0 tfktWYVny8sB054lDTo1A34A5OmBGFSJGrvfTyOq6QCDnxShc4WNcwyZE+B0MQc9e0tCL 8V/qH6W9b1s8apcQoH9P3dqGmJtN8pgyIV8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661252525597100001 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen According to "SMC Calling Convention" specification, section 7.4, return value of Arm Architecture Calls is stored at first argument of SMC aguments (ARM_SMC_ARGS). This value can be negative values indicating error or positive values (including zero) indicating success. Positive value would contain information of respective Function ID (Section 7.3.4 and 7.4.4). For that reason, "SMCCC_VERSION" and "SMCCC_ARCH_FEATURES" Function ID calls read return value from "SmcCallStatus" variable (Args.Arg0 - first argument of SMC call). But "SMCCC_ARCH_SOC_ID" Function ID call is reading return value from "SmcParam" variable (Args.Arg1 - second argument of SMC call) so it leads to unexpected results of "Jep106Code" and "SocRevision". This patch is to correct it. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | = 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorAr= mCommon.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm= Common.c index e0010a40e489..b961be213358 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon= .c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon= .c @@ -2,7 +2,7 @@ Functions for processor information common to ARM and AARCH64. =20 Copyright (c) 2021, NUVIA Inc. All rights reserved.
- Copyright (c) 2021, Ampere Computing LLC. All rights reserved.
+ Copyright (c) 2021 - 2022, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -131,7 +131,7 @@ SmbiosGetSmcArm64SocId ( SmcCallStatus =3D ArmCallSmc1 (SMCCC_ARCH_SOC_ID, &SmcParam, NULL, NULL); =20 if (SmcCallStatus >=3D 0) { - *Jep106Code =3D (INT32)SmcParam; + *Jep106Code =3D SmcCallStatus; } else { Status =3D EFI_UNSUPPORTED; } @@ -140,7 +140,7 @@ SmbiosGetSmcArm64SocId ( SmcCallStatus =3D ArmCallSmc1 (SMCCC_ARCH_SOC_ID, &SmcParam, NULL, NULL); =20 if (SmcCallStatus >=3D 0) { - *SocRevision =3D (INT32)SmcParam; + *SocRevision =3D SmcCallStatus; } else { Status =3D EFI_UNSUPPORTED; } --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92668): https://edk2.groups.io/g/devel/message/92668 Mute This Topic: https://groups.io/mt/93201504/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92669+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92669+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661252527035204.83613763142466; Tue, 23 Aug 2022 04:02:07 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id nUKlYY1788612x1dnzaXeMFx; Tue, 23 Aug 2022 04:02:05 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.121]) by mx.groups.io with SMTP id smtpd.web11.29903.1661252524820895995 for ; Tue, 23 Aug 2022 04:02:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lMw/eH3dyN24SdkFGTQ8Q6VJwO+qPXbbxBheGA3B6+yiM6oKMcYbOasIIp4eyATuDwBfhSxDCrkg36juQWL2IB1Y7lMSD3IgMOT6BzGnQOLArqygR7+X4CXIiMx+9auD10OXB2lrSm0hTg1nUJtCuR2rrcrPPcGcAyDQk/OpO4leybza0xptJ7z6FgyjOD1CiWqbMtlJvDNF7tng0Ziu0PVzdac65c7rceIKphS9RyF8h5NITUv08oFX/6mkYu44/4n8bjIk+wbRwD845NdKS1CPQuDOEQ0j8dyXATqg1Fjac8i6usxDv1pvSplY2iXeMSYimDQhjD7fM89LfiLdiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDLmB2P7TVKzhxn4GnrSsDx+ULiXVOajlU640cnw7Hs=; b=ABv8eVeSw5OIbS7UqpwliyDncxlouy/aUNEiFt+xFVgkPQbg4F1PbbjAxM8SlUeexIGEzTrpkpxyL+2lP5ud4JiwFxNspIJuB68b0bnqfqrGoDH7cy5f2Ad4vxDIVs4QXSceITzC+uKMAEJpcnrvfjLUDY9xrh/m7qy9k22QAlEHtKwgnon7D4QAzKQU41rHczccaT5dxYDJfEze6P3AGi78q9oAjtG3H0KodQVhzlvaAZG6PXPDl4dlcvt2ELVFiuKIizsmsggyG/tDsFgf7cVJzun9A3XKd4wbNtaG79SZehTWYURkRe+KC9Hz+6ZlolSLgU3IqR7Dr7jB1CmmyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SJ0PR01MB6430.prod.exchangelabs.com (2603:10b6:a03:297::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 11:02:03 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 11:02:03 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Nhi Pham Subject: [edk2-devel] [PATCH 3/6] ArmPkg/SmbiosMiscDxe: Support fetching System UUID Date: Tue, 23 Aug 2022 17:59:23 +0700 Message-Id: <20220823105926.1379824-4-nhi@os.amperecomputing.com> In-Reply-To: <20220823105926.1379824-1-nhi@os.amperecomputing.com> References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 609b6841-63d6-4288-1fb0-08da84f6e8de X-MS-TrafficTypeDiagnostic: SJ0PR01MB6430:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: T5xqephkVBe5gNcWXa0O05VevtynCtpwrrhCrO6LZV4EWecAJ2gI+sYnlahQMXkmFnT4WPvc1wvzS9f+S8dKWqB3alsF815+30Y87H0KEwwFXRSAM9DKDzyUZSFLxGBsEpGpBFucX7JRSqWUGKu07KxnWamd2Z4ucSuPjLp9/xRx18DQ/jbsZGZiGDH1Fgjc/20daDVji2pR60HyrGApm3PS3CjUrs0oDzPDfRyeypFKlrrycgpyaKBVVBg1n8H3MZzlmKK6jKN2rPICcW+ttPjtOtzcodOwNPom6we6yeQcqNodP/1Z8LqOswOSfKR1geofdFBZPuknvQe7JgM6Xd16cd6TAWGgHBS5nMUG57Rkm7ZtboLUNuXs80GaozjtgMBc0/prPnhOEGif0o1wfnSWXp0IXQ6sUnKQH0foI4W2oq5snqw5y8XXKUjxK3l6cuNr7iqAsuJugVJqB04N6xQjuVwk9gnEMq2Myl4m2nztKi+pK8OzhOiWiXFDzpqnzczJDg5YXFIVw+0zDgeVQqOCcIAXhVa3iECF1QEOv7V2NlP6x+UOHEfOGuz8OBcMH+3Whe7G131c6Sx2kcekJzBsuLTrwtWLvbXwcMfNtsFhRp44rgHCUoKLjZmfKnUO6jUkJ5uoVRjN/DRX9uRsHaV0qKJMGLEUSSRJuS1iCbk1SqZgBg/jgO6xkH9ODl3oZ4Q2tq0/cOFGZugOBsH3aktTYtVtophPl3Z5F4x8LvL1kw1uCnJ/efQJi72lVnQcbo8C43Gr4po+el4IWnuFvQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RTCShh3hRsvDv1q6RkbdLKjmaO8r92rMOEuhJdlz+CQCJZxQkTRfGBfUnSDT?= =?us-ascii?Q?LGjBs1WRJ1DMiYEXIIBJqYLlBOIVcQYfmEb3MeB08iMtzvU7k4bXHby7b3Fw?= =?us-ascii?Q?YgXHoGyDnaGlYTs4ZdAgkfW752YKSQe2BFd1+g7KWp6InELt+Z1FY9xTwt3T?= =?us-ascii?Q?YjCPRHRnWoUMNuk6dmB4uVu9ceXAPo/gssjGV5lQnl5zizBe+bxpH6vw53rL?= =?us-ascii?Q?mF7whQPAzi45ToMASNuIuPbLzomX1xmaSd9yyQfwrSN6cwTsYLrQalZSq+kM?= =?us-ascii?Q?uu84YhISHb/AoadT8SogJP6Y2xZUlYGL4OXpJiNBqNqksRzS2/DMkhZwetdo?= =?us-ascii?Q?rmiePXeucRehj0t5L/7Xhmt3Y/r3PGYALUG1RTwcf6hfdC9iY0Gwo2xvc697?= =?us-ascii?Q?QJhd+0FUtGgfactaPpi3EmH6ThqMWXJ/TBcnn2eUTHdKp2wmG6pn07m6mMlu?= =?us-ascii?Q?GU3tBajzK3izm22Cu2srPhP96B2uvah2KszIPif9Cr4aS5zhXdsHsrKtwYlU?= =?us-ascii?Q?UhBgfd/PIbMxabmd+QAZZDAKSYC1irSa/6I0i154/CaIotMt48fgtBOSvtex?= =?us-ascii?Q?KtU2vwQB8PZ4pQ/F2Ci+o97R9KgkCprt2VvM/wbhTKb5pB7ucrBOOY00a9ap?= =?us-ascii?Q?VVE7fOZp3kmv+wxrLwSD5T2WySz1Dc2eC1kNvztPRdHNW2S9vyMm3ACVKdud?= =?us-ascii?Q?SAXbE9/kemaR4ZcBNrBylgSO23/+buEjfSGSCHOSrT8/6GvvJBfR4Useha8S?= =?us-ascii?Q?OEPd/UloockaIakEcXsaVUT80C/Xprro2nG5qMuAabcK4ek6NpBQYqNpKB6t?= =?us-ascii?Q?ffowD+/iFHPkxgSUri0PDCc8phOlJuelyv2xvZQucztJ0laukVl+v6jTsUwJ?= =?us-ascii?Q?XXBC2f178gNeFfhjtwzqkitOFNgDD8fu3tStHucfb0pj/Sp8IDl7Wteh38LY?= =?us-ascii?Q?oyqKX1Qn5IfbqusaT3EDzttD0zWtavMi6JnKJLytZeGtcRrZLPX7AtLn/nFH?= =?us-ascii?Q?dAHwGdOgssD8BhuklnKKkxoYWTdEZVk1QKGBhaH4KzsCdqgwx0OPu4hpaLUW?= =?us-ascii?Q?Pbe7wydHAq3NDGIk7YUdgS/uBnQ1UAmiEOog2tVqAbjBB2lpdHVUS4DKQU81?= =?us-ascii?Q?cwDCIPIY27ISclmv+8zSV6PWZtepSFOJXjGgkIo0xG03wS5P2JqsDZPVC4aH?= =?us-ascii?Q?bzcoIB+j5XhfKKTs5bUby/vYx3cMFPYD0EzWzPkGCsWA1GJxJmKUjRqvAla1?= =?us-ascii?Q?y//SUZopiLejMyYKiNdkcV5j0o40sDFfKqzamLTJSJ7ZZQUbjPLVJA5spsAi?= =?us-ascii?Q?Giq1yY2mx/xi62QApcKdZShexa5f5mpXCiGmua/o1blit/VsReIYM6QurwaW?= =?us-ascii?Q?TceBkPEIewrf0WGUErm0LYXDbO75li2AGXTeDITzPp9GqmMTi+XOviWqBWMf?= =?us-ascii?Q?OzPWrAYDAdiX3X3cEN0892QSWwO2VqWXT9gryRlHUDeZ2iyZAenOBa54Dkyg?= =?us-ascii?Q?c7DTD10WWUTlqZuZdRLG6mcMC2cLJWCOtEELlgWi1DqkePtWen9UHvxyKAmS?= =?us-ascii?Q?Ai5SJte180xh6dRsujmOWm6YUDyl/K+32z1Ci1MiE0TDLxyXqcUcxaUhCIzX?= =?us-ascii?Q?X1BBUE8X//FqOpa5Lr1Re3w=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 609b6841-63d6-4288-1fb0-08da84f6e8de X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 11:02:03.2103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fytcmHI6tlwcIYdkbMk64fXOKqNpWNo53CMHtkFnbygowcaGYOS5HebmadwZhwy9g21XQutbKwifMaeY7J8uuj1xZa+/r70Htx5lqY4Ji0A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6430 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: qrhaVJWBozqqia8Sv97euzxNx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661252525; bh=9wLymGekeuOutllrX8xIckO5dEbsPyM3N5MnDjue9uU=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=UN5eCOA3EgGObGoWfS5tw+04fzzYJTPxV3OZoqLNCN/1bpw9LuUixbNInv2YpPwTc7b 8Zbq/UQOnaFk0kH0PreEQaZqdIRZXyHUDYsrqyzYXaRtIiJJq+a/TZr5E687txjel5W8o irezd1qc/5k1zr6r3vVm1la1TaSKqcsUR9U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661252527505100007 Content-Type: text/plain; charset="utf-8" This adds an API to OemMiscLib for fetching the system UUID according to the platform. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h = | 12 ++++++++++++ ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c = | 18 ++++++++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunctio= n.c | 3 ++- 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 330bb4b014de..d87737db9c2b 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -235,4 +235,16 @@ OemGetChassisNumPowerCords ( VOID ); =20 +/** + Fetches the system UUID. + + @param[out] SystemUuid The pointer to the buffer to store the System= UUID. + +**/ +VOID +EFIAPI +OemGetSystemUuid ( + OUT GUID *SystemUuid + ); + #endif // OEM_MISC_LIB_H_ diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/U= niversal/Smbios/OemMiscLibNull/OemMiscLib.c index 98970407a65e..32f6d55c1a9a 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -1,6 +1,7 @@ /** @file * OemMiscLib.c * +* Copyright (c) 2022, Ampere Computing LLC. All rights reserved. * Copyright (c) 2021, NUVIA Inc. All rights reserved. * Copyright (c) 2018, Hisilicon Limited. All rights reserved. * Copyright (c) 2018, Linaro Limited. All rights reserved. @@ -10,6 +11,7 @@ **/ =20 #include +#include #include #include #include @@ -236,3 +238,19 @@ OemGetChassisNumPowerCords ( ASSERT (FALSE); return 1; } + +/** + Fetches the system UUID. + + @param[out] SystemUuid The pointer to the buffer to store the System= UUID. + +**/ +VOID +EFIAPI +OemGetSystemUuid ( + OUT GUID *SystemUuid + ) +{ + ASSERT (FALSE); + CopyGuid (SystemUuid, &gZeroGuid); +} diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufac= turerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemMa= nufacturerFunction.c index 5cf72644d0b2..22fb5eccaa63 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c @@ -4,6 +4,7 @@ =20 Based on files under Nt32Pkg/MiscSubClassPlatformDxe/ =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved.
@@ -160,7 +161,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscSystemManufacturer) { =20 SmbiosRecord->Hdr.Length =3D sizeof (SMBIOS_TABLE_TYPE1); =20 - CopyGuid (&SmbiosRecord->Uuid, &InputData->Uuid); + OemGetSystemUuid (&SmbiosRecord->Uuid); =20 OptionalStrStart =3D (CHAR8 *)(SmbiosRecord + 1); UnicodeStrToAsciiStrS (Manufacturer, OptionalStrStart, ManuStrLen + 1); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92669): https://edk2.groups.io/g/devel/message/92669 Mute This Topic: https://groups.io/mt/93201506/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92670+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92670+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661252528851252.897019238064; Tue, 23 Aug 2022 04:02:08 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 3EvJYY1788612xVN7RFWxQrL; Tue, 23 Aug 2022 04:02:08 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.112]) by mx.groups.io with SMTP id smtpd.web09.30339.1661252527641252506 for ; Tue, 23 Aug 2022 04:02:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRIaUsWlY3LnyF0/DlpnVloEmOQHkIHY0dqvGdwx1d/qGBaQvKasIzaTRVmkZgkFOsJtREVr6tH4pNGqpYWYHPKuyX6wVGWEziKCQVnbN2ksuZIdNCHfHw6Vwf51ESrx/ehip5r0jiYC5YJ3vDeMojZfuCnuMjf0GmKVcye8O3rEtHdl/4zPSnVO63YgnEL2rColYXXLq7x5jk9PA8mhAKmX1Hd5PwGosXC70UAv7ZiNcERFqQcyGEmYuGZqnWlvNLp7V01I2SLKRtJKnu73kIa5sRczVUD4bGZxARLmSJo9Vlbd74wO394u0EiWKGrZXObRNHTLvuVRsJeA1ZEfXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EmSIZ3zK4an4Th/CsE5HdW0jSA9sLFK1yScnCACzAeQ=; b=GKWbWtcu85sICLp4U6+qWfwI+Xj0dhYClDKqH/5kSVh0CubiDhTf+DEKCYsh7ZkvqU+a+Rag4aCAwrkS3uGcEtwXfwD6xCDp366bv5kBO4VOiuCpIt7JMDMVe81LIB1ii6ebz3VgG7BgHdNRdDJcIUU6rxvu5c4aWpOk6OPt3jBHytd/+vYeJTruIm8n0onaWaFAVLyxAH1b6zs1hBgEJn6B7S9s+FglW7xgcdxWG7YtWPT8iWK/73cUVmnQnYrF6XYOnwOChj9GiRajUsmTXuyTgQYkHYufU4EH2DYmhg1zNSWLNQKO3HhG8zAVSYXmxz9SwqBktblSBhR/GsHrTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SJ0PR01MB6430.prod.exchangelabs.com (2603:10b6:a03:297::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 11:02:05 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 11:02:05 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham Subject: [edk2-devel] [PATCH 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" Date: Tue, 23 Aug 2022 17:59:24 +0700 Message-Id: <20220823105926.1379824-5-nhi@os.amperecomputing.com> In-Reply-To: <20220823105926.1379824-1-nhi@os.amperecomputing.com> References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5387ac7a-b8f0-4c0f-eb4d-08da84f6ea53 X-MS-TrafficTypeDiagnostic: SJ0PR01MB6430:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: gaxAEzOYqfayNCzZRceGGpJMeXjV5rSPyIHWGMniJxKvJPqXrP8uweTb/0hvp6JzA/4/07Nf9WGR6/a1cyF33wpXyRwW23wKYMnxAL+msxmuVBNs/SLq2HS/e3xHgzZLFGHevyw2TCOkHnFM9KlH/FNGHlVAyPODEeLt2SJTRsyV49gZoiTfWfxVN6Ihq9wGETT1Ujr2OqnlpjhAliZuJXNmtWpAPscvzQoQyEt7ysIl7uWBhQhX6PH/WOf+CKPR2A2NpDaDRmtHYhv10vuYoEBZHgIjg9MZFgP8kEnuCl/fZOBVpElPLluByHf6SaE2kHAJP0GUOjSTTqSijd2Wca46VBPYjVm+rYJtBN53AoRHgvZUEk3rHTlt4XIxQc4BhbgQUwUGg//8v4XrpTBe3v9i43vHnvtTabhDuZyHsShJbrDP5Jby3KqBq1jtYtj5j4wzULnFKKptCNc2nf07NH0Jiicg56WEgg4hVRab0dNYXv6Y4eCeICklL69Qx063Ds/C2XaG3fl+dP09Uq0Ku+MKXWjRsSX9XV38piJ9YCCEEjqW0YDjNEfDQsJhZtki7u4XusUvHNmD0PR8EJUua4/xGJUrsBG3c25IUnVmGH+mGbMwMaODH3W681c+Bh5VcfpoGVuTveFuNfAoJW6r2HU4B81cQpAO1UJwtCBuljZL8s/aWgLaQR1FeVhZPo7Vyml4hRSnkz60yBWleed184n6TGDQ53ER7KFfdfyQprjXkrQIsSzg04YyZc9bUKXWekwqmuj5HVcXu7BpVGb0FA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mFK7kxU5Ja1IDDBoG8TYbPqZGLrVZqjZbfGXiBM0hAuXLyLpQdbyMCXqmZcn?= =?us-ascii?Q?3d3IMM7y48t6lLSIPX+fQ8tMwdlLeX6RBMvZjbSgtZ9glDnh5yogxsOtMw9C?= =?us-ascii?Q?uXQuNRtubUHaY0vK73/GHHDA3zCzLgRx7Y+MjCc63GcMJYr2Qvq+GZOOugVI?= =?us-ascii?Q?bhcKVLByOU4ipGCI0czhucs028CaAhrNVYpWFcX3jwd1Xel1tAV6ED/17Ve1?= =?us-ascii?Q?FXU9yDukE5X5i1+7J7VsxAxxglK01VP457/7ojYmZ41mGIuR7Kux7CEEKXg0?= =?us-ascii?Q?jC1QXJHNp5wXFjV4lHPhdYa8HDuXv1+n994aF6x2yYjyuAoXe4NEW0Jnr1b0?= =?us-ascii?Q?fikvChsktaE6YuJHg+vm+7VpayC2GRqd+q5ocaIdotDlBI01/YwZeq1M0SyQ?= =?us-ascii?Q?dComhOR/3AgCx8l9ULgLWo8ZcIBydGPTgYixw/NSLMmNpzvUdVtDu/soljSF?= =?us-ascii?Q?T6m+UtzAE9PLaK9tcWqj42dg+E8f9Qc3yi6B4PKv46geDcbUa+bqdeMq2rTt?= =?us-ascii?Q?U80sxTsI5EdiBX3J+truENDW7I6phAUrElftoC4IhUvOfnG61iuMSUzLkgrf?= =?us-ascii?Q?r5uB1ujPYLTXA5heBDi+MQ4DhYNR2rxGgbGAglSpw7Zg6D8UQ4iogPzyKRMo?= =?us-ascii?Q?xkJ6kaRPwENT2ihcudj4k3+4mHy53+Tgqr9DCk/mPO3GUMyHmOFYIT1j/V+Y?= =?us-ascii?Q?EkJ4K6i6mqZGdPciBBF9t6KMpRmI5gR+aDFerK79vM8j2vpzvY/islSJ32ve?= =?us-ascii?Q?ycJ/6K7onU/kkjsZE88/QqTourQISuSqNUTtc2MX9avE7fgb55I4G0Wv6Nj3?= =?us-ascii?Q?dRyjHlAJoB5nqkp1WiUxwLA5tcsMgXAc2Pr7qEBuM32gfxC8Mq8qZPodaSWb?= =?us-ascii?Q?VD5Ao+I4PRvjZ0LS4ZS7MbnBlk56MbeCGY/16qTIvho+ELQoM4lsGo0EEdGy?= =?us-ascii?Q?gaIoaNiGeRtwYtVha4E9XyLjxM7983122LFvK2hpuiidZRsrF3mC1zxkVzVu?= =?us-ascii?Q?egfqh7gWqb/ByDiwUlArwIzj85KPPBr5FHqNdatpu5zehw3vQC6hC4nNMUHD?= =?us-ascii?Q?qpFP3W0terQF12GBxn+8jXh3fFGCl3QwtshDv0bBJVhlzlmpLrord2i1t7d7?= =?us-ascii?Q?tQUv5haFRJIUbAx9hnHsp2j+Ax+A4I8GeXKxZc0mebLAD4N0tlQCzgQM2QC6?= =?us-ascii?Q?7u9HWseD+XE2hMzyIIj9CinOGOtSp9IwmgbdklFixTQjpINzri9/ulkqWD5s?= =?us-ascii?Q?C9qCT3typ3Tyaw6SttdZRw9y2WyI+Ypake4tT2XF6ryEz3Wbe232wkgqWRgr?= =?us-ascii?Q?CHSBlwzmz1JzFf0gqlkpkKzkZUxW6YsxcaQaXTsMGdPO175RIIFL7PavHIk6?= =?us-ascii?Q?IuZbY7JpU8ulY+abra0K6QcFALRl3ugs2FVneliqmvv/BUUR0gbXa+aPPvyY?= =?us-ascii?Q?95mvvZ4POXUHO56aGNHzcs3H0ER4FoEG+o7R8G+Bw8sFULfPzhruWuEXQT4F?= =?us-ascii?Q?WYjqWk+5vuhbIWFs3RYQZuw3lknCjftFhkOh/XM0CjxHzOvBrC8N5aFtnqEK?= =?us-ascii?Q?uDF/QejAMyNveG6+89LV3yiDCbA6A+luEkDLnPxrTVi0lHhZaKr/rkg+BopH?= =?us-ascii?Q?NdZLn8tcIzqMagPk1KYOuik=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5387ac7a-b8f0-4c0f-eb4d-08da84f6ea53 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 11:02:05.6410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tZnfNs636+n5SBV8ISxRIzD7kt/kLykz6WgY9VKKwBFzXnIoV7bGrWjW5cCYa2oOZYB1SycPW8C90xPjLt4br0QhRzbrsLklPEKPMopF8yY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6430 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: JLesP7UpzECTRmg5ltNXnuL4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661252528; bh=NMSsJw03RB+DD+Dm62VPSmKTHiuG2fzdJMn+lYx1P28=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=HZEZWIa2Qy5iIyl59KVHXDz0taNKzsn8+Hk4urm/JWp5mOuNPHm085Ty0Axp1p3Q7Mu eYx86pGvPCp7JBiYosuNm/9g8DUOoPXby+8Txy2hkjhghfQlpiCVrO6+wU8V1AniZhIzP 8jrXvrsqp1IwIkvD39AUqloAx91V5t6ShVM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661252529468100009 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen This patch fixes typo from "AssertTagType02" to "AssetTagType02". Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h = | 2 +- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunc= tion.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index d87737db9c2b..1936619d9b5b 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -44,7 +44,7 @@ typedef enum { VersionType01, SkuNumberType01, FamilyType01, - AssertTagType02, + AssetTagType02, SerialNumberType02, BoardManufacturerType02, ProductNameType02, diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseB= oardManufacturerFunction.c index 870610b17243..f61546955f12 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c @@ -4,6 +4,7 @@ =20 Based on files under Nt32Pkg/MiscSubClassPlatformDxe/ =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved.
@@ -112,7 +113,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) { OemUpdateSmbiosInfo ( mSmbiosMiscHiiHandle, STRING_TOKEN (STR_MISC_BASE_BOARD_ASSET_TAG), - AssertTagType02 + AssetTagType02 ); OemUpdateSmbiosInfo ( mSmbiosMiscHiiHandle, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92670): https://edk2.groups.io/g/devel/message/92670 Mute This Topic: https://groups.io/mt/93201507/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92671+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92671+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661252530982427.1733787098955; Tue, 23 Aug 2022 04:02:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id UNhwYY1788612xa1zc5b8CNN; Tue, 23 Aug 2022 04:02:10 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.98]) by mx.groups.io with SMTP id smtpd.web09.30340.1661252529808224870 for ; Tue, 23 Aug 2022 04:02:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LSxIIpuQWQ14yv85g/JFhfE1K9nwFc8C9DRbCpT0zSplNAtO1KvYLujDOUc4GM9o4WFzjbWzFvnTC4OKtuUIWousEph+Mffy+dF1GgQe+3UrC8xGshgTEKBkUm4xUNWBrzcD3hO1X/2GLCli6V7HbQCPDWciMPfvE3Bi+Nw5nUg7J8RwsTIt2nKm+so8GSIu6rb5IZvEXwWetmXWdOHyKVJTISNFfk2sHCB+lbQJck290YmxGR5/fM8PaI9wYAbGOYcD1rtNH2QCGZq6IZmXJJ1xUwrvT6O47wOAX4ccBrlLXkJQApzRmpBWGaMn7u74o31GI+xvCwOSKzAqIWQD0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K0z2NMygxRRHbj/UCsJNOaDDKp/d4eg6KvJCGKb5QxE=; b=I7yYeUtMY8sHVpYNvQ3FiA078qPgplqbb5VfW63pDUlpCBOaM+/57kNnolRa/hWUJYj3w4s0WdWazKdljnfM8K5LacXx2P3xHBHi+GjFG5IiULlGi9eivhfPF7u3e8rD5g73CXB2Zdp+7lo+lOfTe6yOAF3UdB2Runzwznc4xkoKN8cvU3RL8wu1gKIblos3NFTLFFyvYYjQv5sTLUztnDrDwsEJGv3lQQmmlloX4DfxoEqpBfaX1jzDsFTpwdDtw1jjqyNOZyrlrER+BloKwHhmaMGbiGk7AYdg/io3c7AHsX0doZ2d8nyFFGx3O82SLG2cCqsJuTg1LqR7gy/log== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SJ0PR01MB6430.prod.exchangelabs.com (2603:10b6:a03:297::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 11:02:08 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 11:02:08 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham Subject: [edk2-devel] [PATCH 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 Date: Tue, 23 Aug 2022 17:59:25 +0700 Message-Id: <20220823105926.1379824-6-nhi@os.amperecomputing.com> In-Reply-To: <20220823105926.1379824-1-nhi@os.amperecomputing.com> References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 06405fed-9d54-40fe-fa92-08da84f6ebc7 X-MS-TrafficTypeDiagnostic: SJ0PR01MB6430:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: U6hOR3YTF0bkt+37ymw0QcUjVQasPZYyA4VPzKa1OQf/pWhfqVOluOhIwTynvxPSz8N+kxHi0CLBA688GS0AaYsIo2EmKD/Nqb2vRXICPR6o7iZ4P6oPZPK5NNIwNri+EIyF9G79j4nx5MiKPWfeEaGoPQqM2mY0bM0RUt/IHaK2WVYPvWr6Bt1YZebZjnVKe13xhMvl1qnn6JBtJqADw6FJqL9H72dhmGZdHmUtH8Emvunw6zvl6Zqg8+JPngBHqco0RFRGk4tYMhTlWEfPaiGLvV5m3KTrltazPYXX4xYCmnCE1D442437mfD+3MIvJl21nSHcQKGPOlSTxdJo9erPfCb9ceJGT6EiyZwQyBkiUb2S/qXf6uVl2/yhrO/Mjxafa8XBJB5QWYmtlkfgLItNR81vEPBLXcFapXSyz05jQfHi5juPcBFvywsbaR20kazXfzMC8OuOWoW+zclpx1lXoT7T9Zsp40vrH6f9fNFWsrohxp9xK7/noMGmgZFXw1WEIpTIarOlmCiPukNBb15AYKRH+sFNVi4ytI9Cl+PEsUPov1uY+DsE8tz0+3z1ODJzprP+On5Qk9bUxusnCOKj4MsHUwYK1trkegXB42jypWSs7zFVST1KzToWD9YDQ+1b8Cc6zpzeR0sR3vnutnxjjikQo4GOD+82QyHAZDTc1t6QgUg9oDLRaoeMkCPgwi2VFFFR6ChBC6UUA1RNao9dafFHvxbIRhwe1TuccszwEJbpST4HnN9ViTuGyTwb+IF2QzfaoenzyeSW4HAMCQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y3um7o1uIK6h7TGKJdi4yduN5GCOET5DE8C17rxgTw5IMizla3uc1a4kbuLn?= =?us-ascii?Q?/IjDTJWegAK6LpmTP483DiBim4hHS/ZqS+r7g/HlDq+/iFVRGCnd9atWViyX?= =?us-ascii?Q?v5+XjeLUag2HdWMmL00X7pqkk8MmZwzvm4NnFS4wQinOijvfdhR9gIsxy3yI?= =?us-ascii?Q?OSQ5jC5uD8Fw0P5wbgM/u13T7fEuV87l9vIdJwVmZ++hSN0AcdrFNZbqYRGM?= =?us-ascii?Q?8m60wRfGqt2YmynNxEyVpvpNq+GwEOLHQqUudLsF4/xSBvVCvZU8k+w3J/wi?= =?us-ascii?Q?hTpkiTIYzARaC2qegRW4d23Dp5T222lyW2zf0CvrD7OzELJFoTm2pR69E2uv?= =?us-ascii?Q?0XsmT1W5Ato6C4/XlEbmMvSnkBZ05nYtMhg8j19kad75Z2IuMWe4DWW/q/A/?= =?us-ascii?Q?IUfQo8PwcdPlq7tut3KwQLDkhZYS4U/MrBYAZViIih7G4sR+jho/56Vlpcjg?= =?us-ascii?Q?er32vw6o1UEQ8WFQ+mKA0lWSkjTSFOZZMWQpwACosnqNTsI/fw8v3S1a4z45?= =?us-ascii?Q?NOZ3gdeu2POz8ZoDBjR2rWeV6r+FERZHlOeboyoXU7FjcRn+4bHWvGXwMpIB?= =?us-ascii?Q?E04pAvhZ5+l4m3nQtqYPXBHcMkp3fAcEF13cjQWHcBRfKTLwjFtnX5Q6f4gc?= =?us-ascii?Q?JG7mlGGBXy2nHdIhgkJoBDcysJ/n7o+rfoOfc9amUj9tlfGUnA8A9LrDD0gD?= =?us-ascii?Q?J9bYWpVCICEy5fNMW1sTX/oNf/mXBJFn7BVNz+Ru3LsrSNQ8GB1EiWB+lhN4?= =?us-ascii?Q?jzzgr/Qz6Q1K/Rv7yGF2+bKGIynvhb09v4Xr1zCqTltiELzKY9TRxO7XdWdp?= =?us-ascii?Q?Qm+walh+vO8sfg0AH+uoogVRGM8GvQClnjA8FdUx+02aEtQKqiunbYPskfWG?= =?us-ascii?Q?tsYTnOyZYk04KyfyZPrj+8BWh8+c5PcDyrELI4jGCKvlahyHnqqOA1ZRCDT0?= =?us-ascii?Q?Qso5hY8rnbtQ1KtuxNkGbdcPMf/zPYFa0O4btDSo7G7PrpkvXxS/UmAfyC8F?= =?us-ascii?Q?jaJYwMXbaqAYrQmO/yJZdfxXZUuqzgnreyH8gnaUpEOQAfZ3HI5j4mLE+g5O?= =?us-ascii?Q?9FEhLZntzLmzrVqgfQw3/3kapmKhP4cPHwitm3NvCVE/MVCxApR/snIPs3hA?= =?us-ascii?Q?RiAA5gQpcM/iBQ3287b1mrDCM84aU3NH/y6GT70NSrPTV/OXLj+3XIfE1pVX?= =?us-ascii?Q?KTEQNdv4f75YWuytTNEKDIFVQEheutftQSfn2SpmeAUBVZG4E/kHDC81N5nT?= =?us-ascii?Q?aiOvkE64MM5GscWI0sA8nKw5PFKWMOdeuRxkM4tkQvInls7V7shbtLBwMcvK?= =?us-ascii?Q?oyQu5atkK8Q0w1PgNFKOtGi0rlGswZ8wGJDUiNgzmm5w8YYEu0qyKEa3uzj9?= =?us-ascii?Q?ofMaeVK7m81d5GYE9p211VqGV2WdAw1mVgnJZm1MRjIyPTm+mPZ5PxLwxSW1?= =?us-ascii?Q?rWp1Ph4mNYnTao8CWl0TRV5Uq5XlzpNCAW8qyIA5Ab3cbJ9/oNL/F5geXJff?= =?us-ascii?Q?aMoOqeyhVE5CMTtm5P41Bc7WCt+gB5qZpSOUlSGaswlAXZKXJQcl+0tMaLdH?= =?us-ascii?Q?dXQZ2RSUQ0QeSSowTMJpo4AguRXWEzAhUteFWe5Fyy2Tl1Kfc11AYkd90JQP?= =?us-ascii?Q?VtO6gUlrqXAGPu8i23nn2Xo=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06405fed-9d54-40fe-fa92-08da84f6ebc7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 11:02:08.2824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WMFBXpVVXLZi3mKWCqf0FnR7wTIQTc1fG2YZNsvTkPh4OYGEcX9RhLjl7De8yrutP2FoDa/d2L7lBh0A+ZTezOWAXWqzE0uMq9akANMhz0U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6430 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: qb80yG5As1YFTjegbUqf4CJ0x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661252530; bh=nowHIGr5tNMeSVGLEht1QPbdkxqfW91GHLzmep5KjT8=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=iGynMRSrgu9gkt2sTOVTZGk0VnoNtneVYfxyYsBDqwwu6AKf19ab0qpC78TJna/EiPU 17IVgPkLn1Orpvz2qWLTxQiODM1Dsak1PPEg/TFmJQRqG+Y/h0fmsmLBIg+iWanKIYJug QVg7Sxy9lhvCDTt8Osqno2UtDxT5bTgh4mI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661252531463100013 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen This patch removes redundant updates of "BoardManufacturerType02" and "SerialNumberType02". Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunc= tion.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseB= oardManufacturerFunction.c index f61546955f12..3441e7798860 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c @@ -120,16 +120,6 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer)= { STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER), SerialNumberType02 ); - OemUpdateSmbiosInfo ( - mSmbiosMiscHiiHandle, - STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER), - BoardManufacturerType02 - ); - OemUpdateSmbiosInfo ( - mSmbiosMiscHiiHandle, - STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER), - SerialNumberType02 - ); OemUpdateSmbiosInfo ( mSmbiosMiscHiiHandle, STRING_TOKEN (STR_MISC_BASE_BOARD_SKU_NUMBER), --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92671): https://edk2.groups.io/g/devel/message/92671 Mute This Topic: https://groups.io/mt/93201509/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92672+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92672+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661252533702445.24537529829445; Tue, 23 Aug 2022 04:02:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id SGvgYY1788612xXK1ZG127Rk; Tue, 23 Aug 2022 04:02:13 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.116]) by mx.groups.io with SMTP id smtpd.web11.29904.1661252532481351663 for ; Tue, 23 Aug 2022 04:02:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdWwHsg4BrHEN3wdhJQ+Pxe49HFafBRbj8WD+xUhLlF11F8VsrqJrVC9H6fCsQ/P/o69nRnby6lF9Pxy095etruJRcz5PK85ECqVb7ZEYZzqhkylYFen4EUkx5zzy1VahMb82y5vPaPKmNdIvyjJP0pWBxHlRem9LR/n/l5/GWzcQYVBCVLp086zOv9bYtB2RAiUG/EV7wpRF6VJ1c7/hW3IvmT4ub2+fg5xiCpatNd2Y0RMDfZQODeifduIdU8qHMVznh4lQFpsByfFLS+Qf2A+dW5bbovdsv0stOCoq8Pd/L5+sUeju7TcsqbcNhG3QaJjPbap8MOfMW4/yPh8bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ecqN3kTZ7WHgPfuRgiGxMMrqN4fjNndd/aGaFJ0mMzE=; b=AR3ROOaEH530jrNpjhm1fM2kywsnmKinJ8AuK6b6VBMN5ClwNP74COvCM9puyWpiOwtjQAE1PHMv57ENeCKQIFk1ABHuMTktWFBz6sxkNPdZpShgyVof3QHkyXyz9tKZTglMzYO8YV+bI8BNd+5M8+yqb+OFBLTxGakflFx399tF+FptzBGJYdGq7WmPPi8Og43XeEK/jrRaPmQYAjFsXXFT0MjlWy3EKlb+2uiAKbwKM/hNeyC1Lebyuv0PAmouPWK/AlnCwr4xyfvtIl7ezTekqNkyrCm1NsrxzYXiMzZubOhEzmmaA562Yk0vIeFf20p1X+0SA1A3grb3rVgt8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SJ0PR01MB6430.prod.exchangelabs.com (2603:10b6:a03:297::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 11:02:10 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 11:02:10 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham Subject: [edk2-devel] [PATCH 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib Date: Tue, 23 Aug 2022 17:59:26 +0700 Message-Id: <20220823105926.1379824-7-nhi@os.amperecomputing.com> In-Reply-To: <20220823105926.1379824-1-nhi@os.amperecomputing.com> References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0234d4e0-9791-40de-0d20-08da84f6ed5b X-MS-TrafficTypeDiagnostic: SJ0PR01MB6430:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: LAM9qhYUH5vGd8ai0Oo+/NdWIK2t5dEOVFvttLtBLfJUVyAAYBbT3rOnZxfAlWPgS/7u8Efg6vBSs5nLPEqQMcBnOTGjh6cLRFBbnd4b2y2pgux1IKthG6rXMaG5zII4NpP6RNhn++TcPBKOF1TcpNgNFBfTK3pn0XwSJJbLZpKyR4t7O1aaUxSmx5siYuMWu/J/Ix2RQ2TEFtnB/WzGK2FiDkxwrSQ7Rt0v2qUJWHTqRhGf6WK4wfqs6hrWGg+Jn+ZN57Iei5XjgNM+tqd4SkmouxtKZ8KgtoJZ2MR3PbVuprhtUZV0XU7c1kl2OwhjNvHGZDNCRMRPqflhL+IUnf8hlOz75tvvE7tp08wSlL5gBKArSxCl112lGT+Dcyz/RThncTIjjRhmaSPcRWCNU6TNrLYvPwV81vrKBy5RRnzuYAXD85mY2ChoBvYO/ph8ar898s3znT1wLzwz+iyWRwHcl3Ugzzt/hbVA4f00kxkSxu7zJ2gJPIhpQvzEcXUcVrg8dNtKMNletXlLtIfhDZHVvviglo4OPWpWTuFptnLhQJ+sQb9mcvIBonu2ANu9jSOc9CzLyLziQCpfhsISElcAhFFgWcdaXjxCDXp/uR8VAQUETdgS9wujJH9yGvjczb02adSfICMT1Gxe1i5ez/E6RD2efxbMJm5nz9lBI2baag3YxdgUmLWtsP1yobmWy9C14fR4W+mmMUAth561ok/MMqRlRRVzvmvsywWQMsnhFdRcUq55EVI3dNyANLzxZ+ATS/5G0xGATxbJcK6evWc2O2w2o3N9YQpSxxE0gu0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wF1dgovyx6kla1yqpM92kZJQCy8wgaKB7rRxQynR0LqaMnkoZMGsm0p3D8Dh?= =?us-ascii?Q?hhhKnd5w3mKab4v9ujGm6UGZ5xbFmgcJdb3kDxPIUpHjKxvDCqXUGlYi06F+?= =?us-ascii?Q?WbthLSPF1a4wa/D53+OhH+0pfevhFiBgJweswfvfP6qV3XhmZVcOiU9ineoa?= =?us-ascii?Q?WG69SICrdKQnKNc8HnDGGIK53xjYv/XcEQJIjxuh2V3ofuMNn5d/pFAam3bG?= =?us-ascii?Q?pte8bm8R8dcxuckkTt5GpHoJipkO5uDVhgg0fo4RkFHjdhbQfRpQWRupI255?= =?us-ascii?Q?vQLPUGQ5oMc0IZKlk/pzJigTnJnSQ7V0ioUvaIV7wXdqaaJDB7iNs3IUUXWL?= =?us-ascii?Q?ud2KIPpQg5b6HYimrclNzV2f21v82Mpw4HU5bFBxI5cSc/ZeaHnTu1yfDOob?= =?us-ascii?Q?/ingJqyGlLrKv+TccsAM33e3/uApvvYbVy2ust8SP4stwY5qMfNj3vTRy2/b?= =?us-ascii?Q?WEAjWfx2szbvIjSbO6UJbWwvqSfOZMWLLl1ZlWsOJgWjsjK12lgc5po1Cdtf?= =?us-ascii?Q?CbnExArOXNl/6ylYIc9XTt/n0sjH9B3DataXVKhXrV0sI2n4cG34HNdY63hf?= =?us-ascii?Q?+VstH44eTkNr6MofAVVJiGGYtMayX2CQmICWvyUQePja3dsJrPPK6/1jgk3R?= =?us-ascii?Q?MOTpELT4hHrr1KXZ42aRS/rVbCplhVdoQwDIuooBvP/zpzVjqrA2+GOI/YbF?= =?us-ascii?Q?UtR6dG5ZcGqNT6RZ7w+p9ZClHtAqb4Lo7QVZ8aTf1JZKX0SqcyYBxjtX0rdn?= =?us-ascii?Q?pwePykp7H3iFD0YvnnNg/OrKUQhAuYBXy+wNFq65C7xsphIGrwv4t5ThnvvV?= =?us-ascii?Q?XH6fyudJpgfrHAvmL+hahXmY5AYJeBpcvgRH1BzUCDdaTvL2Ojewhs/xTeHT?= =?us-ascii?Q?5/31aFXkv4rN9t2VkwU/IJ7bJ1aGQNH7JMvdR/J5vIX5uqyAr/Srcj8A2dDu?= =?us-ascii?Q?tyNJL5oG1LNtLx5WhCN2m+kni4Cfme0jlNHZEAWzTTvKtRr8IBJWOxXq04sI?= =?us-ascii?Q?DOBvl/SiRSUG3JAEo5Y4yyPodskCGdoDFEwitQRs0Mr3leL0Y5ih76ulN99m?= =?us-ascii?Q?cAcBQHbRQ7yypE1FIipNi7BaT+95UCS3Wsgt3vo6iU942k+xWAcho70dpEcL?= =?us-ascii?Q?aIjesswazfsm2nxzLCZZQUs/adnsPeYdF+mxTmRojaC4UyxugqSoFjmbiaiS?= =?us-ascii?Q?i215thaNKxIW15oehpP0XDHKnmdfrC0RIBbizLbbBqRbRZ2cI3DIo92Bm8rf?= =?us-ascii?Q?D8/lH3nDc98KhP4mpgoPi8r871p/BWt3bAVoqSWmY0hECnOKd0jeYfhXzK6e?= =?us-ascii?Q?3AjQeFPW5OxS2ihowaf/9wp6bjklFK4ZpnrfHn3TPMDGtsDKH5gbvcMjcVRc?= =?us-ascii?Q?F/qq+s58+S8nnTmcdOnDUDZx7V+QQrGfaNIsakGQeBJl/cxkmj+5VK0MlCxn?= =?us-ascii?Q?fh/D4jVDP7pStlyOFT7Z/3IC1tP6hNlcBUjvrRFOpr5Te1oHLV/uTBZ5ghM+?= =?us-ascii?Q?4WdVanCw+ZgI4TJnM87+7fqoEbNYUYlOCPKtjhyn4I4sJsg6H0OPqAut+6sx?= =?us-ascii?Q?BJVkqpDz2057qg0awmWCvDEZ1QI5/vr21D1TcVt6OUCu+U66TmbJzYOfNxiY?= =?us-ascii?Q?A4dPzF1K3Ic9qf2Wgil/6yQ=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0234d4e0-9791-40de-0d20-08da84f6ed5b X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 11:02:10.7678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WhfT144ecMTS7NVnDCeGhn5PlUbcYazisxNLi3GOh5Rxx8Gy4SzxL8uGJmKpR/eruX3SXznnARkdDSbjFkEosAw1+XMYU7HFf+MuvfW+QrU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6430 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: iEbHdevgY1N3CyiD1zGuzXvtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661252533; bh=UlPA5kiBneHVdk1J9Jp9g2Yx6QFGX31rX8YW0380ZTY=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=WP0JpqiLf/MT/FB0PfyC22eGyqRmMiaCxhuNfwVarvU2hs4Bj+qZFlPGuu8ktZJe6CK y1DD7cxEUDu8FpaeemhXxj24dIHeeazsnG/9lRRRRyo1JIuwTZiFDOEI19agvMoQi215h fJv9BtdMohxrJzZM24WGltHmXk1X4ikU3hA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661252535512100019 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen In some scenarios, the information of Bios Version, Bios Release and Embedded Controller Firmware Release are fetched during UEFI booting. This patch supports updating those fields dynamically when the PCDs are empty. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h | 21= +++++++++++++ ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 28= +++++++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 32= +++++++++++++------- 3 files changed, 70 insertions(+), 11 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 1936619d9b5b..541274999e5c 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -37,6 +37,7 @@ typedef struct { } OEM_MISC_PROCESSOR_DATA; =20 typedef enum { + BiosVersionType00, ProductNameType01, SerialNumType01, UuidType01, @@ -247,4 +248,24 @@ OemGetSystemUuid ( OUT GUID *SystemUuid ); =20 +/** Fetches the BIOS release. + + @return The BIOS release. +**/ +UINT16 +EFIAPI +OemGetBiosRelease ( + VOID + ); + +/** Fetches the embedded controller firmware release. + + @return The embedded controller firmware release. +**/ +UINT16 +EFIAPI +OemGetEmbeddedControllerFirmwareRelease ( + VOID + ); + #endif // OEM_MISC_LIB_H_ diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/U= niversal/Smbios/OemMiscLibNull/OemMiscLib.c index 32f6d55c1a9a..788ccab9e8c1 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -254,3 +254,31 @@ OemGetSystemUuid ( ASSERT (FALSE); CopyGuid (SystemUuid, &gZeroGuid); } + +/** Fetches the BIOS release. + + @return The BIOS release. +**/ +UINT16 +EFIAPI +OemGetBiosRelease ( + VOID + ) +{ + ASSERT (FALSE); + return 0xFFFF; +} + +/** Fetches the embedded controller firmware release. + + @return The embedded controller firmware release. +**/ +UINT16 +EFIAPI +OemGetEmbeddedControllerFirmwareRelease ( + VOID + ) +{ + ASSERT (FALSE); + return 0xFFFF; +} diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFun= ction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFuncti= on.c index b49c4b754cab..e9106a8a2fec 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c @@ -1,5 +1,6 @@ /** @file =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2009, Intel Corporation. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved.
@@ -13,6 +14,7 @@ #include #include #include +#include #include #include =20 @@ -191,11 +193,11 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BIOS_VERSION); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); } else { - Version =3D (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString); - if (StrLen (Version) > 0) { - TokenToUpdate =3D STRING_TOKEN (STR_MISC_BIOS_VERSION); - HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); - } + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BIOS_VERSION), + BiosVersionType00 + ); } =20 Char16String =3D GetBiosReleaseDate (); @@ -251,13 +253,21 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { } } =20 - SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(PcdGet16 (PcdSystemBios= Release) >> 8); - SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(PcdGet16 (PcdSystemBios= Release) & 0xFF); + if (PcdGet16 (PcdSystemBiosRelease) !=3D 0xFFFF) { + SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(PcdGet16 (PcdSystemBi= osRelease) >> 8); + SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(PcdGet16 (PcdSystemBi= osRelease) & 0xFF); + } else { + SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(OemGetBiosRelease () = >> 8); + SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(OemGetBiosRelease () = & 0xFF); + } =20 - SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16) - (PcdGet16 (PcdEmb= eddedControllerFirmwareRelease) >> 8); - SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16) - (PcdGet16 (PcdEmb= eddedControllerFirmwareRelease) & 0xFF); + if (PcdGet16 (PcdEmbeddedControllerFirmwareRelease) !=3D 0xFFFF) { + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16)(PcdG= et16 (PcdEmbeddedControllerFirmwareRelease) >> 8); + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16)(PcdG= et16 (PcdEmbeddedControllerFirmwareRelease) & 0xFF); + } else { + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16)(OemG= etEmbeddedControllerFirmwareRelease () >> 8); + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16)(OemG= etEmbeddedControllerFirmwareRelease () & 0xFF); + } =20 OptionalStrStart =3D (CHAR8 *)(SmbiosRecord + 1); UnicodeStrToAsciiStrS (Vendor, OptionalStrStart, VendorStrLen + 1); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92672): https://edk2.groups.io/g/devel/message/92672 Mute This Topic: https://groups.io/mt/93201510/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-