[edk2] [PATCH edk2-platforms 0/8] SynQuacer updates

Ard Biesheuvel posted 8 patches 6 years, 4 months ago
Failed in applying to current master (apply log)
Platform/Socionext/DeveloperBox/DeveloperBox.dsc                                                     |  16 ++-
Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf                |   1 +
Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc          |   6 +-
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc                                         |  18 ++-
Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf          |   1 +
Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc    |   6 +-
Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi                                                |  57 ++++----
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c                                               | 140 ++++++++++++++++++++
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c                                        |  13 +-
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h                                        |  37 ++++++
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf                                      |   3 +
Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c                    |  94 +++++++++++++
Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf                  |  42 ++++++
Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.c            |  19 ++-
Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf          |   4 +
Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLibConstructor.c |  58 +++++---
Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.c                |  70 +++++++---
Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.inf              |   2 +
Silicon/Socionext/SynQuacer/SynQuacer.dec                                                            |   5 +
19 files changed, 504 insertions(+), 88 deletions(-)
create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c
create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h
create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c
create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf
[edk2] [PATCH edk2-platforms 0/8] SynQuacer updates
Posted by Ard Biesheuvel 6 years, 4 months ago
A round of updates for Socionext SynQuacer:

- enable CPU idle states in the DT, so that the OS can put cores to sleep
  using PSCI (#1)
- add the build number to PCDs that end up in user visible strings (#2)
- fix a PCIe detection issue in the DeveloperBox x16 slot, by keeping PERST#
  asserted for at least 100 ms before link training (#3)
- ignore PCIe RC #0 if no card is inserted on EVB (#4 - #6)
- add the secondary UART to the DT for the OS to use (this is UART #0 on the
  LS connector on DeveloperBox) (#7)
- explicitly retrain the downstream links on the Asmedia 1182/1184 PCIe
  switch, to enable Gen2 speeds

Ard Biesheuvel (7):
  Silicon/SynQuacer: enable CPU idle states in device tree
  Platform/Socionext/SynQuacer: expose build number as firmware version
  Silicon/SynQuacerPciHostBridgeLib: stall for 150 ms during PERST#
  Silicon/SynQuacerPciHostBridgeLib: enable RCs based on PCD setting
  Silicon/SynQuacer: disable PCI RC #0 DT node if disabled
  Silicon/SynQuacerEvalBoard: enable PCI #0 only when card is detected
  Silicon/SynQuacer/PlatformDxe: retrain PCIe switch links to Gen2 speed

Masahisa KOJIMA (1):
  Silicon/Socionext/SynQuacer/DeviceTree: expose SCP serial port to the
    OS

 Platform/Socionext/DeveloperBox/DeveloperBox.dsc                                                     |  16 ++-
 Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf                |   1 +
 Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc          |   6 +-
 Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc                                         |  18 ++-
 Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf          |   1 +
 Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc    |   6 +-
 Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi                                                |  57 ++++----
 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c                                               | 140 ++++++++++++++++++++
 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c                                        |  13 +-
 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h                                        |  37 ++++++
 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf                                      |   3 +
 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c                    |  94 +++++++++++++
 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf                  |  42 ++++++
 Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.c            |  19 ++-
 Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf          |   4 +
 Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLibConstructor.c |  58 +++++---
 Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.c                |  70 +++++++---
 Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.inf              |   2 +
 Silicon/Socionext/SynQuacer/SynQuacer.dec                                                            |   5 +
 19 files changed, 504 insertions(+), 88 deletions(-)
 create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c
 create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h
 create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c
 create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms 0/8] SynQuacer updates
Posted by Leif Lindholm 6 years, 4 months ago
On Tue, Dec 12, 2017 at 10:37:59AM +0000, Ard Biesheuvel wrote:
> A round of updates for Socionext SynQuacer:
> 
> - enable CPU idle states in the DT, so that the OS can put cores to sleep
>   using PSCI (#1)
> - add the build number to PCDs that end up in user visible strings (#2)
> - fix a PCIe detection issue in the DeveloperBox x16 slot, by keeping PERST#
>   asserted for at least 100 ms before link training (#3)
> - ignore PCIe RC #0 if no card is inserted on EVB (#4 - #6)
> - add the secondary UART to the DT for the OS to use (this is UART #0 on the
>   LS connector on DeveloperBox) (#7)
> - explicitly retrain the downstream links on the Asmedia 1182/1184 PCIe
>   switch, to enable Gen2 speeds

For the patches I haven't commented on individually (1,4,6):
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> Ard Biesheuvel (7):
>   Silicon/SynQuacer: enable CPU idle states in device tree
>   Platform/Socionext/SynQuacer: expose build number as firmware version
>   Silicon/SynQuacerPciHostBridgeLib: stall for 150 ms during PERST#
>   Silicon/SynQuacerPciHostBridgeLib: enable RCs based on PCD setting
>   Silicon/SynQuacer: disable PCI RC #0 DT node if disabled
>   Silicon/SynQuacerEvalBoard: enable PCI #0 only when card is detected
>   Silicon/SynQuacer/PlatformDxe: retrain PCIe switch links to Gen2 speed
> 
> Masahisa KOJIMA (1):
>   Silicon/Socionext/SynQuacer/DeviceTree: expose SCP serial port to the
>     OS
> 
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                                                     |  16 ++-
>  Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf                |   1 +
>  Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc          |   6 +-
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc                                         |  18 ++-
>  Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf          |   1 +
>  Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc    |   6 +-
>  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi                                                |  57 ++++----
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c                                               | 140 ++++++++++++++++++++
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c                                        |  13 +-
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h                                        |  37 ++++++
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf                                      |   3 +
>  Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c                    |  94 +++++++++++++
>  Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf                  |  42 ++++++
>  Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.c            |  19 ++-
>  Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf          |   4 +
>  Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLibConstructor.c |  58 +++++---
>  Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.c                |  70 +++++++---
>  Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.inf              |   2 +
>  Silicon/Socionext/SynQuacer/SynQuacer.dec                                                            |   5 +
>  19 files changed, 504 insertions(+), 88 deletions(-)
>  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c
>  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h
>  create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c
>  create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf
> 
> -- 
> 2.11.0
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms 0/8] SynQuacer updates
Posted by Ard Biesheuvel 6 years, 4 months ago
On 12 December 2017 at 18:20, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Dec 12, 2017 at 10:37:59AM +0000, Ard Biesheuvel wrote:
>> A round of updates for Socionext SynQuacer:
>>
>> - enable CPU idle states in the DT, so that the OS can put cores to sleep
>>   using PSCI (#1)
>> - add the build number to PCDs that end up in user visible strings (#2)
>> - fix a PCIe detection issue in the DeveloperBox x16 slot, by keeping PERST#
>>   asserted for at least 100 ms before link training (#3)
>> - ignore PCIe RC #0 if no card is inserted on EVB (#4 - #6)
>> - add the secondary UART to the DT for the OS to use (this is UART #0 on the
>>   LS connector on DeveloperBox) (#7)
>> - explicitly retrain the downstream links on the Asmedia 1182/1184 PCIe
>>   switch, to enable Gen2 speeds
>
> For the patches I haven't commented on individually (1,4,6):
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks. Pushed as 2b3b95cb9fc9..054921cef0f1


>> Ard Biesheuvel (7):
>>   Silicon/SynQuacer: enable CPU idle states in device tree
>>   Platform/Socionext/SynQuacer: expose build number as firmware version
>>   Silicon/SynQuacerPciHostBridgeLib: stall for 150 ms during PERST#
>>   Silicon/SynQuacerPciHostBridgeLib: enable RCs based on PCD setting
>>   Silicon/SynQuacer: disable PCI RC #0 DT node if disabled
>>   Silicon/SynQuacerEvalBoard: enable PCI #0 only when card is detected
>>   Silicon/SynQuacer/PlatformDxe: retrain PCIe switch links to Gen2 speed
>>
>> Masahisa KOJIMA (1):
>>   Silicon/Socionext/SynQuacer/DeviceTree: expose SCP serial port to the
>>     OS
>>
>>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                                                     |  16 ++-
>>  Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf                |   1 +
>>  Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc          |   6 +-
>>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc                                         |  18 ++-
>>  Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf          |   1 +
>>  Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc    |   6 +-
>>  Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi                                                |  57 ++++----
>>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c                                               | 140 ++++++++++++++++++++
>>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c                                        |  13 +-
>>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h                                        |  37 ++++++
>>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf                                      |   3 +
>>  Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c                    |  94 +++++++++++++
>>  Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf                  |  42 ++++++
>>  Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.c            |  19 ++-
>>  Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf          |   4 +
>>  Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLibConstructor.c |  58 +++++---
>>  Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.c                |  70 +++++++---
>>  Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformPeiLib/SynQuacerPlatformPeiLib.inf              |   2 +
>>  Silicon/Socionext/SynQuacer/SynQuacer.dec                                                            |   5 +
>>  19 files changed, 504 insertions(+), 88 deletions(-)
>>  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Pcie.c
>>  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.h
>>  create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.c
>>  create mode 100644 Silicon/Socionext/SynQuacer/Library/SynQuacerDtbLoaderLib/SynQuacerDtbLoaderLib.inf
>>
>> --
>> 2.11.0
>>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel